From: Igor Klochko <igor.klochko@gmail.com>
To: Christoph Hellwig <hch@lst.de>, linux@armlinux.org.uk
Cc: iommu@lists.linux.dev, robin.murphy@arm.com,
m.szyprowski@samsung.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arch/arm/mm/dma-mapping.c: fix __alloc_from_pool returning a dirty buffer
Date: Fri, 23 Dec 2022 23:51:43 +0100 [thread overview]
Message-ID: <43ef46fc-2fbc-31b7-d683-f7496b39dae5@gmail.com> (raw)
In-Reply-To: <20221223143938.GA29147@lst.de>
Thanks Christoph,
Added fixes and a changelog.
This issue is present in all current LTS versions.
----
Buffers allocated by __alloc_from_pool() should be zeroed out as done by other allocators.
Certain drivers expect a clean buffer and clearing the buffer is beneficial from the security point of view.
---
Fixes: 36d0fd2198da3 (*arm: use genalloc for the atomic pool*)
Signed-off-by: Igor Klochko <igor.klochko@gmail.com>
---
arch/arm/mm/dma-mapping.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index c135f6e37a00..bb2bb3ab497a 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -366,6 +366,7 @@ static void *__alloc_from_pool(size_t size, struct page **ret_page)
*ret_page = phys_to_page(phys);
ptr = (void *)val;
+ memset(ptr, 0, size);
}
return ptr;
--
2.39.0
Kind regards,
Igor Klochko
On 23/12/2022 15:39, Christoph Hellwig wrote:
> On Fri, Dec 23, 2022 at 03:15:47PM +0100, Igor Klochko wrote:
>>
>> Hi,
>>
>> A small patch for __alloc_from_pool to clean the buffer before returning.
>
> This does look correct. The "normal" allocators seems to do the
> memset through __dma_clear_buffer, but the __alloc_from_pool seems to be
> missing it. Please write a proper changelog with a signoff, and
> preferably a Fixes tag if you can find what introduced this. Also
> the ARM code needs to go to the ARM maintainer and arm mailing list.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2022-12-24 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <14dccd8c-e29a-fe93-5d4c-f0c3ff4f2430@gmail.com>
[not found] ` <20221223143938.GA29147@lst.de>
2022-12-23 22:51 ` Igor Klochko [this message]
2023-01-03 9:51 ` [PATCH] arch/arm/mm/dma-mapping.c: fix __alloc_from_pool returning a dirty buffer Russell King (Oracle)
2023-01-03 13:58 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ef46fc-2fbc-31b7-d683-f7496b39dae5@gmail.com \
--to=igor.klochko@gmail.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).