From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C84F1C3271E for ; Fri, 5 Jul 2024 15:21:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hwXx7X/JWO629nMGozpbxOU/sJMCVJf7jb2Wh2OBaFo=; b=4lmtTRdgluJasIdm25yawtxXFe 2lQpWQ6MsLxh4+nxXyx71liYPGO4iR9uA2Z9820ljC242Elc5Q8KRt3NVy8dM1NgeXCKECkIRKjLb 6/mWpPaHOe5lIUQMUTQORbByGuqaGenT6SI99Spds/DUU0n8iaamXf9LI6PO3YPs0Dl9l6H4YIVII 3B8RZoqTNPFF0o5Rgjpemq8cYBpwdYlTR9v+UUeMFCEHZ7DetfmqObX5ajb7X2yffOHZZC2+v/IaI 0jTDxkWs8667Yln/d+NMfA2CiUJFfAtwhE+Ok5u9sENl8m+dW+R8QHjhkSuZ05LSgku2lTJQVDW8J A3krz6Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPkkm-0000000GJq3-3ecQ; Fri, 05 Jul 2024 15:21:40 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPkkX-0000000GJnV-3aus for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2024 15:21:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1720192868; x=1720797668; i=wahrenst@gmx.net; bh=hwXx7X/JWO629nMGozpbxOU/sJMCVJf7jb2Wh2OBaFo=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=oAIdPXs3mQlwtD2Kv6SVDhIT3WbZhYmmB7E8msKCEaeZzlnpofm5Vk0vBjiNOaqm C2zR7aS8SjSTTsnL4RLXYXy2eADdjqZXxiS2+SbS0NYnoDhSvUpQAQ9f6Z0wd9rjU NvP66HksPR13Q7yZO9bjhRDWVg1mBS3aX3Ys/tD7GcmnWRfu1+/NMSsVOykKhv74M jpHdbPg4MhSjIiKALFJUQRjeqt5HbW0VDN3YYfm4YBxMiohoiL/kUDABbEuWiEurT YB/StJdWzhnoLgh5mqhYSZ4sYTRypNBqwgZ1UCnj3aoF4nRNTX6pV2K0LwSrvYcYp 3nUu/sZN1yll+Ar5SA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.127] ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MuUj2-1s8uNq0H22-00rvkj; Fri, 05 Jul 2024 17:21:08 +0200 Message-ID: <43fa421c-5e5b-40a6-a546-d80e753586e3@gmx.net> Date: Fri, 5 Jul 2024 17:21:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs To: Lukas Wunner , Jeremy Linton Cc: Florian Fainelli , Minas Harutyunyan , Greg Kroah-Hartman , Ray Jui , Scott Branden , Maxime Ripard , Thomas Gleixner , Jassi Brar , Ulf Hansson , Jiri Slaby , Dave Stevenson , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Peter Robinson , dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-list@raspberrypi.com References: <20240630153652.318882-1-wahrenst@gmx.net> <20240630153652.318882-10-wahrenst@gmx.net> <95762956-b46a-4dfa-b22f-bccbfa39558d@broadcom.com> <4502d826-d80c-4a98-a889-da7badfa698e@gmx.net> Content-Language: en-US From: Stefan Wahren In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:BJGrNpbHXbxVeXDB3xE978jxAJSmTOKF7NAPEoMIBFmnco1FxmF lZkHxE5fWXY5JkJWk7/VhhpCAfRjCJVJESnrVJW7aLJ2N/Y9dsXV1doNgYEoQbZ5ldT1+VO A+Odv1KyVh8vVPyj9xWw4ZAHA2xuIQBFiDmsU6sfpUVbOSZHbOhDRHD/vdoQlOIr+g4Wlg/ 3MsXndQrf3WTVS8vQxEsA== UI-OutboundReport: notjunk:1;M01:P0:JQQ/R1k87NA=;1b+BZxXnPVoIRZHBh9XctHJp4/x 12Z+Wfgi0mUwKBUCAlQJYec5etl4ChEpvyoSWr9IdJvVqgJP73/Mo1p2P/xkZnENxTRSOrmTr TJDApa4d/H/D9tBsclA89E8TxrWgtiQUW3RMDSpIY2KRwVT6/op7ccJhWyj98kJlncJrCGQ1d Xsa8T0UwBxARN6B12ZrauAFPJ/2Z+4XFCDfP7cyrRrCEahas1/hsFXSCdMNnGNXsRzClc8Hev nksU5f3aTIN229lGXqrwXHfb4pFM+Ad3Amd/bNp9p+sB6Gizs3NotpbTuLYOK2pE33uwaaXK/ u/l8hqcAHtgFCO2IpKQN1cKU+bdEoncl7sX6+wUPcw5dpeYtd/XaUxHWabQPn0a+Jovy6o07t GK5UY74mXa464sOPWQVFpXfr/rcu0uDTZSIi6Ve5DMtS/fi9TXT78F2cjbk9wL0xPSeYRq8lt gUErMLVfgAFdhBngda62lkwkqBH2+7fYVpPdTfYcKiwjD5ciLq+8zK2iC6HdGYil1j8ialKVn a9lrANOqqXVtHCVAcSmoKp18ACeOwk4qo/YQXN61+6vNOJcBlp2m65gh6ZjYGpC4Zzg5EIEbd Nh2gg/b9tO78dnmidxHClHQCgIFqnNij+Fznt7KDBF/ZjEpkwNXR9FaT5NQtRcc78q5Se78bx qEi8Ux7Zhs8CNU52QjUGZPzs7RD0Ka+g2uC1FLrLRME/1nJB8vUZl5H/Z6Hyi66lSKBCoRBzy oM+eTunrR3ZUXPWrM8JQLZUNICB9ZkPhBfsFQeKIIPtXZQc8CW3DntFK7EKS2Iw/OngDsxuVk pEt/rNuIZAXpu9a/DZoL24nQr9wxzll9arxysdXnuGdgY= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240705_082126_195239_CB47FDA1 X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jeremy, Am 05.07.24 um 17:03 schrieb Lukas Wunner: > On Fri, Jul 05, 2024 at 12:22:33PM +0200, Stefan Wahren wrote: >> Am 05.07.24 um 10:48 schrieb Lukas Wunner: >>> The real question is whether BCM2848 platforms likewise cannot disable >>> the clock of the dwc2 controller or whether this is specific to the >>> BCM2835. Right now dwc2_set_bcm_params() is applied to both the >>> BCM2848 and BCM2835. If the BCM2848 behaves differently in this >>> regard, we'd have to duplicate dwc2_set_bcm_params() for the BCM2835. >> From my understand BCM2848 refers to the same SoC, but the ACPI >> implementation uses a different ID [2]. So I think this is safe. >> [2] - >> https://patches.linaro.org/project/linux-usb/patch/20210413215834.3126447-2-jeremy.linton@arm.com/ > Careful there, the patch vaguely says... > > With that added and identified as "BCM2848", > an id in use by other OSs for this device, the dw2 > controller on the BCM2711 will work. > > ...which sounds like they copy-pasted the BCM2848 id from somewhere else. > I would assume that BCM2848 is really a different SoC and not just > a different name for the BCM2835, but hopefully BroadCom folks will > be able to confirm or deny this (and thus the necessity of the quirk > on BCM2848 and not just on BCM2835). could you please clarify this situation? Thanks > > Thanks, > > Lukas