From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA78FC433F5 for ; Tue, 22 Feb 2022 14:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TmjDUO+bfvnkzEgz+grgmxeY7hA7Zwt6N5mvm+uh1R0=; b=TYvN87LZ98Ndnr 3lxu8jKV8qLRrqb37s1hxPIdDsVrCJfiawW1PhNPQxkM24KWZTV8TV19NsY6AFVkGmZTnDDA4Se7h 9ycaLLX10cv3sEqgHztYnqOvgQ0nLbnsbx9JkGowdgVCAv+qCb9VjW046S1QoB0vCj00nsyNCUrQj lP/T1rbx333rkf/IUXcUDqyqRI/yFsFXQtklwVbYsriKuWO4KCeSmIDLgc0AvBDGJnFmaQ0zS2dqv AuQ4cn9vsCRtoTnvfPy2GT0niEirsBWN/hNx7VCy1leUMJ5GjBiXdMFK01KiE/xG2vzq7tm5IAXD0 1sS2RQKcPge+A7PzcPqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMW6H-009stm-Fc; Tue, 22 Feb 2022 14:25:09 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMW6A-009srZ-Uv for linux-arm-kernel@lists.infradead.org; Tue, 22 Feb 2022 14:25:04 +0000 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A99744001E for ; Tue, 22 Feb 2022 14:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645539900; bh=oLmgNElh3QDEmFp83m0Fp5tLvQ90LkYaGsTK1HcNipU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UL8lWb72vSrKHJxl0Rrd36NGjFuCicV3aAe5JhepiQVXti/gALqjd8MyfIRRKSt/4 ArsEgC2whhRO8GkejfNKV3L7XhNHKIj9igCd6DoctVs0cbCVKq5CGBedqLv/5utLwW LJPs2FWe6/qgGPc8+GSzmDwCYFPpGp30r1P+4pPGimEO/j55PHetFHwkfInLHXZpEX PSF3yQdSkTpNrYBZ35pnNz8ZHpIUV6PJShD/9lxvUA2q1xvfGdG/ccVcmSmMWwluSY MfAVOUBeZyZxqWjtbwWrWWnzDX8c/5AQIKkGj4H3ZmVjOLAF/PFw9kPaKsHhIeLkP+ pBHOFaWsTkmLg== Received: by mail-ed1-f72.google.com with SMTP id l24-20020a056402231800b00410f19a3103so12070727eda.5 for ; Tue, 22 Feb 2022 06:25:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oLmgNElh3QDEmFp83m0Fp5tLvQ90LkYaGsTK1HcNipU=; b=g9vBzLT+tg3FNwi87wBtJIgIj8mU6fgKL6aJWwniNLsT6EkxEP4+aiIvp5IaeNyN/0 1WG4Opi/jTJrm4jHf0nf78w+OetHy6rKBvcEEcx2n0bmFeypzMoFJjrE7fao7VI7Z9LY qG17bKoGq2PhN8rLvHUb4abAgG4vGzTQvkiO42WUZmc+PpXY/J10Yb4qDGbuAeHZUdAf 8xyGwZxFEoUs9SM3RfDic90/m1R4V9i5jBP4P3Wzkj5sdCanEBqH+BtrDLU3R2PGRrfe 6N/uSsAFPt/j6E+ZXkoHn8j7y4fMkmekypLddcGG5J3dAJJNTglgi/Rw+cMG1zdgCkgY cvBw== X-Gm-Message-State: AOAM532jj5dfa/j3jxof5nirv+u2bcW+hsEmdwlFBTAj194Smdv2tA2Y ybxb/Yxuse3T1yZqBlQr/vAw/XKZI7uXGGrQ5bWwEzGQTGp3vlZ5XmFKNTLSc+z36IIqdaZ2dAV Z2oxO0aXvMk9WqYsni0WiUxjineblwL7I8whh+SecvS+ujnj5LORU X-Received: by 2002:a17:906:585b:b0:6b7:73bc:5395 with SMTP id h27-20020a170906585b00b006b773bc5395mr19613928ejs.519.1645539900137; Tue, 22 Feb 2022 06:25:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJxl0yq1XSLXZ0+HDlfLiBmXD2SvohoRTlnHKcrDqgm19cQZEHXWv5q9E/EvTn/sgLY68mRXog== X-Received: by 2002:a17:906:585b:b0:6b7:73bc:5395 with SMTP id h27-20020a170906585b00b006b773bc5395mr19613910ejs.519.1645539899914; Tue, 22 Feb 2022 06:24:59 -0800 (PST) Received: from [192.168.0.124] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id v24sm6274735ejf.7.2022.02.22.06.24.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 06:24:59 -0800 (PST) Message-ID: <4401de4a-caab-c5a1-f415-d30e99260404@canonical.com> Date: Tue, 22 Feb 2022 15:24:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC PATCH 8/8] arm64: dts: ti: use 'freq-table' in UFS node Content-Language: en-US To: Nishanth Menon Cc: Alim Akhtar , Avri Altman , Rob Herring , Wei Xu , Andy Gross , Bjorn Andersson , Vignesh Raghavendra , Tero Kristo , "James E.J. Bottomley" , "Martin K. Petersen" , Chanho Park , Srinivas Kandagatla , Jan Kotas , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220219184224.44339-1-krzysztof.kozlowski@canonical.com> <20220219184554.44887-1-krzysztof.kozlowski@canonical.com> <20220221131340.q3hjpjevqrfvhggv@specimen> <19705501-2391-14a4-0eac-4b2b647a9735@canonical.com> <20220222140721.bzbspfcethml2psm@running> From: Krzysztof Kozlowski In-Reply-To: <20220222140721.bzbspfcethml2psm@running> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220222_062503_320330_F8BC8534 X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/02/2022 15:07, Nishanth Menon wrote: > On 14:20-20220221, Krzysztof Kozlowski wrote: >> On 21/02/2022 14:13, Nishanth Menon wrote: >>> On 19:45-20220219, Krzysztof Kozlowski wrote: >>>> The 'freq-table-hz' property is deprecated by UFS bindings. >>>> The uint32-array requires also element to be passed within one <> block. >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> --- >>>> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >>>> index 599861259a30..c3afef0321ae 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >>>> @@ -1257,7 +1257,9 @@ ufs@4e84000 { >>>> compatible = "cdns,ufshc-m31-16nm", "jedec,ufs-2.0"; >>>> reg = <0x0 0x4e84000 0x0 0x10000>; >>>> interrupts = ; >>>> - freq-table-hz = <250000000 250000000>, <19200000 19200000>, <19200000 19200000>; >>>> + freq-table = <250000000 250000000 >>> >>> is much more readable and less error prone in case of a large >>> set. >> >> Pairs are easily visible if split per line, so readability is similar. >> Not much is lost. >> >>> >>>> + 19200000 19200000 >>>> + 19200000 19200000>; >>> >>> are you sure the removal of the tuple adds value? >> >> DT schema requires it, or rather: I do not know how to express uint32 >> tuples in DT schema. All my tries failed. > > https://www.kernel.org/doc/Documentation/devicetree/bindings/opp/opp-v1.yaml > comes to mind.. This works nice, thanks! Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel