From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A578FC43334 for ; Mon, 27 Jun 2022 20:35:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N+TmbIYP60VRhg75kgCisvDDG1jrCkCOxRV+qgvyIDs=; b=YOlUCuSaPM++RE 77XYxQ7BVuvAMwYoyDBcN1Ifo4NIsJYVv86MsDBMyf3/GEVCHHmgTIopQIP+Ibfay6Lup4sYpc6P+ r/myQYiIp41Gl7+4ZY4yGtpWfaPRlp0D0vvD/pxeR/iVP6jicZ0Yb3WFalGpcqxnZI1iEZh8yd+x7 G1t961Ka+cmUKnJi++3OW++7LRKzqxlmu5EKdsgv9wpgnRLxtuS6Y/cNLfc6QQE65qqhfkuaQSHb/ iCUHe36DejKbY+xC19zKhL/S1RimxmbNPvBqT1BO/5PqjJQPLJ+bJtWHbkDFWPJpjM9P9hql/UFYe Yt+kj1/k59haF0Bf3ffw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5vQw-002mW3-8b; Mon, 27 Jun 2022 20:34:10 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5vQt-002mVI-Aa for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 20:34:08 +0000 Received: by mail-ed1-x529.google.com with SMTP id ej4so14719203edb.7 for ; Mon, 27 Jun 2022 13:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OLWwuKwhDGZ5AVt1p7fFud+w2xnXRC2cyekV81w3MDU=; b=dheqE6WHwvec6tvb6t2RbF5VQNheGf73O7aOBbWBM90uPgRY7rjxLwdopKqx72QETI 9+X7x7jSPVLe35HXCDQldILySK6vIaAFKfnX3HPBP0/j95N8DUoKhHp7021brMu9adLG yQGG2iTCry+dnpBEIfhwqQI3FsMWrs6gaWN1SzhlRdwlpU7TA0f87EBVzhZUvyEl9p+v naGmnvUsNkzChfpTJPj4aM2kXkZNXpdjNvCCAz1DtdjOEQXU3H55lUVo3BTVg3PJr9qn krDTRJOYoa/gMT7+yRFcL+eTIiPJv1z1iYTuQSFygvCy6I+O2QDSnCP6uUX6MCdwidHK IKVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OLWwuKwhDGZ5AVt1p7fFud+w2xnXRC2cyekV81w3MDU=; b=awKn85qaeVHELtupgXGkM96rQ4Ik3fX3f+8CYW4/JlYi4B5jKDbeb3yNGgh3OZiTTG C7cPDbx98iqZ0ZqJFld/0c9RwCkUhIzQb9eq9B1wXLWh8AzbYyoUsYsaDLikepYxlx61 le2owt9FESYsCtG3aqWUD2hIWtSJhMH8mHdQt8C/CHNNZli8kK+FpyYQAdJbpESAynwL 5f96kc3Mao4BHufjwpEhj4+Uoy9g4cnfmVFHsKEL9trjs8N7rCydAtiNr37nGfJebpX0 dX9+QZTjPCq0PFyEOE+sopZOFZSy2sIfXdLcY/uOMaSNRl8hsYXBeBp5BgIqJpd3mH5w 4GGA== X-Gm-Message-State: AJIora946u2NE+ErHBSrTs5a0ISzzXHzW5fFNGUhJHw79SZ1nydpwvgd 38NN6OT+Vi2b5Xumk7nxDzk= X-Google-Smtp-Source: AGRyM1t+7vYQ+AGGmRmAHAA6HQWSIKQ56fM95D1r6YAj+WD+1Y+PPYMi6z7Zq+alDcC2KC05jXGFig== X-Received: by 2002:a05:6402:280b:b0:437:9efc:a065 with SMTP id h11-20020a056402280b00b004379efca065mr5648487ede.3.1656362043648; Mon, 27 Jun 2022 13:34:03 -0700 (PDT) Received: from jernej-laptop.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id b9-20020aa7d489000000b004358243e752sm8120949edr.5.2022.06.27.13.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 13:34:02 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Linus Walleij , Samuel Holland Cc: Samuel Holland , Krzysztof Kozlowski , Maxime Ripard , Ondrej Jirman , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 2/6] pinctrl: sunxi: Add I/O bias setting for H6 R-PIO Date: Mon, 27 Jun 2022 22:34:00 +0200 Message-ID: <4405996.LvFx2qVVIh@jernej-laptop> In-Reply-To: <20220626021148.56740-3-samuel@sholland.org> References: <20220626021148.56740-1-samuel@sholland.org> <20220626021148.56740-3-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_133407_434872_5E402D83 X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 26. junij 2022 ob 04:11:43 CEST je Samuel Holland napisal(a): > H6 requires I/O bias configuration on both of its PIO devices. > Previously it was only done for the main PIO. > > The setting for Port L is at bit 0, so the bank calculation needs to > account for the pin base. Otherwise the wrong bit is used. > > Fixes: cc62383fcebe ("pinctrl: sunxi: Support I/O bias voltage setting on > H6") Signed-off-by: Samuel Holland Reviewed-by: Jernej Skrabec Did you noticed any improvement with this properly set? In theory, 3.3 V bias should always work, right? Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel