From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61158ECAAD2 for ; Sat, 27 Aug 2022 11:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MvUG7NfiZQMFWnMK4PomVmA3WjY1RnvlMFFyK7hCzkE=; b=FFUBxEg91r4nO4 o6iAvzX7FbhRywM/fukhN8iW5xS4jrjBhIpzfyrlukhfdv6WOrF4pabRLEN0hrVLEfUQcknEdJ5ub QLcJekc0KdzJSLb1hwnBX1/aLka9QIva5Q3+1aJ/HWq1gOjsWdfX0cOjvwcN6HQZKnq0Njadru4BO U1fE/XCvYBO9pmAhbuyEc8+XFJiRU6Q+YXmn62D9v5wQkHHvOZQn7O0uK8lza6XxQDZjX8Ipfhvfl g0A4SoCQjKmWUkjZTly8qibAnN1zAbSbjtLmSqDo8C/PRaIk+ejqjdOND5dVIwrTvD5WE+P0mMZ86 4UsslOf+/4ytq3o9/pyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRtf4-008NA4-L0; Sat, 27 Aug 2022 11:07:34 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRtf0-008N7u-UZ for linux-arm-kernel@lists.infradead.org; Sat, 27 Aug 2022 11:07:32 +0000 Received: by mail-ej1-x632.google.com with SMTP id lx1so7291443ejb.12 for ; Sat, 27 Aug 2022 04:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=YTgnpIcAQhmjoJuO42KDhHQ8kYtmp+eevQhLrui+w8Q=; b=kt3XpQBdk1XAcVUk34LwN7ngG9w4tNv1eBUgC+CnrocH+fLz8rubN2MZQjE5+VRDba SbZ+LzycyTE4GfUmo8xgLRKZ1NhxIPC3+AASH1znADe2cM4iUp1CP/9+o2/TD/RV+hBU XwpyS3sf7w0qUOo7VbMkiUlLUKkPTN/KGdRWfFJbRMNMkCJTCti4BOV9JsdychxKI6XQ T/DHFUW+LzjJr4fI+jy3JZ22nnRu45BWtco54nUL1Zk9aNlv0p5daSz7MRBMT6IaLdlK /tCjJTEAm916Dhqvwh9i4/cjJUtCax9UEb7Teoyd9nQ/C3tPRq1VAtsWouPpeACCBt2P K16A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=YTgnpIcAQhmjoJuO42KDhHQ8kYtmp+eevQhLrui+w8Q=; b=sqoJlBMHkBmc5aFJE3S2v/WdcbTyUNXhX9NVHT7iGUERc0AFsICWZVTTgLgFgSPVYk 5v5g2Ojnt2DQRySv08a1hWU6Q63ZKeyEUyLm6TThdlAXudhCq7Wl2l7NSRjF+F7J7pHI pFZva8Tnfw7WZDgYGvDIku8ysIyL4VK+4ItHgA/94f8CTHw+jlCw3oBX0k2Lr/v6HHYO w9HnM0B0aHaRrwnhg8B8XW3XweZRqHWzeY+8kcaErxy8uWjwPMMdSjCBJSx9WnXaIhZD lGk83cX3KZ9VW6EljEGeKtax5kdXlfgVhDTcV5Gg9ZhxM7NJKeO+YjNbSmbfzq3lPLY5 r6Zw== X-Gm-Message-State: ACgBeo3dBUrHQSszDAKbGAUpTIKGxsZL0HOIh6QsGhSf499kRwCqrPxt 4FXQMFOE1R8zYx5MGnp+gfw= X-Google-Smtp-Source: AA6agR5P8TV0zWZJbZcKt9Vo9CX2rY644iX6DJK+nF8WzC0wK6vMjLAy6F3i8u48GlLurFO/vD8k9g== X-Received: by 2002:a17:907:7625:b0:73d:6593:6562 with SMTP id jy5-20020a170907762500b0073d65936562mr7835903ejc.505.1661598449106; Sat, 27 Aug 2022 04:07:29 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id es5-20020a056402380500b0043bc4b28464sm2521426edb.34.2022.08.27.04.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 04:07:28 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Yang Yingliang Cc: mturquette@baylibre.com, sboyd@kernel.org, wens@csie.org Subject: Re: [PATCH -next 2/3] clk: sunxi-ng: ccu-sun9i-a80-de: Use dev_err_probe() helper Date: Sat, 27 Aug 2022 13:07:27 +0200 Message-ID: <4427774.LvFx2qVVIh@jernej-laptop> In-Reply-To: <20220827094151.3323450-2-yangyingliang@huawei.com> References: <20220827094151.3323450-1-yangyingliang@huawei.com> <20220827094151.3323450-2-yangyingliang@huawei.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220827_040731_017137_8D2A56E0 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sobota, 27. avgust 2022 ob 11:41:50 CEST je Yang Yingliang napisal(a): > dev_err() can be replace with dev_err_probe() which will check if error > code is -EPROBE_DEFER. > > Signed-off-by: Yang Yingliang Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c | 19 ++++++------------- > 1 file changed, 6 insertions(+), 13 deletions(-) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c > b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c index f2fe0e1cc3c0..1d8b1ae1619d > 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c > +++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c > @@ -213,21 +213,14 @@ static int sun9i_a80_de_clk_probe(struct > platform_device *pdev) return PTR_ERR(reg); > > bus_clk = devm_clk_get(&pdev->dev, "bus"); > - if (IS_ERR(bus_clk)) { > - ret = PTR_ERR(bus_clk); > - if (ret != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret); > - return ret; > - } > + if (IS_ERR(bus_clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk), > + "Couldn't get bus clk\n"); > > rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); > - if (IS_ERR(rstc)) { > - ret = PTR_ERR(rstc); > - if (ret != -EPROBE_DEFER) > - dev_err(&pdev->dev, > - "Couldn't get reset control: %d\n", ret); > - return ret; > - } > + if (IS_ERR(rstc)) > + return dev_err_probe(&pdev->dev, PTR_ERR(rstc), > + "Couldn't get reset control\n"); > > /* The bus clock needs to be enabled for us to access the registers */ > ret = clk_prepare_enable(bus_clk); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel