From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAF42C25B75 for ; Thu, 6 Jun 2024 10:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ohR6cuOaoi1g0R80EjvMx1VRS6gVAvhIx8R1AbAnaU0=; b=ONIRkmAkZzniMv LC1dNeFKQGdeU/40fR5iD/idIvrFXDJRUOBig4XNCRD23zJlSYIibu/nJ2yR/BGWx7X+okcapiPWZ 1q6Z08MngPnsOLk/+c4J14rUOcOjXuXqV9gTbRfa2ws5r6ggMW07Z+xUPc8m+bsqbSliHj0oNhi6v HBN7yw34itOXqxnIGrZFtbsP5dSR9l8X8Qck5kX1v3Sjts24TNHIxzJKCookNaZQkQfdHomgvXykS DmKp6zMDROOGCP0YT6KF+lV1tyInYN/kZVc9TSfNAoCR5rwtyD9Ayr8APaQSuWBiawkAem24KCBeM P9aCbIkkK+maSndmIFPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFA5Y-00000009Kun-30m6; Thu, 06 Jun 2024 10:11:20 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFA5V-00000009KtW-2TTl; Thu, 06 Jun 2024 10:11:18 +0000 Received: from i53875b65.versanet.de ([83.135.91.101] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sFA5U-0007s0-9t; Thu, 06 Jun 2024 12:11:16 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Linus Walleij , Huang-Huang Bao Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Huang-Huang Bao Subject: Re: [PATCH 2/3] pinctrl: rockchip: use dedicated pinctrl type for RK3328 Date: Thu, 06 Jun 2024 12:11:15 +0200 Message-ID: <4429508.MSiuQNM8U4@diego> In-Reply-To: <2182307.KiezcSG77Q@diego> References: <20240606060435.765716-1-i@eh5.me> <20240606060435.765716-3-i@mail.eh5.me> <2182307.KiezcSG77Q@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240606_031117_645800_9E484CE9 X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Donnerstag, 6. Juni 2024, 11:43:56 CEST schrieb Heiko St=FCbner: > Am Donnerstag, 6. Juni 2024, 08:04:34 CEST schrieb Huang-Huang Bao: > > rk3328_pin_ctrl uses type of RK3288 which has a hack in > > rockchip_pinctrl_suspend and rockchip_pinctrl_resume to restore GPIO6-C6 > > at assume, the hack is not applicable to RK3328 as GPIO6 is not even > > exist in it. So use a dedicated pinctrl type to skip this hack. > > = > > Signed-off-by: Huang-Huang Bao > = > Reviewed-by: Heiko Stuebner I think this actually also warrants a Fixes-tag, because as you said, the suspend handling for the rk3288 will change GRF registers it should not touch on the rk3328. Fixes: 3818e4a7678e ("pinctrl: rockchip: Add rk3328 pinctrl support") _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel