From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30DF9C5475B for ; Fri, 8 Mar 2024 11:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zDbzbCEMyqxH9f7IPiA3vEHkMiK2c1Rau7LNQf1+z20=; b=WMfodNFAgQM9m4 GvUB6GH6wELAIjgnhmD/naSLeFfgLxoJ+yMOiNfv4kzC1VJNLF3NuskKqz/TCMgR9+foTWXLOIPAT loWiwQwKGCNT346bjADA0ZdGVo4x8RH008XcKLcKAgLrjlMwH8lUlIDrmJz5fXheBTcmJB+G4Rboq mf1zywGhxWG2bCILObzPPR5O7XpB1EYI9tuH+jhLuJiYpgXsyd9iAVwhl7LA2vY1UF4nhTHwnhjeT 9+IYp34DH0JNA6/4QOyVIaHIhA4yzq/JQYLhL4U58d47o7A8kk9grVj95E/APTVqxRdMtqGKBxe+j V2RCT72WDIH17ktruIUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riYLI-00000008xqh-3Saw; Fri, 08 Mar 2024 11:24:48 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riYLF-00000008xpU-2j1Q for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 11:24:47 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a452877ddcaso257640166b.3 for ; Fri, 08 Mar 2024 03:24:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1709897083; x=1710501883; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oAeQj9nX/mCE4SAm/UXcMQjsHuY2Atxy9Nfnai0Y6DQ=; b=GoECksj0twmDfyzf9nNhr8/w8LLfd9HXurybn7X2gVSDfxOPT4etmwcZ4hpOTbAJm4 +anxL1Mxh/d1W6FLOujek8vbPuiybqKwujXKSVn11gya/WxvRgV1PLIOM3eKshquZ3sW MqMgcC9cPzweOWd/gLjNdDbNh3ST1xh9v8r6OSuQpz6wlL5/hS/H7Sv+JxD7FEy3U76b J2heQy4UAMk+YMRVkPNtMttLXqaITzNhDNZ9TCkBJEf/HR7SZ1aogRSLoPzllGA4HYHl JnxR4r+l+BRX0x2EXvP/lss69Q3m9gAn6DD5x3HplgbTm88hAIWYpxxwhK2TGcE3gDUm Mh4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709897083; x=1710501883; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oAeQj9nX/mCE4SAm/UXcMQjsHuY2Atxy9Nfnai0Y6DQ=; b=IZwMfDVHTjbqCfbw0ZWm2Tz+FGMIwrpj7ct1kpBSviYTIRnFujEsjvgKG9kxdpW0Kn ZOovOmGNd3F3ARm65v557T5V/MuIPIpyur48Ag5uZVFHzuaQ8TGNPKwHndUiAX83kDcY imvPZSjCZnY5xh5OOaOLP7eg/UU8brLVvgS6bNAi/IRONgDU1NOgqbykbf4R4n/vKrNh 6sDGTLVR6Nqp4Qe9mRFpCTV+x8ZU3gEozRCAvbTtbPClqXHQVgkc1ufYp60gg9iN8YNq tXcJ27c7KMhY7OVOOq1wSWCrRyAQbiNmqu1YJxK0GAMuEhQRfw7VXi05TgAJi8dZouYo 4UMA== X-Forwarded-Encrypted: i=1; AJvYcCVPlGaMHcaXQ1kVfQ758skw6iVf+TfjSi1f2LpHGb+ht619A0TdHGM8b0LyNOOJXjOD/kAeY1739IilhNEcYoVKAUMaI/7/hoUuwEjvhJQHcHFJ4Ag= X-Gm-Message-State: AOJu0YyWigWpswD1MggSVQi/qI/0dX7UaCKtR0jG5b+oH/XpzrArDFli /3CTRthN0ORXF/VH/Eps6bl3TRxCOnxGCsrLKUS13Ot3VCEiM7WEwLw0dD7GxNo= X-Google-Smtp-Source: AGHT+IEvYNFKidP5dUJN9E5a69C7gwcEqHa2YT+x32x0AhHetixroqJyaFVB68JQgbsLBfpod0hk2Q== X-Received: by 2002:a17:907:1189:b0:a43:f587:d427 with SMTP id uz9-20020a170907118900b00a43f587d427mr13911312ejb.34.1709897082984; Fri, 08 Mar 2024 03:24:42 -0800 (PST) Received: from [192.168.1.70] ([84.102.31.43]) by smtp.gmail.com with ESMTPSA id k23-20020a1709063e1700b00a42f6d48c72sm9307224eji.145.2024.03.08.03.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 03:24:42 -0800 (PST) Message-ID: <44295772-4635-42c2-b7b5-cdc37505715e@baylibre.com> Date: Fri, 8 Mar 2024 12:24:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/11] mfd: tps6594: Add register definitions for TI TPS65224 PMIC Content-Language: en-US To: Bhargav Raviprakash , linux-kernel@vger.kernel.org Cc: m.nirmaladevi@ltts.com, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com, kristo@kernel.org, eblanc@baylibre.com References: <20240308103455.242705-1-bhargav.r@ltts.com> <20240308103455.242705-2-bhargav.r@ltts.com> From: Julien Panis In-Reply-To: <20240308103455.242705-2-bhargav.r@ltts.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_032445_921879_37F8891B X-CRM114-Status: GOOD ( 11.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/8/24 11:34, Bhargav Raviprakash wrote: > From: Nirmala Devi Mal Nadar > > Extend TPS6594 PMIC register and field definitions to support TPS65224 > power management IC. > > TPS65224 is software compatible to TPS6594 and can re-use many of the > same definitions, new definitions are added to support additional > controls available on TPS65224. > > Signed-off-by: Nirmala Devi Mal Nadar > Signed-off-by: Bhargav Raviprakash > --- > include/linux/mfd/tps6594.h | 354 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 342 insertions(+), 12 deletions(-) [...] > +/* IRQs */ > +enum tps65224_irqs { > + /* INT_BUCK register */ > + TPS65224_IRQ_BUCK1_UVOV, > + TPS65224_IRQ_BUCK2_UVOV, > + TPS65224_IRQ_BUCK3_UVOV, > + TPS65224_IRQ_BUCK4_UVOV, > + /* INT_LDO_VMON register */ > + TPS65224_IRQ_LDO1_UVOV, > + TPS65224_IRQ_LDO2_UVOV, > + TPS65224_IRQ_LDO3_UVOV, > + TPS65224_IRQ_VCCA_UVOV, > + TPS65224_IRQ_VMON1_UVOV, > + TPS65224_IRQ_VMON2_UVOV, > + /* INT_GPIO register */ > + TPS65224_IRQ_GPIO1, > + TPS65224_IRQ_GPIO2, > + TPS65224_IRQ_GPIO3, > + TPS65224_IRQ_GPIO4, > + TPS65224_IRQ_GPIO5, > + TPS65224_IRQ_GPIO6, > + /* INT_STARTUP register */ > + TPS65224_IRQ_VSENSE, > + TPS65224_IRQ_ENABLE, > + TPS65224_IRQ_PB_SHORT, > + TPS65224_IRQ_FSD, > + TPS65224_IRQ_SOFT_REBOOT, > + /* INT_MISC register */ > + TPS65224_IRQ_BIST_PASS, > + TPS65224_IRQ_EXT_CLK, > + TPS65224_IRQ_REG_UNLOCK, > + TPS65224_IRQ_TWARN, > + TPS65224_IRQ_PB_LONG, > + TPS65224_IRQ_PB_FALL, > + TPS65224_IRQ_PB_RISE, > + TPS65224_IRQ_ADC_CONV_READY, > + /* INT_MODERATE_ERR register */ > + TPS65224_IRQ_TSD_ORD, > + TPS65224_IRQ_BIST_FAIL, > + TPS65224_IRQ_REG_CRC_ERR, > + TPS65224_IRQ_RECOV_CNT, > + /* INT_SEVERE_ERR register */ > + TPS65224_IRQ_TSD_IMM, > + TPS65224_IRQ_VCCA_OVP, > + TPS65224_IRQ_PFSM_ERR, > + TPS65224_IRQ_BG_XMON, > + /* INT_FSM_ERR register */ > + TPS65224_IRQ_IMM_SHUTDOWN, > + TPS65224_IRQ_ORD_SHUTDOWN, > + TPS65224_IRQ_MCU_PWR_ERR, > + TPS65224_IRQ_SOC_PWR_ERR, > + TPS65224_IRQ_COMM_ERR, > + TPS65224_IRQ_I2C2_ERR, > + /* INT_ESM register */ > + TPS65224_IRQ_ESM_MCU_PIN, > + TPS65224_IRQ_ESM_MCU_FAIL, > + TPS65224_IRQ_ESM_MCU_RST, You should remove the 3 lines above for ESM_MCU, since there is none linux driver for ESM_MCU. > +}; > + > +#define TPS65224_IRQ_NAME_BUCK1_UVOV "buck1_uvov" > +#define TPS65224_IRQ_NAME_BUCK2_UVOV "buck2_uvov" > +#define TPS65224_IRQ_NAME_BUCK3_UVOV "buck3_uvov" > +#define TPS65224_IRQ_NAME_BUCK4_UVOV "buck4_uvov" > +#define TPS65224_IRQ_NAME_LDO1_UVOV "ldo1_uvov" > +#define TPS65224_IRQ_NAME_LDO2_UVOV "ldo2_uvov" > +#define TPS65224_IRQ_NAME_LDO3_UVOV "ldo3_uvov" > +#define TPS65224_IRQ_NAME_VCCA_UVOV "vcca_uvov" > +#define TPS65224_IRQ_NAME_VMON1_UVOV "vmon1_uvov" > +#define TPS65224_IRQ_NAME_VMON2_UVOV "vmon2_uvov" > +#define TPS65224_IRQ_NAME_GPIO1 "gpio1" > +#define TPS65224_IRQ_NAME_GPIO2 "gpio2" > +#define TPS65224_IRQ_NAME_GPIO3 "gpio3" > +#define TPS65224_IRQ_NAME_GPIO4 "gpio4" > +#define TPS65224_IRQ_NAME_GPIO5 "gpio5" > +#define TPS65224_IRQ_NAME_GPIO6 "gpio6" > +#define TPS65224_IRQ_NAME_VSENSE "vsense" > +#define TPS65224_IRQ_NAME_ENABLE "enable" > +#define TPS65224_IRQ_NAME_PB_SHORT "pb_short" > +#define TPS65224_IRQ_NAME_FSD "fsd" > +#define TPS65224_IRQ_NAME_SOFT_REBOOT "soft_reboot" > +#define TPS65224_IRQ_NAME_BIST_PASS "bist_pass" > +#define TPS65224_IRQ_NAME_EXT_CLK "ext_clk" > +#define TPS65224_IRQ_NAME_REG_UNLOCK "reg_unlock" > +#define TPS65224_IRQ_NAME_TWARN "twarn" > +#define TPS65224_IRQ_NAME_PB_LONG "pb_long" > +#define TPS65224_IRQ_NAME_PB_FALL "pb_fall" > +#define TPS65224_IRQ_NAME_PB_RISE "pb_rise" > +#define TPS65224_IRQ_NAME_ADC_CONV_READY "adc_conv_ready" > +#define TPS65224_IRQ_NAME_TSD_ORD "tsd_ord" > +#define TPS65224_IRQ_NAME_BIST_FAIL "bist_fail" > +#define TPS65224_IRQ_NAME_REG_CRC_ERR "reg_crc_err" > +#define TPS65224_IRQ_NAME_RECOV_CNT "recov_cnt" > +#define TPS65224_IRQ_NAME_TSD_IMM "tsd_imm" > +#define TPS65224_IRQ_NAME_VCCA_OVP "vcca_ovp" > +#define TPS65224_IRQ_NAME_PFSM_ERR "pfsm_err" > +#define TPS65224_IRQ_NAME_BG_XMON "bg_xmon" > +#define TPS65224_IRQ_NAME_IMM_SHUTDOWN "imm_shutdown" > +#define TPS65224_IRQ_NAME_ORD_SHUTDOWN "ord_shutdown" > +#define TPS65224_IRQ_NAME_MCU_PWR_ERR "mcu_pwr_err" > +#define TPS65224_IRQ_NAME_SOC_PWR_ERR "soc_pwr_err" > +#define TPS65224_IRQ_NAME_COMM_ERR "comm_err" > +#define TPS65224_IRQ_NAME_I2C2_ERR "i2c2_err" > +#define TPS65224_IRQ_NAME_ESM_MCU_PIN "esm_mcu_pin" > +#define TPS65224_IRQ_NAME_ESM_MCU_FAIL "esm_mcu_fail" > +#define TPS65224_IRQ_NAME_ESM_MCU_RST "esm_mcu_rst" You should remove the 3 lines above for ESM_MCU. Julien _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel