From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B776C4332F for ; Thu, 13 Oct 2022 05:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WoRkFZxZ1EeCoVA1hYXSb+EfNCvLEOEpx2w0WBRH9nM=; b=PECnvYP7acG5zP yBP8UGuuB35C/BUxv+D9+Fypf+UDqNoqax9bcPA4pUvDLi3XdSjLbsVuiviUhj7HgUwFHqFXkftKK ZoF36WCIKnsE/aPSzPCGMrKR8GQ4nVFF7VUs5+t8bf6v7uAU3DpDE2wM2uqsq7ugqkz2CaThnz44f b0LqorjZhu8ZJw3VtnIa2MOEK7iS5R8ADNUbnUlVhz6c8xB1+9l2NhTjLvGchFx2e1UtlwxjD+Vr6 FzpoW95bgOe7r7jb3JXK3c1Lj+i5sYf4Fn5xPwxLVOGkuGjFohUrzxPbpnMvVI69vEHxUFLcvq/jI dDGZSaYInOhw63pb+IHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oirBc-00AlHR-BH; Thu, 13 Oct 2022 05:55:16 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oirBZ-00AlGb-E1 for linux-arm-kernel@lists.infradead.org; Thu, 13 Oct 2022 05:55:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1665640513; x=1697176513; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5CiRPgIDP7uz7PRFVbd56oiuqj4J9JjKXOcViKKuO5w=; b=XC7csBWmL8UYKVMa62bOvNif7F7X8qREadA8NkeDYilqz46wZIs2sDz3 zOGiRI7tByXolDpA0lNJKbxsanOXVrdlo2FRn6yiGdVstB44RDP8iuTFi aLyItkuRCfg+Y2Lf7Kx5Rq5CSRk6JOfNWpKbo7Ep0R+GjyQu7LVLcOKIa DqhSzmPGQNP0Uy2ovh1rU5j6JPd68AdoVdz2bF+ycy/ne9RnqyYDNGPjS GMvUmyIyiXewdemiPk180oABtHiBD7pHPLDe7MuOE1Jseh4WDTmCGAOkO WqKDj1oNErSr8KfWg3jEo+65LoNNQx715cKCD3U4mwQjAkcL7s+t10O4p A==; X-IronPort-AV: E=Sophos;i="5.95,180,1661810400"; d="scan'208";a="26721450" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 13 Oct 2022 07:55:09 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 13 Oct 2022 07:55:09 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 13 Oct 2022 07:55:09 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1665640509; x=1697176509; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5CiRPgIDP7uz7PRFVbd56oiuqj4J9JjKXOcViKKuO5w=; b=mkk0PTGTiZRaVs55bjkKQvaaIsfU5b+HOu5BFwSALAKOB2HApBA6H2qY Jxc1HvbUXIzLZIVP4HwVq5s+QyMwD/vPdyShaSg8wc7JxwzTdsmtEJRsi ndcvQcHCjLPz7aZyRC+YGiOnWukTEBDOIVgPikfbUv5J8ynL+5B6wzOUY 3NDZneOmiqWA54FHHiaoGcAoXheljeDZTexIfMDkwMIyRDSaFl3LQgcHd E4BQLyiBZeyxtED8zJ3gdQur+eUI9xGe4OADfEc10BnLTFQYl6JadIO4m 8NODq0zbEpiVKT6LOC1o2ip63KZ8r7MkTRNoOdWlSiBTDhl81nrBMzxGv w==; X-IronPort-AV: E=Sophos;i="5.95,180,1661810400"; d="scan'208";a="26721449" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 13 Oct 2022 07:55:08 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id BB1AD280056; Thu, 13 Oct 2022 07:55:08 +0200 (CEST) From: Alexander Stein To: Fabio Estevam , Damien Le Moal Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] ata: ahci-imx: Fix MODULE_ALIAS Date: Thu, 13 Oct 2022 07:55:06 +0200 Message-ID: <4442509.LvFx2qVVIh@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20221012131105.725258-1-alexander.stein@ew.tq-group.com> <5877338.lOV4Wx5bFT@steina-w> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_225513_903029_DDB623D0 X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Damien, Am Donnerstag, 13. Oktober 2022, 06:20:16 CEST schrieb Damien Le Moal: > On 10/12/22 22:30, Alexander Stein wrote: > > Hello Fabio, > > > > Am Mittwoch, 12. Oktober 2022, 15:23:04 CEST schrieb Fabio Estevam: > >> Hi Alexander, > >> > >> On Wed, Oct 12, 2022 at 10:11 AM Alexander Stein > >> > >> wrote: > >>> 'ahci:' is an invalid prefix, preventing the module from autoloading. > >>> Fix this by using the 'platform:' prefix and DRV_NAME. > >> > >> What about adding a Fixes tag? > >> > >> Reviewed-by: Fabio Estevam > > > > Thanks. A Fixes tag seems reasonable, but I have to admit I don't know at > > which point auto loading stopped working (if it did at all). > > Given that the alias was wrong in the first place when added for a > platform driver, this I think should be a fix for: > > 9e54eae23bc9 ("ahci_imx: add ahci sata support on imx platforms") I was hesitating tagging the very first commit, not knowing if it did work at that time. But it seems reasonable. > I can add the Fixes tag when applying. Thanks! Best regards, Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel