From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B654C43334 for ; Thu, 2 Jun 2022 06:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WouqMJkVtOd0/82Zv2aAdFTTJPVkCJY7jQbKDo2bTPI=; b=J+Kj+CaciupCS0 t6pIeizCuaC57+NMiuihITrU0vMRVZbp6Kbx9ti65cXW/kqo+raPIu1VvNAt+P9q3W1LKJ3TKJcQ4 k2JQ4Ao6pSGIXo3E+Tlvm3qr0I6xzJdrlpZ8MkHegBM8RRJNsGpuNbK1f90TylZX9oc2T6ci70ygp NbLSGWbnX+z8VD9qnQv5+WTPHC1h9eKsDA1xCbI63zI9UevXxTBeRBF8GO/TEwAbfRj8A5c4gnPKO 2Uwy7uCUBd7x0uPZ74brwLWVPF7BTBv1w/Bf9LXoMlCCD+2VUBp2SZjpbOyXutaNcHy6txkJY32Ls j9BVRHG7yvwLRE3WOw5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nweXO-001n7T-40; Thu, 02 Jun 2022 06:42:30 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nweXK-001n4r-9I for linux-arm-kernel@lists.infradead.org; Thu, 02 Jun 2022 06:42:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654152141; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XvZ5OMbEcwo0Xa7CqN8M7maUXV2iBoekFoadMgX1RCs=; b=OLrVUFDGZ2e6533aIFOcMjtMThdKaN5JznerLACkFjQOI/Kb5c2JfNpljVHbZqofcbYIXQ iCI9ZhhgGIMZkuv0gf5pJ9G5NJvVk/7OzknUlKbMipby5PoxEXjXvdo7uR5v4G/26aK5DH 2QYeV3ov7VfHrm/gc5VmW0xu0Trn348= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-414-J5AQOQPmNeCLDk1obVMTng-1; Thu, 02 Jun 2022 02:42:18 -0400 X-MC-Unique: J5AQOQPmNeCLDk1obVMTng-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A61AA8032E5; Thu, 2 Jun 2022 06:42:17 +0000 (UTC) Received: from [10.72.12.91] (ovpn-12-91.pek2.redhat.com [10.72.12.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 293D8492C3B; Thu, 2 Jun 2022 06:42:11 +0000 (UTC) Subject: Re: [PATCH v3 08/16] arm64: topology: Remove redundant setting of llc_id in CPU topology To: Sudeep Holla , linux-kernel@vger.kernel.org Cc: Atish Patra , Atish Patra , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Qing Wang , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Rob Herring References: <20220525081416.3306043-1-sudeep.holla@arm.com> <20220525081416.3306043-2-sudeep.holla@arm.com> <20220525081416.3306043-3-sudeep.holla@arm.com> <20220525081416.3306043-4-sudeep.holla@arm.com> <20220525081416.3306043-5-sudeep.holla@arm.com> <20220525081416.3306043-6-sudeep.holla@arm.com> <20220525081416.3306043-7-sudeep.holla@arm.com> <20220525081416.3306043-8-sudeep.holla@arm.com> <20220525081416.3306043-9-sudeep.holla@arm.com> From: Gavin Shan Message-ID: <444a1540-cf3d-7144-4ebc-d6f4587272a5@redhat.com> Date: Thu, 2 Jun 2022 14:42:08 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20220525081416.3306043-9-sudeep.holla@arm.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_234226_425755_2BFEADA1 X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Gavin Shan Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/25/22 4:14 PM, Sudeep Holla wrote: > Since the cacheinfo LLC information is used directly in arch_topology, > there is no need to parse and fetch the LLC ID information only for > ACPI systems. > > Just drop the redundant parsing and setting of llc_id in CPU topology > from ACPI PPTT. > > Signed-off-by: Sudeep Holla > --- > arch/arm64/kernel/topology.c | 14 -------------- > 1 file changed, 14 deletions(-) > Reviewed-by: Gavin Shan > diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c > index 9ab78ad826e2..869ffc4d4484 100644 > --- a/arch/arm64/kernel/topology.c > +++ b/arch/arm64/kernel/topology.c > @@ -89,8 +89,6 @@ int __init parse_acpi_topology(void) > return 0; > > for_each_possible_cpu(cpu) { > - int i, cache_id; > - > topology_id = find_acpi_cpu_topology(cpu, 0); > if (topology_id < 0) > return topology_id; > @@ -107,18 +105,6 @@ int __init parse_acpi_topology(void) > cpu_topology[cpu].cluster_id = topology_id; > topology_id = find_acpi_cpu_topology_package(cpu); > cpu_topology[cpu].package_id = topology_id; > - > - i = acpi_find_last_cache_level(cpu); > - > - if (i > 0) { > - /* > - * this is the only part of cpu_topology that has > - * a direct relationship with the cache topology > - */ > - cache_id = find_acpi_cpu_cache_topology(cpu, i); > - if (cache_id > 0) > - cpu_topology[cpu].llc_id = cache_id; > - } > } > > return 0; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel