From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0CA5C433F5 for ; Thu, 10 Mar 2022 14:51:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qRSsa1OFj9+FJKNx+s/ly0knXVj7QoHIRHQhCcvAPns=; b=3ESUeS9tOGQ8FL qG/gpRcpuRnRnTafkCmVEDVHE5FS32o5QQp0IJBpKmrPb7l/R82Cj02H/t7oKlihm6c58xxxqMRRV fWbVFY09QyNCnQLtHcT1o3qH0bWj223tqXgLwixYzRjcdNoBp4UPjcknFAxGHi/bbtPtFKj3CIuO4 4aHa0ySVl+Upa//me5NxouHo3UHgahKKZaYWy9UjLJfK9oL93zR/sHENNkxXpY1YEx+V6cFFupTTU 527hiohV5byeaZ+NjkO8UE1jitMtoKT4/a12M4JS2qM4h5sFdMSS0vNhsFW3FjURE6SQBeca1T5JR Q3dWB94YPrcBZtlGDvHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSK7h-00DD82-8C; Thu, 10 Mar 2022 14:50:37 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSK7c-00DD5r-H2; Thu, 10 Mar 2022 14:50:33 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSK7V-0004bE-W9; Thu, 10 Mar 2022 15:50:26 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Colin Ian King , Nick Desaulniers Cc: Sandy Huang , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, knaerzche@gmail.com Subject: Re: [PATCH] drm/rockchip: remove redundant assignment to pointer connector Date: Thu, 10 Mar 2022 15:50:25 +0100 Message-ID: <4453075.DPozGzHrQt@diego> In-Reply-To: References: <20220307181704.149076-1-colin.i.king@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_065032_604666_0D71F6A9 X-CRM114-Status: GOOD ( 23.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, looks like I wasn't in the original recipient list, so only got Nick's answer. Am Mittwoch, 9. M=E4rz 2022, 00:10:31 CET schrieb Nick Desaulniers: > On Mon, Mar 7, 2022 at 10:17 AM Colin Ian King w= rote: > > > > The pointer connector is being assigned a value that is never read, > > it is being re-assigned in the following statement. The assignment > > is redundant and can be removed. > > > > Cleans up clang scan build warning: > > drivers/gpu/drm/rockchip/rockchip_rgb.c:153:2: warning: Value stored > > to 'connector' is never read [deadcode.DeadStores] > = > + Author & reviewer of: > Fixes: 2e87bf389e13 ("drm/rockchip: add DRM_BRIDGE_ATTACH_NO_CONNECTOR > flag to drm_bridge_attach") > = > > > > Signed-off-by: Colin Ian King > > --- > > drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/= rockchip/rockchip_rgb.c > > index 2494b079489d..92a727931a49 100644 > > --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c > > @@ -150,7 +150,6 @@ struct rockchip_rgb *rockchip_rgb_init(struct devic= e *dev, > > if (ret) > > goto err_free_encoder; > > > > - connector =3D &rgb->connector; > > connector =3D drm_bridge_connector_init(rgb->drm_dev, encoder); I don't think this will work as expected. Yes, the whole thing looks a bit broken right now, but the connector field in the rockchip_rgb struct still exists and rockchip_rgb_fini also still uses it when calling drm_connector_cleanup. Same issue seems to exist in in rockchip_lvds.c with drm_connector_cleanup it seems. I guess drm_bridge_connector_destroy() is responsible for the cleanup so the drm_connector_cleanup call both in rockchip_rgb and rockchip_lvds as well as the local connector elements can go away as well? Heiko > > if (IS_ERR(connector)) { > > DRM_DEV_ERROR(drm_dev->dev, > > -- > > 2.35.1 > > > > > = > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel