From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAA2AC4332F for ; Wed, 12 Oct 2022 22:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SCPiDDHY3hRiz2cbPAW+n1q7vRKgGiK3aoiCT2gQZS0=; b=ABGC9Xa/QEX025 ew7bJ2dGX9uW/9L30jp8+A+PasZ+N9yKljx8tbTqads+B+rBlKbC87Gc5oS6eX3+sLk3DPO3xOi5A 9jQKNMpnXsldeDwcbqLw5iwOc62jbqwtPZSf2RB0EBxhsKHOKyxmKGj32e59FGdaiYQJeHIzKl5at eOWbvg4lIBN2Db8Ljb8fHZ/Y3GL5OpdYXvptrPawbc0THfnvTzWvhbt7IYPoahE+blmuRwbAE3hmB HyR7Dc9Te/tynSqg6L7r001yUGExLwZ94LHjzw6ltst3d++6MtRQQZ7PtklCT4WOVKOxXdvHAROoB ivI1qdRTBVSumnOyvARg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oijnN-009ULe-Md; Wed, 12 Oct 2022 22:01:45 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oijnL-009UKv-1l for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 22:01:44 +0000 Received: by mail-ej1-x630.google.com with SMTP id sc25so58401ejc.12 for ; Wed, 12 Oct 2022 15:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c297Mx5GJtCyOHa14C0QACA80doQwDidPNZnmUy04NM=; b=FHXLEeY6zqLifb7KS6WgUhITH3TMoRVQQYGRO6ciD2t98IynD0Zd+YYR1Jdpy4Pgsr BxqyfV75rtmUO4CmwSSlh9GI3uDS2VELJcqwx3SQT3QoJ+CCQVwh1asY9I+ReaB8oU4G KXOlZtG3lTSByyou0tazsMQecpZFsMGCC1iU0c9PpXMM5xrImM7pST5y3DrtpW58cdP8 2nvv5cza+Lthz4Myh1Z2RItqW3Hy98aWrny61hIvTEWVCXWT1tnCCbMNSVovyYR/ImYc aCaR6bNqmjieHxQllby61SoRk7JxgiM5t/GxG+IKddsU5rLRdDh9dc2DQCBlx4TlTarY gE4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c297Mx5GJtCyOHa14C0QACA80doQwDidPNZnmUy04NM=; b=trxPE0/4GK0hd8VI6rCapvYF7/IS2o4YwQBUduHFl9EdXhwLyD/2NLn1oPM7JVKd1a YklgcRuL2UAHjrqnSnz8L4zyYguns/tZVo9xy6b8U4VZCmupcLYV5Go8/86KDvPYQ/W6 /W4qfJwkh/0Z1mTTwoznQtrZRJtOrVcTsRVW1BpZu8fJunsHRl22DLuHZ37ZlaisGzIb 68b1oyRUB+AjSSNwbb3IrucNzE5VaABfDaS+toO4FwefNhH9lOEzYVE+j4Ba0dAGkjk6 5YXvIrWDJS9pMjllI4Em3AhD/28kJeWNRsampPP2zPuCUKDwwDA6ZL3GUyWIuS2g+zqt /rHQ== X-Gm-Message-State: ACrzQf0oZTGQJ+OjKsvLdpyrm64SnMfOfw+s8gFuWBqmIIVdT0Z4thaN 7QFagNrdm+4jWqdUWEzguQd7Z+7xX/UiZwDV X-Google-Smtp-Source: AMsMyM4UR/dRvb2fTJVEbwytBHZZyA1se8KFEVUwu+TIl1ALRT3A19l1UGFCZ/jWtMTtNcZWUZorIw== X-Received: by 2002:a17:907:2d06:b0:78d:50db:130e with SMTP id gs6-20020a1709072d0600b0078d50db130emr23152667ejc.371.1665612100206; Wed, 12 Oct 2022 15:01:40 -0700 (PDT) Received: from kista.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id u17-20020a1709061db100b0073c0b87ba34sm1853442ejh.198.2022.10.12.15.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 15:01:39 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland Cc: Samuel Holland , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v3 1/2] ARM: dts: axp803/axp81x: Drop GPIO LDO pinctrl nodes Date: Thu, 13 Oct 2022 00:01:38 +0200 Message-ID: <4454781.cEBGB3zze1@kista> In-Reply-To: <20220916042751.47906-2-samuel@sholland.org> References: <20220916042751.47906-1-samuel@sholland.org> <20220916042751.47906-2-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_150143_142545_FA58A6EB X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Samuel, Dne petek, 16. september 2022 ob 06:27:50 CEST je Samuel Holland napisal(a): > The "ldo-io0" and "ldo-io1" regulators are enabled/disabled by toggling > the pinmux between two functions. This happens in the regulator driver. > Setting the pinmux to "ldo" in the DT is inappropriate because it would > enable the regulator before the driver has a chance to set the correct > initial voltage. > > Signed-off-by: Samuel Holland Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > > Changes in v3: > - Added patch to remove existing "ldo" pinctrl nodes > > arch/arm/boot/dts/axp81x.dtsi | 14 -------------- > arch/arm64/boot/dts/allwinner/axp803.dtsi | 10 ---------- > 2 files changed, 24 deletions(-) > > diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi > index b93387b0c1c3..ebaf1c3ce8db 100644 > --- a/arch/arm/boot/dts/axp81x.dtsi > +++ b/arch/arm/boot/dts/axp81x.dtsi > @@ -62,16 +62,6 @@ axp_gpio: gpio { > compatible = "x-powers,axp813-gpio"; > gpio-controller; > #gpio-cells = <2>; > - > - gpio0_ldo: gpio0-ldo-pin { > - pins = "GPIO0"; > - function = "ldo"; > - }; > - > - gpio1_ldo: gpio1-ldo-pin { > - pins = "GPIO1"; > - function = "ldo"; > - }; > }; > > battery_power_supply: battery-power { > @@ -144,15 +134,11 @@ reg_fldo3: fldo3 { > }; > > reg_ldo_io0: ldo-io0 { > - pinctrl-names = "default"; > - pinctrl-0 = <&gpio0_ldo>; > /* Disable by default to avoid conflicts with GPIO */ > status = "disabled"; > }; > > reg_ldo_io1: ldo-io1 { > - pinctrl-names = "default"; > - pinctrl-0 = <&gpio1_ldo>; > /* Disable by default to avoid conflicts with GPIO */ > status = "disabled"; > }; > diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi > b/arch/arm64/boot/dts/allwinner/axp803.dtsi index > 578ef368e2b4..a6b4b87f185d 100644 > --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi > +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi > @@ -25,16 +25,6 @@ axp_gpio: gpio { > compatible = "x-powers,axp803-gpio", "x-powers,axp813- gpio"; > gpio-controller; > #gpio-cells = <2>; > - > - gpio0_ldo: gpio0-ldo-pin { > - pins = "GPIO0"; > - function = "ldo"; > - }; > - > - gpio1_ldo: gpio1-ldo-pin { > - pins = "GPIO1"; > - function = "ldo"; > - }; > }; > > battery_power_supply: battery-power { > -- > 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel