From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D394AC433EF for ; Thu, 31 Mar 2022 08:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gNxweU6c+aydFzecpRXrA+APuhV5Oem3VsLzaRzIsns=; b=ZgM+tflcqo3I/Z CrE6qvDHvo3Z8dw/BUwE/ibip0CWLSNlxAftSjjamhdStcCtZzOu/bICnJw/Ift41ORINwH6V9PbL PSZIHxSFBleafF76PBUqMNod8lU49yr5HXaalTs/UITL43p9T4BC6l3yooaighwket0UZ9QUVAE+l vN2NfQx/SC8H3PC584pXviEgihxKNpEhlrkzZ69YLw0NbZGaYMldmA8FFmyGazqcO8UWtI7Bgl9WK XA1+34wknAJ2yTbdFKoQShGT3zeM+pwrUVGFp857q/6oTRk2BXySokKtgACNxcNJu9rzmT2ZJ9PVF 5sq9dQUv7XZnK0NZuZ5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZqWL-001MyW-Tx; Thu, 31 Mar 2022 08:51:10 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZqWE-001MxO-FT for linux-arm-kernel@lists.infradead.org; Thu, 31 Mar 2022 08:51:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648716661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wa4p/wO+PmXujUL5WGPRn9DNetCFbX+Ev3ZZgYBJonU=; b=aH/uZgDvPTdd+9H3/Bq+EU2ZLSHHfBpPAg7AtoUIWm2ky7bMM2OmxsC4S1uCUK0AC90AOB HazfPeoG0DM6eEKIM/n228RYq/g1M342jQ695YX03Zgp9z7o2g00OwPuzQdtQjX7942cK8 93huzO/AUeJM30rDMaHS8qOJhW22oQg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-448-KMzt1aEJNS-dNCg98QeDqQ-1; Thu, 31 Mar 2022 04:51:00 -0400 X-MC-Unique: KMzt1aEJNS-dNCg98QeDqQ-1 Received: by mail-wm1-f72.google.com with SMTP id t2-20020a7bc3c2000000b003528fe59cb9so905055wmj.5 for ; Thu, 31 Mar 2022 01:50:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=wa4p/wO+PmXujUL5WGPRn9DNetCFbX+Ev3ZZgYBJonU=; b=X5mN7dSlbd8vKwLNjc0U5euDUusVWKN4G1xBqzs0LBpO7ISAZdNiEXLFajHjPzsd8v BqMK8NVPQugGyUPVJsJOMwBskmlRYnvTBEMGtMw8bRWAyDdu89Ds2Qt7FHDnq9bDrGp9 NQGSYEbbq0EmD5RblBQU/wU0CVgXOQMhOQngVQSTt9do5IH/3MV96G2IDmepfPBSo1Vn b1fvSBVm4N1UfrAcdnftQNjiq3STWEWEV8g8ujXTwYXRTPN9Rb27UnhjumyRSYIpXRgK GX/Le1DR1yTQoj5/BwZhnmzFnxvSa/vbAIY7dd7RZuUAgj2y6LlY3xTGx4gVx6n/uMzI UX/g== X-Gm-Message-State: AOAM5316gwm46e464a7ZxeMU8XeKBuQeiDSgmDeocIQom16DEHywSEZH GeGNxCoJppM0kIFkgZFxZomlBEgLUfgg8wboxdJq3nlu/fZ6/URRr4ClfzZzuSNN1l9NAnJuvpW 464B4kYjsqlEI3/7zXxMMpQnDgi6Ah35kwR0= X-Received: by 2002:a05:600c:4241:b0:38c:ec66:7c8f with SMTP id r1-20020a05600c424100b0038cec667c8fmr3779475wmm.179.1648716658875; Thu, 31 Mar 2022 01:50:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydHgZaeT4SyBikwI+ArVPjRxw0uDniD5ZVMGFpCcHvAsXuy7PE8lVHxzWUOPwpkP/X97R8KA== X-Received: by 2002:a05:600c:4241:b0:38c:ec66:7c8f with SMTP id r1-20020a05600c424100b0038cec667c8fmr3779451wmm.179.1648716658625; Thu, 31 Mar 2022 01:50:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:ac00:381c:2e8b:3b48:488e? (p200300cbc707ac00381c2e8b3b48488e.dip0.t-ipconnect.de. [2003:cb:c707:ac00:381c:2e8b:3b48:488e]) by smtp.gmail.com with ESMTPSA id v18-20020a5d5912000000b00205a7d0c6a3sm15035485wrd.69.2022.03.31.01.50.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 01:50:58 -0700 (PDT) Message-ID: <445c5426-cfb6-0232-6ea5-41cf8aaa264e@redhat.com> Date: Thu, 31 Mar 2022 10:50:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v4 1/2] mm: hugetlb_vmemmap: introduce ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP To: Muchun Song Cc: Will Deacon , Andrew Morton , "Bodeddula, Balasubramaniam" , Oscar Salvador , Mike Kravetz , David Rientjes , Mark Rutland , Catalin Marinas , james.morse@arm.com, Barry Song <21cnbao@gmail.com>, LAK , LKML , Linux Memory Management List , Xiongchun duan , Fam Zheng , Muchun Song References: <20220331065640.5777-1-songmuchun@bytedance.com> <6c774e27-26d2-6c45-65f9-8a5b8acd6433@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_015102_624512_770630D9 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31.03.22 10:48, Muchun Song wrote: > On Thu, Mar 31, 2022 at 4:42 PM David Hildenbrand wrote: >> >> On 31.03.22 08:56, Muchun Song wrote: >>> The feature of minimizing overhead of struct page associated with each >>> HugeTLB page is implemented on x86_64, however, the infrastructure of >>> this feature is already there, we could easily enable it for other >>> architectures. Introduce ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP for other >>> architectures to be easily enabled. Just select this config if they >>> want to enable this feature. >>> >>> Suggested-by: Andrew Morton >>> Signed-off-by: Muchun Song >>> --- >>> arch/x86/Kconfig | 1 + >>> fs/Kconfig | 10 +++++++++- >>> 2 files changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >>> index 9f5bd41bf660..e69d42528542 100644 >>> --- a/arch/x86/Kconfig >>> +++ b/arch/x86/Kconfig >>> @@ -119,6 +119,7 @@ config X86 >>> select ARCH_WANTS_DYNAMIC_TASK_STRUCT >>> select ARCH_WANTS_NO_INSTR >>> select ARCH_WANT_HUGE_PMD_SHARE >>> + select ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP if X86_64 >>> select ARCH_WANT_LD_ORPHAN_WARN >>> select ARCH_WANTS_THP_SWAP if X86_64 >>> select ARCH_HAS_PARANOID_L1D_FLUSH >>> diff --git a/fs/Kconfig b/fs/Kconfig >>> index 6c7dc1387beb..f6db2af33738 100644 >>> --- a/fs/Kconfig >>> +++ b/fs/Kconfig >>> @@ -245,9 +245,17 @@ config HUGETLBFS >>> config HUGETLB_PAGE >>> def_bool HUGETLBFS >>> >>> +# >>> +# Select this config option from the architecture Kconfig, if it is preferred >>> +# to enable the feature of minimizing overhead of struct page associated with >>> +# each HugeTLB page. >>> +# >>> +config ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP >>> + bool >>> + >>> config HUGETLB_PAGE_FREE_VMEMMAP >>> def_bool HUGETLB_PAGE >>> - depends on X86_64 >>> + depends on ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP >>> depends on SPARSEMEM_VMEMMAP >>> >>> config HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON >> >> >> I think something like "HUGETLB_OPTIMIZE_VMEMMAP" might be more >> expressive, but that would imply renaming the existing config knob. >> > > How about doing a full code cleanup in a separate series in the future? > Yeah. -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel