From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 373BBCA0EC4 for ; Mon, 11 Aug 2025 23:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7PIOxtdzXDKbPCUG3JZ5qDoi83JISsySVD2kOCny20M=; b=uVtJvo2mTueh3K5iGcej/W7s4F Yq9rZMiaCmLBSRelIpNIAeS4dFnEccs2eWZ50KWB1yWgSUmfe1G8tYZC/nlFhknRTgLafR6edf9x8 YwRAhjQs3z5sZfd1plG0v8WUU8qnWAPmd3sL9FnX3C87JwAyYzp/PnOpDbuzLj0uyFGV5N7ahytBI ZsG9TJWmkrUdXxY9lqaW49hcKS3IjYsFQN8T9x6XdXKBieNW2xKBYgGaarL9hUAEX6rGMKvWmoMN6 /CE6nzLpSmL0ae5iZOY7H5CBjGobxK/hdp0F91DMIpp+X11o2ZHZ2qXqbgcN54lEYoUcG6W/iEewz aMzvc27A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulbaS-00000009Kmd-293c; Mon, 11 Aug 2025 23:05:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulbVQ-00000009KEP-0QUP; Mon, 11 Aug 2025 23:00:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=7PIOxtdzXDKbPCUG3JZ5qDoi83JISsySVD2kOCny20M=; b=RKeQjeoLcBe1TmvvhtirroQrsJ 0f19F8obzm4MZfUKSVIM4sllb4/huSBkkT+WH3Yw2PeYN3HtStiu+oT5gYI1cO6NezO4u8wpsVnKU EOZdJOvGkOo0T/zgo34prRkG6S4A3Ey7sCJygHfc3kO/2m970D3JKG0FpAF/wMiyHCTvC/teUtuFx v2hvpD7ji7viY0zSVJzRMxEFn6USb+dgudeY/w77uqk0GgtFceEdGm86Bo0R9+fRXNeubEJKGvapk 6iEKmdxfJuNTigzvCEMR2ePePRnzwcEUDhIiygNpWlQFjFZZicv9ZGmFmnefEBG/tWrc85w3KAlv1 UNnJ3RCQ==; Received: from mail-dm6nam12on20621.outbound.protection.outlook.com ([2a01:111:f403:2417::621] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulbVM-0000000FbCa-2mlX; Mon, 11 Aug 2025 23:00:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A/Zlvxyr905+xMoZYo+2P/CtHJRoRotvKuHu6dfnEm23OsJ4ahRIz2ecLr11IR79Yauj9xgUetDQY5xGB6MpCvChRmUvmoMw31N5qB2brJPsTZMRWdCrpvqxiU6FyXhbmeT/G6h/ruySMJfnrsweHOTM5OrdUYS+th6sfBkXDH+DwUdWTFhl0ryCF0h5RWrMJf670ToCx5+b+/dtnH7ouuOsPEcc4UM6JcbHzh11FvxP2SzGyqHcXr0coRRHr0gHFfQySlhaehlm1gRL+cNlYddfH7POhYgkJnj0EQwv7dH23ceNfIu0BZVnNMXOZpCgKym1eWEkt0uo9FOIUrifzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7PIOxtdzXDKbPCUG3JZ5qDoi83JISsySVD2kOCny20M=; b=XyGtXoJXVTZ15bVtP8ezE+dV+iOJX5X0veThjE9kfHNRHP7i2pxRHUC58I8xMQTIf5/uGK9KjfGLD1MymnATZ4ungRGdMKN2B9cUjUr8vQ2mYaxUaKa6X3T1YeDoT1M0lqLt/JxB0qzsWPwye2KurEndsVEu3ZU66xvnV2naB9nUXGMqqljMvX9q1BxzxrTRkkGB6UatpjhWiTfuVNp+Ofef0WRJTZjLxSQP1W9Z3SDbC5m2PDOGB9+0T9h1IuEqMypzQtbkZGV6XMYTPDJ1/xM0xuwpy/PHVuhOw1qAKgvXgtPz8Hs2FLbX2/8kr7ad6c79O+/+h1rjTuZRlt7bDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7PIOxtdzXDKbPCUG3JZ5qDoi83JISsySVD2kOCny20M=; b=WOAxQlnu6Ujcx8obrkxuCuN836NzNoyw0sliX3Oul1MvuntFDMevn7ZzVpt8pwinPrEE4Z5RPsW6RRP9vfqCHdAQ5m2ijOaQnBxAKf6FFc5zgLpGrpcBJJDQjHH0FbwpPcai+C6v8s49I58R2VrCfolk0ZsOnaLONzrgGKtY3VHHn46PkWKDDqoD6SP9OV9waXv75aUfUDpedthLFK+yYw4QhCwR7bvUwZuo8aWZ04cKqZ7ty9/SlENq7ljC48g2jQ+y1BL6otxs6KrOlR11sNKfdNlB/VTAiCxf/C89Boy/lGBsMGmlGT1p+dye26dMT12bxjsuVs0w2ty6c8QkFg== Received: from BN8PR04CA0013.namprd04.prod.outlook.com (2603:10b6:408:70::26) by CY8PR12MB7337.namprd12.prod.outlook.com (2603:10b6:930:53::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9009.21; Mon, 11 Aug 2025 23:00:26 +0000 Received: from BL6PEPF0002256E.namprd02.prod.outlook.com (2603:10b6:408:70:cafe::b8) by BN8PR04CA0013.outlook.office365.com (2603:10b6:408:70::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9009.21 via Frontend Transport; Mon, 11 Aug 2025 23:00:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0002256E.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.11 via Frontend Transport; Mon, 11 Aug 2025 23:00:25 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 11 Aug 2025 16:00:06 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 11 Aug 2025 16:00:05 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Mon, 11 Aug 2025 16:00:04 -0700 From: Nicolin Chen To: , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v3 1/5] iommu: Lock group->mutex in iommu_deferred_attach Date: Mon, 11 Aug 2025 15:59:08 -0700 Message-ID: <44783ca52e17a9ca0ce7acfe8daae3edc3d7b45b.1754952762.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256E:EE_|CY8PR12MB7337:EE_ X-MS-Office365-Filtering-Correlation-Id: b647f384-12a0-4666-7f5e-08ddd92adc08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700013|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IJOYiK7sBsD96m2AiPnp+10AgQ4vQ+syKCZNszHCF6cLVm7j19KyLHrsI8Tj?= =?us-ascii?Q?R9BtaWWRbUIiwzkf8wecZLdUNOvcRQFQvxZb1dTu/6bZA//3W23vK/3seeH1?= =?us-ascii?Q?Vbt+5IIfgIeqWeExXzcl99vTnyNp+vo8JVUcVImnaz9sydy2ArKrm7xKDt+r?= =?us-ascii?Q?+ggF/xOpNcZfGWcjHx52I2cf0m9SfqfjHuC/p5faPJAJJPxBLZ3tBi5ZDUEh?= =?us-ascii?Q?IpcZ0u83NsRDUlSD96xgm7OgzFuJsZe/ebvjKuww2064WGx8mfrWfohAPiUH?= =?us-ascii?Q?tp5Lg87UoCISJQQ3kUJOkhEznQguetERgYZ1XyP9mLj8aHGUBDfUpWRWofsO?= =?us-ascii?Q?bhzbzvp6YkLeAvpjP2lgr+//y3PY6Mk8vTKpL/zEMPa4CwAoRFWdl+4yjqke?= =?us-ascii?Q?+tgU0Gbf3qHEABRCPFakrsXOG4ZR3mu7jser45BfZ/jXHzP9KI4Yw/6PMVlL?= =?us-ascii?Q?4Q5xJQ8j8k/A0wDkkE8/1SkG5UrdiVdeRGPbLmL94BN2rzcF0g0RPN3vTlJ5?= =?us-ascii?Q?3MOcRJN/jF8PMiNw5W0JXfaaeo5zHgRR7P8vnMmN1jpHaYcI0JqNry+lS3Df?= =?us-ascii?Q?cdS2aKanisN/Ck4ac8IphhTl379GMq0SRG7IJt+DG291DCe+IgY8BZfYBVvH?= =?us-ascii?Q?CV6LycPQEgz/ZV2WQSx0TPdU6wzeDVIEhu8Z4gFKBMAI4H+k/vqyJT5G6BfY?= =?us-ascii?Q?qkocvh4IFsWFL6gtDuov0ltNHUhJ5oxBReXVMFF2O5ezIS3yw55Jja4gCpQq?= =?us-ascii?Q?2EFt0R/P1tn3y/quAboLosM7dIkJJyiwcPXMFa40eGM+4/vs93WiHqto5C/s?= =?us-ascii?Q?fjmW4XoWSVTKwo1w+8NncXLMYZWti3AwI15+cmCBsKV0bgOe478oDgEHilJG?= =?us-ascii?Q?jV2J6YgbCgHUQOSlpGF8pud8oxh0rnfeF+aSzNyqf8UFo9PYIiWny0In3W6i?= =?us-ascii?Q?yNQbLA8Qif1PTztAv0sZKsCoDOH3Zyns5/v7tt+24blGI7P5Bk8lj50vaVH1?= =?us-ascii?Q?9yYdj/LTTjsrCMS0fUBxzV8p04YOaTdZyjh4f7gVZM2kAMgHkmFC0SCFPZY4?= =?us-ascii?Q?zoHUvYRK3+DrkEbyz9Du+N1EGBifpXx7RtnIFgMVhz/7iQKKBN7724vMoAe8?= =?us-ascii?Q?f6aMmdkde5LoCv9vA0smDjfTdg29YQMODYGyjxbqLv6n/AxHPsQy4p7U2sQc?= =?us-ascii?Q?sQu62RRHnMJozV0xrdXrCb/YS6S6RSgTdJF3iG9Y+p0646tBdAerPBhseEYL?= =?us-ascii?Q?YkzgvDQ0AUkLM+G/CLiIw7gKcgNbO8zlCQu5jpD7zWmfBUfQa5GBAk4kU4xJ?= =?us-ascii?Q?xTBmVQtIiRc4ZWiSkjfCAYLR5ylsiHgo9fX2MwubAv6CnmyEKEJ4XunT314Y?= =?us-ascii?Q?2XkvzhKMUD3IPZ0fJLd9i6VBn4fkrffJEnj2LYuH/cXUrHQOGuAp/b/MqF/G?= =?us-ascii?Q?NqQPicqhIFCI91Dh3g4Hi32jE1opy259IJnCwfeFVkXVD+NS/ZscYdyGdwDK?= =?us-ascii?Q?LETb5o9byqpK+kA3P1yIDpsZ+kWWKPqtwCsI?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2025 23:00:25.7946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b647f384-12a0-4666-7f5e-08ddd92adc08 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7337 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250812_000036_976350_638FA84C X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The iommu_deferred_attach() is a runtime asynchronous function called by iommu-dma function, which could race against other attach functions if it accesses something in the dev->iommu_group. So, grab the mutex to guard __iommu_attach_device() like other callers. Reviewed-by: Jason Gunthorpe Signed-off-by: Nicolin Chen --- drivers/iommu/iommu.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 060ebe330ee16..1e0116bce0762 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -2144,10 +2144,17 @@ EXPORT_SYMBOL_GPL(iommu_attach_device); int iommu_deferred_attach(struct device *dev, struct iommu_domain *domain) { - if (dev->iommu && dev->iommu->attach_deferred) - return __iommu_attach_device(domain, dev); + /* + * This is called on the dma mapping fast path so avoid locking. This is + * racy, but we have an expectation that the driver will setup its DMAs + * inside probe while being single threaded to avoid racing. + */ + if (!dev->iommu || !dev->iommu->attach_deferred) + return 0; - return 0; + guard(mutex)(&dev->iommu_group->mutex); + + return __iommu_attach_device(domain, dev); } void iommu_detach_device(struct iommu_domain *domain, struct device *dev) -- 2.43.0