Re: media: mediatek: vcodec: use = { } instead of memset()

[Nicolas Dufresne <nicolas@ndufresne.ca>]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

Le mardi 05 août 2025 à 15:32 +0200, Markus Elfring a écrit :
> > > …
> > > > This patch converts …
> > > See also once more:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n94
> > I don't think your point is a problem here. …
> 
> Will any contributors care more for the usage of imperative mood
> also according to improved change descriptions?

Markus, its the way you review that does not work. I'm far from perfect, so I
don't normally give any lesson, but I've seen this this exact interaction too
often. Try suggesting a rephrase instead.

Qianfeng Rong, the suggestion is that:

   This patch converts memset() to = { }, thereby:
   
Can be rephrased:

   Converts memset() to = { }, thereby:

Also, some maintainers may prefer if you swap the two paraphs, so you get to the
point first, and give context in the remaining. Processing tones of patches is
improved if you don't have to read the entire message to understand what the
patch is doing at high level.

regards,
Nicolas

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]