[PATCH] MAINTAINERS: Update xilinx-ams driver maintainers

[PATCH] MAINTAINERS: Update xilinx-ams driver maintainers

[Salih Erim]

Removes Anand Ashok from maintainers and adds Salih
and Conall as new maintainers.

Signed-off-by: Salih Erim <salih.erim@amd.com>
---
 Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml | 3 ++-
 MAINTAINERS                                                    | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
index a403392fb263..3ae1a0bab38f 100644
--- a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
@@ -7,7 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Xilinx Zynq Ultrascale AMS controller

 maintainers:
-  - Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
+  - Salih Erim <salih.erim@amd.com>
+  - Conall O'Griofa <conall.ogriofa@amd.com>

 description: |
   The AMS (Analog Monitoring System) includes an ADC as well as on-chip sensors
diff --git a/MAINTAINERS b/MAINTAINERS
index daf520a13bdf..b4b27a31a782 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -27537,7 +27537,8 @@ F:	include/uapi/linux/dqblk_xfs.h
 F:	include/uapi/linux/fsmap.h

 XILINX AMS DRIVER
-M:	Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
+M:	Salih Erim <salih.erim@amd.com>
+M:	Conall O'Griofa <conall.ogriofa@amd.com>
 L:	linux-iio@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
--
2.34.1

RE: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers

[O'Griofa, Conall]

[AMD Official Use Only - AMD Internal Distribution Only]

Acked-by: O'Griofa, Conall <conall.ogriofa@amd.com>

> -----Original Message-----
> From: Salih Erim <salih.erim@amd.com>
> Sent: 19 August 2025 16:05
> To: Erim, Salih <Salih.Erim@amd.com>; O'Griofa, Conall
> <conall.ogriofa@amd.com>; jic23@kernel.org
> Cc: dlechner@baylibre.com; nuno.sa@analog.com; andy@kernel.org; Simek,
> Michal <michal.simek@amd.com>; linux-iio@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers
>
> Removes Anand Ashok from maintainers and adds Salih and Conall as new
> maintainers.
>
> Signed-off-by: Salih Erim <salih.erim@amd.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml | 3 ++-
>  MAINTAINERS                                                    | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> index a403392fb263..3ae1a0bab38f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> @@ -7,7 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>  title: Xilinx Zynq Ultrascale AMS controller
>
>  maintainers:
> -  - Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
> +  - Salih Erim <salih.erim@amd.com>
> +  - Conall O'Griofa <conall.ogriofa@amd.com>
>
>  description: |
>    The AMS (Analog Monitoring System) includes an ADC as well as on-chip
> sensors diff --git a/MAINTAINERS b/MAINTAINERS index
> daf520a13bdf..b4b27a31a782 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27537,7 +27537,8 @@ F:    include/uapi/linux/dqblk_xfs.h
>  F:   include/uapi/linux/fsmap.h
>
>  XILINX AMS DRIVER
> -M:   Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
> +M:   Salih Erim <salih.erim@amd.com>
> +M:   Conall O'Griofa <conall.ogriofa@amd.com>
>  L:   linux-iio@vger.kernel.org
>  S:   Maintained
>  F:   Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> --
> 2.34.1

Re: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers

[Jonathan Cameron]

On Tue, 19 Aug 2025 15:10:15 +0000
"O'Griofa, Conall" <conall.ogriofa@amd.com> wrote:

> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Acked-by: O'Griofa, Conall <conall.ogriofa@amd.com>

I'm not entirely sure why but b4 only picked up:

[PATCH] MAINTAINERS: Update xilinx-ams driver maintainers
    + Acked-by: Michal Simek <michal.simek@amd.com>
    + Acked-by: 
    + Link: https://patch.msgid.link/20250819150448.1979170-1-salih.erim@amd.com

Anyhow I fixed it up to include Connal's ack whilst applying.

Salih and Connal, thanks for stepping up.

Jonathan

> 
> > -----Original Message-----
> > From: Salih Erim <salih.erim@amd.com>
> > Sent: 19 August 2025 16:05
> > To: Erim, Salih <Salih.Erim@amd.com>; O'Griofa, Conall
> > <conall.ogriofa@amd.com>; jic23@kernel.org
> > Cc: dlechner@baylibre.com; nuno.sa@analog.com; andy@kernel.org; Simek,
> > Michal <michal.simek@amd.com>; linux-iio@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org
> > Subject: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers
> >
> > Removes Anand Ashok from maintainers and adds Salih and Conall as new
> > maintainers.
> >
> > Signed-off-by: Salih Erim <salih.erim@amd.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml | 3 ++-
> >  MAINTAINERS                                                    | 3 ++-
> >  2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> > b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> > index a403392fb263..3ae1a0bab38f 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> > @@ -7,7 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> >  title: Xilinx Zynq Ultrascale AMS controller
> >
> >  maintainers:
> > -  - Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
> > +  - Salih Erim <salih.erim@amd.com>
> > +  - Conall O'Griofa <conall.ogriofa@amd.com>
> >
> >  description: |
> >    The AMS (Analog Monitoring System) includes an ADC as well as on-chip
> > sensors diff --git a/MAINTAINERS b/MAINTAINERS index
> > daf520a13bdf..b4b27a31a782 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -27537,7 +27537,8 @@ F:    include/uapi/linux/dqblk_xfs.h
> >  F:   include/uapi/linux/fsmap.h
> >
> >  XILINX AMS DRIVER
> > -M:   Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
> > +M:   Salih Erim <salih.erim@amd.com>
> > +M:   Conall O'Griofa <conall.ogriofa@amd.com>
> >  L:   linux-iio@vger.kernel.org
> >  S:   Maintained
> >  F:   Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> > --
> > 2.34.1  
> 

Re: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers

[Andy Shevchenko]

On Tue, Aug 19, 2025 at 8:45 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 19 Aug 2025 15:10:15 +0000
> "O'Griofa, Conall" <conall.ogriofa@amd.com> wrote:
>
> > Acked-by: O'Griofa, Conall <conall.ogriofa@amd.com>
>
> I'm not entirely sure why but b4 only picked up:
>
> [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers
>     + Acked-by: Michal Simek <michal.simek@amd.com>
>     + Acked-by:

Due to an unquoted comma, I believe.
+Konstantin

>     + Link: https://patch.msgid.link/20250819150448.1979170-1-salih.erim@amd.com
>
> Anyhow I fixed it up to include Connal's ack whilst applying.


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers

[Michal Simek]

On 8/19/25 17:04, Salih Erim wrote:
> Removes Anand Ashok from maintainers and adds Salih
> and Conall as new maintainers.
> 
> Signed-off-by: Salih Erim <salih.erim@amd.com>
> ---
>   Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml | 3 ++-
>   MAINTAINERS                                                    | 3 ++-
>   2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> index a403392fb263..3ae1a0bab38f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> @@ -7,7 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>   title: Xilinx Zynq Ultrascale AMS controller
> 
>   maintainers:
> -  - Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
> +  - Salih Erim <salih.erim@amd.com>
> +  - Conall O'Griofa <conall.ogriofa@amd.com>
> 
>   description: |
>     The AMS (Analog Monitoring System) includes an ADC as well as on-chip sensors
> diff --git a/MAINTAINERS b/MAINTAINERS
> index daf520a13bdf..b4b27a31a782 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27537,7 +27537,8 @@ F:	include/uapi/linux/dqblk_xfs.h
>   F:	include/uapi/linux/fsmap.h
> 
>   XILINX AMS DRIVER
> -M:	Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
> +M:	Salih Erim <salih.erim@amd.com>
> +M:	Conall O'Griofa <conall.ogriofa@amd.com>
>   L:	linux-iio@vger.kernel.org
>   S:	Maintained
>   F:	Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> --
> 2.34.1
> 

Acked-by: Michal Simek <michal.simek@amd.com>

FYI: Anand left AMD some time ago

Thanks,
Michal

Re: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers

[Krzysztof Kozlowski]

On 19/08/2025 17:04, Salih Erim wrote:
> Removes Anand Ashok from maintainers and adds Salih
> and Conall as new maintainers.

We see that from the diff. Don't write what is obvious. Explain what is
not obvious: why you are doing this.

Best regards,
Krzysztof

RE: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers

[Erim, Salih]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Wednesday, August 20, 2025 7:11 AM
> To: Erim, Salih <Salih.Erim@amd.com>; O'Griofa, Conall
> <conall.ogriofa@amd.com>; jic23@kernel.org
> Cc: dlechner@baylibre.com; nuno.sa@analog.com; andy@kernel.org; Simek,
> Michal <michal.simek@amd.com>; linux-iio@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 19/08/2025 17:04, Salih Erim wrote:
> > Removes Anand Ashok from maintainers and adds Salih and Conall as new
> > maintainers.
>
> We see that from the diff. Don't write what is obvious. Explain what is not obvious:
> why you are doing this.

As Michal explained, Anand left AMD while ago. Me and Conall continue to maintain the driver.

Thanks for warning, I will be careful about future comments and communications.

Regards,
Salih.

Re: [PATCH] MAINTAINERS: Update xilinx-ams driver maintainers

[Krzysztof Kozlowski]

On 20/08/2025 11:10, Erim, Salih wrote:
>> We see that from the diff. Don't write what is obvious. Explain what is not obvious:
>> why you are doing this.
> 
> As Michal explained, Anand left AMD while ago. Me and Conall continue to maintain the driver.
> 
> Thanks for warning, I will be careful about future comments and communications.
> 

No, your commit msg should explain that. Do not say what you do.

Best regards,
Krzysztof