From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03451C2D0A3 for ; Fri, 6 Nov 2020 12:49:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4905F206B7 for ; Fri, 6 Nov 2020 12:49:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wqRXEHhj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AF1TWY0b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4905F206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=srWo5b0yuuC02V75l8N7b8Q56szRHlUpL7aqJohU9rY=; b=wqRXEHhjzP2mq2rRY/NJ3ikqo Pv5a2WlD0UpmvvTzfZ8KlyTS+YNtYnsqV9SoUbkob/pyjtjarmD+bXcyWA5CN/bTntclGxLN8DJ9X H+5ic7duEoO8ebIm4t/dqw937xUCu3SBL+nQ2uB+6qck/535sH5xDErtF5hcMhgavzG7E+qocGibB 7YaUZlDMOuQCSk14dw64r9Heiguta8OdCbL9TYQha1FEoLvOEfq2MeaM7LurGAsISZ98gjbjfpt1W RHSwr6SJ+T1YCthLVxfyi0jd1HLyF2+PDfyK4drsgZf3RGloJmKC2Il4dokfl+eFtVZwYWqUx+Sf3 /VYSciywg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb1Az-0007BE-3I; Fri, 06 Nov 2020 12:49:09 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb1Aw-0007Ae-Ma for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 12:49:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604666946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rjoSq9w5FHJ9ialWxeQLeGSh1Vka0U+JlugVi+0MMcg=; b=AF1TWY0baVW8vAljeTqytGLcgQS9cpncuKr64KYnl2l3YiErmhgksRUclXYeriPVeIVo9b l5yz/xMhR+JJR+SePrhVOxN9IHHcK7GFfxCR1PV0z4bBtgoqWnE2aaMGVSL8TZgoNEfFcF CVYXvG3N+1BOYtyjB9oKqPER/N+Z06I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-19NI3trpM0uyBBcXNPF2_w-1; Fri, 06 Nov 2020 07:49:02 -0500 X-MC-Unique: 19NI3trpM0uyBBcXNPF2_w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1EA136D243; Fri, 6 Nov 2020 12:49:01 +0000 (UTC) Received: from ovpn-66-140.rdu2.redhat.com (ovpn-66-140.rdu2.redhat.com [10.10.66.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B74973673; Fri, 6 Nov 2020 12:49:00 +0000 (UTC) Message-ID: <44d61059f01188afd833b0e889a360cd4189f293.camel@redhat.com> Subject: Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier From: Qian Cai To: Will Deacon Date: Fri, 06 Nov 2020 07:48:59 -0500 In-Reply-To: <20201106103755.GA9729@willie-the-truck> References: <20201028182614.13655-1-cai@redhat.com> <160404559895.1777248.8248643695413627642.b4-ty@kernel.org> <20201105222242.GA8842@willie-the-truck> <3b4c324abdabd12d7bd5346c18411e667afe6a55.camel@redhat.com> <20201105232813.GR3249@paulmck-ThinkPad-P72> <20201106103755.GA9729@willie-the-truck> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_074906_990342_88E73053 X-CRM114-Status: GOOD ( 15.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: paulmck@kernel.org, Peter Zijlstra , catalin.marinas@arm.com, linux-kernel@vger.kernel.org, kernel-team@android.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2020-11-06 at 10:37 +0000, Will Deacon wrote: > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > > index 09c96f57818c..10729d2d6084 100644 > > --- a/arch/arm64/kernel/smp.c > > +++ b/arch/arm64/kernel/smp.c > > @@ -421,6 +421,8 @@ void cpu_die_early(void) > > > > update_cpu_boot_status(CPU_STUCK_IN_KERNEL); > > > > + rcu_report_dead(cpu); > > I think this is in the wrong place, see: > > https://lore.kernel.org/r/20201106103602.9849-1-will@kernel.org > > which seems to fix the problem for me. Ah, I had not realized that cpu_psci_cpu_die() could no return. Your patchset looks good to me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel