From: Easwar Hariharan <eahariha@linux.microsoft.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: eahariha@linux.microsoft.com,
"Louis-Alexis Eyraud" <louisalexis.eyraud@collabora.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Subject: Re: [PATCH] Input: mtk-pmic-keys: Fix null pointer dereference when no compatible data
Date: Mon, 30 Jun 2025 15:23:36 -0700 [thread overview]
Message-ID: <44e48ee7-07a8-4bbc-a98b-095bb1d585a0@linux.microsoft.com> (raw)
In-Reply-To: <667whxdsghpao5irl66oh66l5y55m4k6n3ztifaizbqtrzccju@cmghlz2yauxq>
On 6/30/2025 2:46 PM, Dmitry Torokhov wrote:
> On Mon, Jun 30, 2025 at 01:18:40PM -0700, Easwar Hariharan wrote:
>>
>> Also, it may make sense to CC: stable@vger.kernel.org for backports
>
> What for? Stable does not need a patch papering over an oops, it needs a
> patch making the keypad working on the affected device.
>
> Thanks.
>
I don't have a stake either way, it was simply a suggestion, since it qualifies
IMHO, per https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html,
the patch "...fixes a problem like an oops..."
The proper fix might well be, as Nicolas suggested, adding the required compatibles.
- Easwar (he/him)
next prev parent reply other threads:[~2025-06-30 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 14:03 [PATCH] Input: mtk-pmic-keys: Fix null pointer dereference when no compatible data Louis-Alexis Eyraud
2025-06-30 14:06 ` AngeloGioacchino Del Regno
2025-06-30 15:25 ` Dmitry Torokhov
2025-06-30 19:59 ` Nícolas F. R. A. Prado
2025-06-30 23:03 ` Dmitry Torokhov
2025-06-30 20:18 ` Easwar Hariharan
2025-06-30 21:46 ` Dmitry Torokhov
2025-06-30 22:23 ` Easwar Hariharan [this message]
2025-06-30 23:06 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44e48ee7-07a8-4bbc-a98b-095bb1d585a0@linux.microsoft.com \
--to=eahariha@linux.microsoft.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox