From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8FD1C77B61 for ; Fri, 21 Apr 2023 16:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aewPHB7MTb+uj5X1jlhd+pKkUld8a+T+g1pPfS9T7KY=; b=Rf+/hNV338POWj dkP00dWwvO2l81T5zQFvLgWe0XUBGNdtNVnEfH612WSbUdQeNTkeM1/cuJxiWF2U4qkOatwGddboU yL+3B73Tj1Vu/iafFksXUP6wqHqSLiMmW0WkPs8+ZGGB7JIE6MtRtNiC3OtQOmC/CREo9+/15m7vF ChKZSzkROcawJCH7kpNZyZlgyU8ninrRPnhJxgPwk/rw25MffGEATjaRkK+Gk1C9L833KNFj5gi/T xDBuh/xhJqo5Xgyy+djprdfQO0DBu5YlGZtVLlrkEd5gKsKD3fYYRzHDC8frxVHcOIS5BTAJTSUkK 0sV4MopwExMwRoMN6EOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pptes-00BO2H-1h; Fri, 21 Apr 2023 16:30:50 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pptep-00BO1K-22 for linux-arm-kernel@lists.infradead.org; Fri, 21 Apr 2023 16:30:48 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5050491cb04so2776217a12.0 for ; Fri, 21 Apr 2023 09:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682094645; x=1684686645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UVr8lLzVps9ZuMV0XAHw4eg8z7YXbZGCdlhpUNWCutQ=; b=DwM7MXIKKSfaUMu1eJSCloBjXJpaWHmzbVeI7uMDb7pgL26Yroz/mrZnf+4gtrdE32 zExJo/fxP73tyLq655HHLTKrCsFatO34nBhRbfiVIMhlyj/+r8Eh8yx8N2ZaXNRi8oAF IW2kt7uZzpCSSmxDo54dDanjtAMdz0KucVKX6OLZf8iP/KTVxB496RNWBL2q4r+SmEK5 TcvtGvBBuW919Awdq2NozfHd2fEMp7na72TSuKyqiu8JdDpk42iHW1YO+ljs8J15VAIg TtU2RWkt0B0KOfnYkux1+LEVI3q2cepzBD1Brn1hT4Qa/4hYdAaJ1ygI60RyEZLy3GtJ aCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682094645; x=1684686645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UVr8lLzVps9ZuMV0XAHw4eg8z7YXbZGCdlhpUNWCutQ=; b=gZjg4ozRVj5c9lI3kUENgpAIhMsoyklZlfbT+EZF31m02TshtIOmBBOu5xx6AOlgrh 94AUU2qKNrmV4hMdO/iXAscaIkLc4gTl/XbJgD+PM6VyjHfNoUHJJ5liyLWTfRbcYFmT wxD5WPOVa7g3Kvg5wCB5COG9gPXITRXu5/mckFKbkmB8AjhlPiTB4qBZcPz/0PJpylK6 pZEhIvkDgeY1urkEyaoiRTjp2wBY1ygo4HO6FttTED7jz0qYr2buf5VGYCQ6SBWEE/fN N1MaTo4bwGb89+WFNobMmoUGUWLS3zcjYlg6mjc9He3zAbopqGYrknUKVdc8qWe1lfcz UzLw== X-Gm-Message-State: AAQBX9eA3PYNjipeHoBzmKxYMlT4a3CpglfArpSdhLm+CIMwUqAV9WqQ US0F0ZMfeGAxtIYlxr5Z6giLLQ== X-Google-Smtp-Source: AKy350aa+VFT9KWufyYZvoi2qVl9Wo73hJiODISOMGd6i4if1G9OIE1Qj4FNQLJhsvAngpdIWqI+Pg== X-Received: by 2002:aa7:c592:0:b0:506:c288:118 with SMTP id g18-20020aa7c592000000b00506c2880118mr5598942edq.39.1682094645408; Fri, 21 Apr 2023 09:30:45 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:687d:8c5:41cb:9883? ([2a02:810d:15c0:828:687d:8c5:41cb:9883]) by smtp.gmail.com with ESMTPSA id d12-20020a50fb0c000000b004bf999f8e57sm1963884edq.19.2023.04.21.09.30.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 09:30:44 -0700 (PDT) Message-ID: <44e54d54-9a6d-ba49-c0db-f9de81743f64@linaro.org> Date: Fri, 21 Apr 2023 18:30:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 06/11] dt-bindings: PCI: Update the RK3399 example to a valid one Content-Language: en-US To: Lorenzo Pieralisi Cc: Rick Wertenbroek , alberto.dassatti@heig-vd.ch, xxm@rock-chips.com, dlemoal@kernel.org, Shawn Lin , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Heiko Stuebner , Caleb Connolly , Corentin Labbe , Brian Norris , Johan Jonker , Judy Hsiao , Sascha Hauer , Hugh Cole-Baker , Arnaud Ferraris , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230418074700.1083505-1-rick.wertenbroek@gmail.com> <20230418074700.1083505-7-rick.wertenbroek@gmail.com> <172c46b7-256e-b09d-3940-880fa8989b49@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230421_093047_666401_2DBF6036 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/04/2023 11:26, Lorenzo Pieralisi wrote: > On Wed, Apr 19, 2023 at 10:01:25PM +0200, Krzysztof Kozlowski wrote: >> On 18/04/2023 09:46, Rick Wertenbroek wrote: >>> Update the example in the documentation to a valid example. >>> Address for mem-base was invalid, it pointed to address >>> 0x8000'0000 which is the upper region of the DDR which >>> is not necessarily populated depending on the board. >>> This address should point to the base of the memory >>> window region of the controller which is 0xfa00'0000. >>> Add missing pinctrl. >>> >>> Signed-off-by: Rick Wertenbroek >>> --- >>> .../devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>> index 88386a6d7011..6b62f6f58efe 100644 >>> --- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>> +++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>> @@ -47,7 +47,7 @@ examples: >>> >>> pcie-ep@f8000000 { >>> compatible = "rockchip,rk3399-pcie-ep"; >>> - reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0x80000000 0x0 0x20000>; >>> + reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0xfa000000 0x0 0x2000000>; >>> reg-names = "apb-base", "mem-base"; >>> clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>, >>> <&cru PCLK_PCIE>, <&cru SCLK_PCIE_PM>; >>> @@ -63,6 +63,8 @@ examples: >>> phys = <&pcie_phy 0>, <&pcie_phy 1>, <&pcie_phy 2>, <&pcie_phy 3>; >>> phy-names = "pcie-phy-0", "pcie-phy-1", "pcie-phy-2", "pcie-phy-3"; >>> rockchip,max-outbound-regions = <16>; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pcie_clkreqnb_cpm>; >> >> This is just example of the binding, you do not need to fill all >> unrelated (generic) properties like pinctrl. > > Should I merge it as-is ? Yeah, go ahead. That was the note for the future that generic properties are not always needed or even helpful in the example. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel