From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04AEEC83F14 for ; Tue, 29 Aug 2023 14:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qchQrwgkIDAI6cXL3OPQbvWXFQNMjaJfJ+Q7GqTXX2Q=; b=cRB/GtqxwTwLQR q8wtC1DTGIPFK3gWGrBR6LHY8M10rwCAqGVmGrBK6PoRP92TPUmeWv9hPUFe1ngEotaqPHNcZLku1 jF60C2YdJHfThtH6CbQkjaJ/c3G7WWExR5nBBW/+9USf3jqGDnm06QnCV4jeW1wtjOd4h0ZhKOcwS sN1CEVMjIUtnbySe61eTVXK3tPGw0Oy6FUe3L4Kxy8EoSPkQVNAePOxuyNWWYKbsUZ6HNhKcMU64u GG1FHCeP4XPEUcZxQ0vGr4BHqIETJhpFG1W0Xb/sAOJTfReuD6KG0C83ugM5l0cG+61jWCmXI467E r1NelfH25+17+oVsYktA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qazLF-00BfVd-1s; Tue, 29 Aug 2023 14:05:13 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qazLB-00BfUn-1a for linux-arm-kernel@lists.infradead.org; Tue, 29 Aug 2023 14:05:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1693317909; x=1724853909; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HIjB6DSGcDiXSyJUkfXprhzVVBjmfilf4Wii2YLRbOw=; b=iCZapPnNnkw/1qUk4IKehZxzSzmqEGAOSUrffNg8hLmPk+T7lj7LdHMD INBrUUQs4MfcINUCPS4r1EQtF7gjfSivN0KFc4+GN0UFIdvk1pWsSZfT3 RAQT8a5HWFrCZ9XvoVT+1Sv25si88w/9GJrcfx40vlv9XXOKEysDl+MrJ zw4qMdZv+mpF0S/EZlreLvYYQ/UQJlvNc6bTlQUaQTCnCVv9ZFFLOFLTl l9QKJvy8vrC3cxfpTF2IYpBKgBHCR18bKhJN9NrvjU73YViLjzP81UyQW V9OUaxRAXrhppuUdfvSSwUeXJ3DkgUpzn4tdZ8axclftIGHTkj+DgTc81 Q==; X-IronPort-AV: E=Sophos;i="6.02,210,1688421600"; d="scan'208";a="32680003" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 29 Aug 2023 16:05:04 +0200 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 0271E280045; Tue, 29 Aug 2023 16:05:03 +0200 (CEST) From: Alexander Stein To: Alexandre Torgue , Jose Abreu , "Russell King (Oracle)" Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next] net: stmmac: failure to probe without MAC interface specified Date: Tue, 29 Aug 2023 16:05:03 +0200 Message-ID: <4507976.LvFx2qVVIh@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_070509_910436_87C2CB52 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 29. August 2023, 15:29:50 CEST schrieb Russell King (Oracle): > Alexander Stein reports that commit a014c35556b9 ("net: stmmac: clarify > difference between "interface" and "phy_interface"") caused breakage, > because plat->mac_interface will never be negative. Fix this by using > the "rc" temporary variable in stmmac_probe_config_dt(). > = > Reported-by: Alexander Stein > Signed-off-by: Russell King (Oracle) > --- > I don't think the net tree is up to date with the net-next, so this > patch needs applying to net-next preferably before the pull request > to fix a regression. On top of next-20230829: Tested-by: Alexander Stein Thanks > Thanks. > = > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > = > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index > 35f4b1484029..0f28795e581c 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -419,9 +419,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, = u8 > *mac) return ERR_PTR(phy_mode); > = > plat->phy_interface =3D phy_mode; > - plat->mac_interface =3D stmmac_of_get_mac_mode(np); > - if (plat->mac_interface < 0) > - plat->mac_interface =3D plat->phy_interface; > + rc =3D stmmac_of_get_mac_mode(np); > + plat->mac_interface =3D rc < 0 ? plat->phy_interface : rc; > = > /* Some wrapper drivers still rely on phy_node. Let's save it while > * they are not converted to phylink. */ -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel