From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6027CEB64D9 for ; Mon, 10 Jul 2023 15:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KePvcCf0K0SKh+kXSTuPNFCDXaePCFu+njfIS5Ck3hY=; b=cWt4nbV5MKnsUf 0HDJfYViX1DH7EBZ2iJxzbOvJPuVVWSdN5IhNIy98EJ7l036lvOpBH056fy6H7KT9uAqiXbXsYgmN zBZd0/pdTitEmqwf7we58Zor443p6EIZR2K8aeSN0EWGJoI6ffnEaZ8AwGlKlrdHPQW90gmH4kuVC an9xdCYwrp1MrkrLL/rFr6rj6cLsG3jmw5Epq4gw0Z/iBkw4XlXbl6QtO94sasNH1JH4KhyNBH0Gz xhce+BbvOnXnnPoYERw6WH5qmRZZs7+O27VV4aiz0WNNrgX6eKt9na1pv7i6iKSoxzUsHolqimNP5 hy6svTVzuJO2ofz/UEXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIt04-00C2G1-1m; Mon, 10 Jul 2023 15:40:32 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIt02-00C2F1-1Z; Mon, 10 Jul 2023 15:40:31 +0000 Received: from i53875a50.versanet.de ([83.135.90.80] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qIszV-0001o1-8T; Mon, 10 Jul 2023 17:39:57 +0200 From: Heiko Stuebner To: Mark Kettenis , robh+dt@kernel.org, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: d3adme4t@gmail.com, macromorgan@hotmail.com, jbx6244@gmail.com, f.kardame@manjaro.org, amadeus@jmu.edu.cn, linux.amoon@gmail.com, aurelien@aurel32.net, anarsoul@gmail.com, wiagn233@outlook.com, frattaroli.nicolas@gmail.com, strit@manjaro.org, luiz.von.dentz@intel.com, zonyitoo@gmail.com, wens@csie.org, jensenhuang@friendlyarm.com, lasstp5011@gmail.com, frank-w@public-files.de, pgwipeout@gmail.com, leo@nabam.net, andyshrk@163.com, michael.riesch@wolfvision.net, jonas@kwiboo.se, festevam@denx.de, tobetter@gmail.com, jagan@amarulasolutions.com, cnsztl@gmail.com, cristian.ciocaltea@collabora.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property Date: Mon, 10 Jul 2023 17:39:55 +0200 Message-ID: <4519023.cEBGB3zze1@phil> In-Reply-To: <87wmz7q1fr.fsf@bloch.sibelius.xs4all.nl> References: <20230707162217.675390-1-cristian.ciocaltea@collabora.com> <168899855919.1747213.9998138836668928892.b4-ty@sntech.de> <87wmz7q1fr.fsf@bloch.sibelius.xs4all.nl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_084030_528217_27CCC758 X-CRM114-Status: GOOD ( 20.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 10. Juli 2023, 16:35:36 CEST schrieb Mark Kettenis: > > From: Heiko Stuebner > > Date: Mon, 10 Jul 2023 16:16:16 +0200 > > > > On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote: > > > The 'regulator-init-microvolt' property is not currently supported by > > > any driver, it was simply carried on from downstream kernels. > > > > > > The problem is also indicated by the following dtbs_check warning: > > > > > > rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) > > > > > > [...] > > > > Applied, thanks! > > > > [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property > > commit: 4d08b19629495b29601991d09d07865694c25199 > > This property *is used* by the drivers in U-Boot. Dropping this from > the Linux DTBs will likely result in broken boards the next time the > U-Boot DTBs are synched again from Linux. At least that is what > happened before... > > I think the right solution is to add this property to the DT binding > instead. I do have this vague memory of this coming up in the past, though don't remember what the resolution was then? Though it definitly doesn't look like the property was added to the binding in the meantime. Also I think that setting up initial regulator state would be (and seemingly is) for firmware to handle, so that property should instead be in the -uboot.dtsi. That DT isn't a configuration-space also is a decade long mantra. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel