From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE5C1C433F5 for ; Thu, 7 Apr 2022 17:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=D8ARmOl7NkT3sxH4Jjdu+0PYHLVgaq6L9h4NqCqNTOY=; b=eU4mge7XaQGoavyQv0DCwJLPV9 UFncKgsCikatbG6ID32iWAp08TODJ7Ufwcu/XdHmuOpQCsOhxcOBT5MJPv8txtswwcU4tAIHYehLd hNta5xv8EQmdsKf/eo3ZFFauEdECMnW4MHmw65mcRm/+/lEhSF2Tpn/2OEMo0SW5EKZSyN7/GjaZF dqVffuiS37DuLF0qSMyX2AMqD7Z7VRXiTGguEKTW6Y2raCqCoQa63U/9yY83tlO924GwGJYv3RlmZ HM6JBQqX1Wc+Q2eP4uksO84e0yYCulgOOKxTe8ohWfL6WYnB/kndMp2BPBagJCxXBLwKhEjU5cDvh cPLvxWIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncW9M-00DQuC-5o; Thu, 07 Apr 2022 17:42:28 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncW9I-00DQsk-PQ for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 17:42:26 +0000 Received: by mail-wr1-x42b.google.com with SMTP id q19so8939592wrc.6 for ; Thu, 07 Apr 2022 10:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Qf5/HY0H/HARlpQawjWcubI38eU259kawMq8gp9O7d4=; b=CrkVJRLO1aSJixV9DWKUTF746y41oFcj/ZYQXCMA93sWiB0r8cbHO/f8LZz8KS6V2R VtJYpBNgDsp6YUKM35f2uF3N+8gfMhpVgeHmhzuz8xy4T8pCvh4xoKIQ25X6AicMAZXP deImoshAMsKtF6YC9AZ2M7IJUaUdxIiycCgtpArV5rA0mTPv8LpJEcJyarvYcnZXmNCI aWlfhIlk0mpOrWQ6OdxS5X8MjD75utFVj5Sl/xPB855dp78ch/LkHjf2soCCgGydwfVJ cTIojrIudwVz04FEA14NfrVFmBYZG7vKl9ICFrjbOEbVg9rmja7sZ7v3ms1J2iW6OXWv jt3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Qf5/HY0H/HARlpQawjWcubI38eU259kawMq8gp9O7d4=; b=X+yX29iey3V2C0pqdFCNTcQv4RHgE8/e/1rZRx/3npWqYJfenfP7QlYN/M1f1XMAs7 xqZkE5PJ1Bvnagse9ybZAVvlrwQlCOIMHZM6jjSY8tFqnQ3h1HHuyPwpAHhPDYCI+hub Ocggx2s1IWmjgAvHMBENO7rAV2abd7wwPOafaBgP597cfee7SFXGl/T7gfl3CveYQWxt VPlaME/6oPABgQowUXJ2/RM7o9QUgbgSiXQ4xsTz1A5g5EhoAL/Ku25UuYsbQD7pXCXv gGEiZEQO17eLYKkVtmgOTpNsOPnDut6uZHbGvL8MZI621gLlKc/zC1tRxwmtRfZ4KQlB GZDw== X-Gm-Message-State: AOAM532jip+NsEgls21lASmz10RaGfgcdduF4mGIk71PnYKNKzLsh4QD ijy8H78U7OfHTuWKEt3URSA= X-Google-Smtp-Source: ABdhPJygSojkbPQ9T6nmuvpmWKE0eBxm5eOSmqhSZlDa5KHyWLaKpOYDGTp1qDvg6zbYeK2/pSW5Og== X-Received: by 2002:adf:d222:0:b0:206:17ba:5f76 with SMTP id k2-20020adfd222000000b0020617ba5f76mr11454903wrh.484.1649353339722; Thu, 07 Apr 2022 10:42:19 -0700 (PDT) Received: from [192.168.1.122] (cpc159313-cmbg20-2-0-cust161.5-4.cable.virginm.net. [82.0.78.162]) by smtp.gmail.com with ESMTPSA id y6-20020a05600015c600b00203fa70b4ebsm21873677wry.53.2022.04.07.10.42.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 10:42:19 -0700 (PDT) Subject: Re: [PATCH net-next 11/15] sfc: Remove usage of list iterator for list_add() after the loop body To: Jakob Koschel , "David S. Miller" Cc: Jakub Kicinski , Paolo Abeni , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Ariel Elior , Manish Chopra , Martin Habets , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Pirko , Casper Andersson , Bjarni Jonasson , Colin Ian King , Michael Walle , Christophe JAILLET , Arnd Bergmann , Eric Dumazet , Di Zhu , Xu Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." References: <20220407102900.3086255-1-jakobkoschel@gmail.com> <20220407102900.3086255-12-jakobkoschel@gmail.com> From: Edward Cree Message-ID: <4520e9c5-8871-b281-f621-ac737e64333b@gmail.com> Date: Thu, 7 Apr 2022 18:42:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20220407102900.3086255-12-jakobkoschel@gmail.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_104224_885026_455A9D78 X-CRM114-Status: GOOD ( 28.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDcvMDQvMjAyMiAxMToyOCwgSmFrb2IgS29zY2hlbCB3cm90ZToKPiBJbiBwcmVwYXJhdGlv biB0byBsaW1pdCB0aGUgc2NvcGUgb2YgYSBsaXN0IGl0ZXJhdG9yIHRvIHRoZSBsaXN0Cj4gdHJh dmVyc2FsIGxvb3AsIHVzZSBhIGRlZGljYXRlZCBwb2ludGVyIHRvIHBvaW50IHRvIHRoZSBmb3Vu ZCBlbGVtZW50IFsxXS4KPiAKPiBCZWZvcmUsIHRoZSBjb2RlIGltcGxpY2l0bHkgdXNlZCB0aGUg aGVhZCB3aGVuIG5vIGVsZW1lbnQgd2FzIGZvdW5kCj4gd2hlbiB1c2luZyAmcG9zLT5saXN0LiBT aW5jZSB0aGUgbmV3IHZhcmlhYmxlIGlzIG9ubHkgc2V0IGlmIGFuCj4gZWxlbWVudCB3YXMgZm91 bmQsIHRoZSBsaXN0X2FkZCgpIGlzIHBlcmZvcm1lZCB3aXRoaW4gdGhlIGxvb3AKPiBhbmQgb25s eSBkb25lIGFmdGVyIHRoZSBsb29wIGlmIGl0IGlzIGRvbmUgb24gdGhlIGxpc3QgaGVhZCBkaXJl Y3RseS4KPiAKPiBMaW5rOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvQ0FIay09d2dScl9E OENCLUQ5S2ctYz1FSHJlQXNrNVNxWFB3cjlZN2s5c0E2Y1dYSjZ3QG1haWwuZ21haWwuY29tLyBb MV0KPiBTaWduZWQtb2ZmLWJ5OiBKYWtvYiBLb3NjaGVsIDxqYWtvYmtvc2NoZWxAZ21haWwuY29t PgoKVGhlIGNvbW1pdCBtZXNzYWdlIGRvZXNuJ3QgYWNjdXJhdGVseSBkZXNjcmliZSB0aGUgcGF0 Y2g7IGl0IHN0YXRlcwogdGhhdCAidGhlIGxpc3RfYWRkKCkgaXMgcGVyZm9ybWVkIHdpdGhpbiB0 aGUgbG9vcCIsIHdoaWNoIGRvZXNuJ3QKIGFwcGVhciB0byBiZSB0aGUgY2FzZS4KQWxzbyBpdCBz ZWVtcyBhIGJpdCBzdWJ0bGUgdG8gdXNlIGBoZWFkYCBhcyBib3RoIHRoZSBoZWFkIG9mIHRoZQog bGlzdCB0byBpdGVyYXRlIG92ZXIgYW5kIHRoZSBmb3VuZCBlbnRyeS9nYXAgdG8gaW5zZXJ0IGJl Zm9yZTsgYQogY29tbWVudCBleHBsYWluaW5nIHRoYXQgd291bGRuJ3QgZ28gYW1pc3MuCihJJ2Qg cXVlc3Rpb24gd2hldGhlciB0aGlzIGNoYW5nZSBpcyByZWFsbHkgYW4gaW1wcm92ZW1lbnQgaW4g dGhpcwogY2FzZSwgd2hlcmUgdGhlIGl0ZXJhdG9yIHJlYWxseSBkb2VzIGhvbGQgdGhlIHRoaW5n IHdlIHdhbnQgYXQgdGhlCiBlbmQgb2YgdGhlIHNlYXJjaCBhbmQgc28gdGhlcmUncyBubyBpZihm b3VuZCkgc3BlY2lhbC1jYXNpbmcg4oCUCiB3ZSdyZSBub3QgZXZlbiBhYnVzaW5nIHRoZSB0eXBl IHN5c3RlbSwgYmVjYXVzZSBlZngtPnJzc19jb250ZXh0CiBpcyBvZiB0aGUgc2FtZSB0eXBlIGFz IGFsbCB0aGUgbGlzdCBlbnRyaWVzLCBzbyBjdHggcmVhbGx5IGlzIGEKIHZhbGlkIHBvaW50ZXIg YW5kIHRoZXJlIHNob3VsZG4ndCBiZSBhbnkgaXNzdWVzIHdpdGggc3BlY3VsYXRpdmUKIGFjY2Vz c2VzIG9yIHdoYXRldmVyIOKAlCBidXQgaXQgc2VlbXMgTGludXMgaGFzIGFscmVhZHkgcHJvbm91 bmNlZAogaW4gZmF2b3VyIG9mIHRoZSBzY29wZSBsaW1pdGluZywgYW5kIGZhciBiZSBpdCBmcm9t IG1lIHRvIGdhaW5zYXkKIGhpbS4pCgotZWQKCj4gLS0tCj4gIGRyaXZlcnMvbmV0L2V0aGVybmV0 L3NmYy9yeF9jb21tb24uYyB8IDYgKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVy bmV0L3NmYy9yeF9jb21tb24uYyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L3NmYy9yeF9jb21tb24u Ywo+IGluZGV4IDFiMjJjN2JlMDA4OC4uYTg4MjIxNTJmZjgzIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvbmV0L2V0aGVybmV0L3NmYy9yeF9jb21tb24uYwo+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVy bmV0L3NmYy9yeF9jb21tb24uYwo+IEBAIC01NjMsOCArNTYzLDEwIEBAIHN0cnVjdCBlZnhfcnNz X2NvbnRleHQgKmVmeF9hbGxvY19yc3NfY29udGV4dF9lbnRyeShzdHJ1Y3QgZWZ4X25pYyAqZWZ4 KQo+ICAKPiAgCS8qIFNlYXJjaCBmb3IgZmlyc3QgZ2FwIGluIHRoZSBudW1iZXJpbmcgKi8KPiAg CWxpc3RfZm9yX2VhY2hfZW50cnkoY3R4LCBoZWFkLCBsaXN0KSB7Cj4gLQkJaWYgKGN0eC0+dXNl cl9pZCAhPSBpZCkKPiArCQlpZiAoY3R4LT51c2VyX2lkICE9IGlkKSB7Cj4gKwkJCWhlYWQgPSAm Y3R4LT5saXN0Owo+ICAJCQlicmVhazsKPiArCQl9Cj4gIAkJaWQrKzsKPiAgCQkvKiBDaGVjayBm b3Igd3JhcC4gIElmIHRoaXMgaGFwcGVucywgd2UgaGF2ZSBuZWFybHkgMl4zMgo+ICAJCSAqIGFs bG9jYXRlZCBSU1MgY29udGV4dHMsIHdoaWNoIHNlZW1zIHVubGlrZWx5Lgo+IEBAIC01ODIsNyAr NTg0LDcgQEAgc3RydWN0IGVmeF9yc3NfY29udGV4dCAqZWZ4X2FsbG9jX3Jzc19jb250ZXh0X2Vu dHJ5KHN0cnVjdCBlZnhfbmljICplZngpCj4gIAo+ICAJLyogSW5zZXJ0IHRoZSBuZXcgZW50cnkg aW50byB0aGUgZ2FwICovCj4gIAluZXctPnVzZXJfaWQgPSBpZDsKPiAtCWxpc3RfYWRkX3RhaWwo Jm5ldy0+bGlzdCwgJmN0eC0+bGlzdCk7Cj4gKwlsaXN0X2FkZF90YWlsKCZuZXctPmxpc3QsIGhl YWQpOwo+ICAJcmV0dXJuIG5ldzsKPiAgfQo+ICAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==