Re: [PATCH] ARM: dts: stm32: Fill GPIO line names on AV96

From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Marek Vasut <marex@denx.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	Patrick Delaunay <patrick.delaunay@st.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Subject: Re: [PATCH] ARM: dts: stm32: Fill GPIO line names on AV96
Date: Fri, 12 Mar 2021 15:17:43 +0000	[thread overview]
Message-ID: <4530980295044f8ab9c1cfe14e02f90f@dh-electronics.com> (raw)
In-Reply-To: <495b2f6b-04b7-c1eb-7aed-cd55636bef46@denx.de>

From: Marek Vasut [mailto:marex@denx.de]
Sent: Thursday, August 6, 2020 9:30 AM

> On 8/6/20 9:09 AM, Christoph Niedermaier wrote:
>> From: Marek Vasut <marex@denx.de>
>> Sent: Friday, July 24, 2020 12:16 PM
>>>
>>> Fill in the custom GPIO line names used by DH.
>>>
>> [...]
>>> +&gpioa {
>>> +       gpio-line-names = "", "", "", "",
>>> +                         "", "", "", "",
>>> +                         "", "", "", "DH-GPIO-K",
>>> +                         "DH-GPIO-I", "", "DH-GPIO-A", "";
>>> +};
>>> +
>> [...]
>>
>> We have been using the GPIO names at DH electronics for some time and also
>> on other SOMs, but have not yet streamed them. We started with the naming
>> only with a capital letter "A-W" since then without problems. To avoid a
>> hard cut or patching for us and our customers it would be good if we could
>> use the same naming in the mainline kernel as well. Marek, we would be
>> happy if you would adopt our valued GPIO naming in your patch.
> 
> My counter-argument to this is that the naming should be unique and
> provide a hint where those GPIO lines come from, so maybe even DH-GPIO-n
> should rather be DHCOM-n . I can't say I'm particularly fond of the
> plain 'n' naming of GPIO lines, because then the GPIO label (and e.g.
> listing in libgpiod tools) does not give any hint what the GPIO is or
> where it comes from. Also, I worry a plain 'n' naming might clash with
> other GPIO IPs easily, while a more unique name can not.

Hello Marek,

after an internal discussion, we decided the following:

Could you update the patch for the Avenger96 to the GPIO naming "AV96-n".

Moreover for the SOM layer (stm32mp15xx-dhcom-som.dtsi) we would prefer
"DHCOM-n". It would be nice if you could create a patch for it.

Regards,
Christoph
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel