From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAEAAC4332F for ; Wed, 13 Dec 2023 19:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gueUhra3IRjkuv1ffIWOIdIUKPGiD92btv9jv09LZYU=; b=Tw1nzURn/uLc1e i8oNI1mjJwLqiN6IiyAAaZCcGNyprabc5zVNdCTCSCiQcu4GGw1F/oykAKYly9l9j2mxLAhbTpfPn vrzTFOiSm8QJnd27EMciWWtdq0HjSTJ8LbIr6es7VaaL3zw0Da5oJapd5xWWdqjxBmbljrqN5/jNi uoyVXNawh2KEag4otykEiaBsAs3/0rq0ilVEqGT4AADQV+Il2jig+hjO0KDgVdGElwchIs1DQUOX/ ArpEluMcji5NQM6V2YUsRxdy56as+Qc9bigUElJPRO5zVSj+JK276idBn/+5Wo0UK1GF5X7CmLSms I9g0n/89uxrejrLMz0ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDUp0-00Fp9v-1w; Wed, 13 Dec 2023 19:23:06 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDUox-00Fp9C-01 for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 19:23:05 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-336417c565eso679598f8f.3 for ; Wed, 13 Dec 2023 11:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702495378; x=1703100178; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=89i1OHXQJgIekZUdzaoOl/WPzNUPAmh4Shyy9X7oUY4=; b=eLm7sy8rggpA2pQQnL5suiHRcIWnD/DHNCgwsZEb/aPacSdQm4yHG1GeQUn4cZ3UdS Cv8D5H9qIKP6jlBzsm+qW5XV9awunqJfQI3JTK/bu9W4GcRrHOGoR6EBnWns7mi0rPbq 62/6lOoNsuNVNkVmy348HFWqg5XvwP/B0dQrSqiNcWw9I/Shpoi6Ejh+kDGeZ2Z9RsFA 6oISsOmlqpc/om85vEtNflMQD7Br++YJzkfwf3w9t96F6vMwwrMisLcGQOlhpPTEBf2+ AbVpWhdi5pHPZMl3sgHJI6z31R35rGSkfnaQ404U/U0H1oZ4dWD628GefVPfGle5XV6e a6mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702495378; x=1703100178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=89i1OHXQJgIekZUdzaoOl/WPzNUPAmh4Shyy9X7oUY4=; b=BBOb6ULC6KwoPKdq5vWBqAhOoENPAjqwPQA+dIXA4FRbhU0FENuY8opAWNtoohrsEM ZunLeRUX5kju3l2bfpa6Xr+LPCXku/rxD4DQzPLxXwaIxXtqawO7uBPOEDF4QMqD/sEL HMtcjML5X5CcLC0eIyLRIgyEDJsohX/+pVRVEaPzmycbH5JRa5Uavgr6vtMI+Fmm1ftC MWLlaQcBDOBayTa/ZCwFhyEVYB6L/2eG46KPJRYrXyKO9R4y9DsLaREVfLVYYh9EQFQl xORbEFmo4sQs1pc/94fqCb43ck2ykWZrjXIrT4EXxra0mG8XYu35v9Hq4Q40JrAfQNap TuUg== X-Gm-Message-State: AOJu0YwbVe2q3Q0nlV/Z33K6eWnaNnC+wUqvON1kRM3nnRQfrx7QpawU iUdELp6y/fMIRp+Z4Zele0w= X-Google-Smtp-Source: AGHT+IFcZKcfAVcsQKDAtqomxNhsXvBOqj2C0qfAQJcS/u+Cqm3nCQMDR0fiNd6YdrV8nk7TJFFkig== X-Received: by 2002:adf:e64d:0:b0:336:38ef:f4ec with SMTP id b13-20020adfe64d000000b0033638eff4ecmr541429wrn.28.1702495377445; Wed, 13 Dec 2023 11:22:57 -0800 (PST) Received: from archlinux.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id c11-20020a5d414b000000b0033342f72bf8sm14153283wrq.9.2023.12.13.11.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 11:22:56 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Andre Przywara Cc: Icenowy Zheng , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 3/3] arm64: dts: allwinner: h618: add Transpeed 8K618-T TV box Date: Wed, 13 Dec 2023 20:22:55 +0100 Message-ID: <4533903.LvFx2qVVIh@archlinux> In-Reply-To: <20231212010859.11571-4-andre.przywara@arm.com> References: <20231212010859.11571-1-andre.przywara@arm.com> <20231212010859.11571-4-andre.przywara@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_112303_052931_81E27FA9 X-CRM114-Status: GOOD ( 22.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andre! On Tuesday, December 12, 2023 2:08:59 AM CET Andre Przywara wrote: > This is a Chinese TV box, probably very similar if not identical to > various other cheap TV boxes with the same specs: > - Allwinner H618 SoC (4 * Arm Cortex-A53 cores, 1MB L2 cache) > - 2 or 4GiB DDR3L DRAM > - 32, 64, or 128 GiB eMMC flash > - AXP313a PMIC > - 100 Mbit/s Ethernet (using yet unsupported internal PHY) > - HDMI port > - 2 * USB 2.0 ports > - microSD card slot > - 3.5mm A/V port > - 7-segment display > - 5V barrel plug power supply > > The PCB provides holes for soldering a UART header or cable, this is > connected to the debug UART0. UART1 is used for the Bluetooth chip, > although this isn't working yet. > > Signed-off-by: Andre Przywara > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../sun50i-h618-transpeed-8k618-t.dts | 164 ++++++++++++++++++ > 2 files changed, 165 insertions(+) > create mode 100644 > arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile > b/arch/arm64/boot/dts/allwinner/Makefile index 3aca6787a1679..91d505b385de5 > 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -43,3 +43,4 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-transpeed-8k618-t.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts > b/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts new file > mode 100644 > index 0000000000000..fd7ea7bcde2c1 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts > @@ -0,0 +1,164 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (C) 2023 Arm Ltd. > + */ > + > +/dts-v1/; > + > +#include "sun50i-h616.dtsi" > + > +#include > +#include > + > +/ { > + model = "Transpeed 8K618-T"; > + compatible = "transpeed,8k618-t", "allwinner,sun50i-h618"; > + > + aliases { > + serial0 = &uart0; > + serial1 = &uart1; Any particular reason for above alias? > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + reg_vcc5v: vcc5v { > + /* board wide 5V supply directly from the DC input */ > + compatible = "regulator-fixed"; > + regulator-name = "vcc-5v"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; > + > + reg_vcc3v3: vcc3v3 { > + /* discrete 3.3V regulator */ > + compatible = "regulator-fixed"; > + regulator-name = "vcc-3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&ir { > + status = "okay"; > +}; > + > +&mmc0 { > + vmmc-supply = <®_dldo1>; > + cd-gpios = <&pio 8 16 GPIO_ACTIVE_LOW>; /* PI16 */ > + bus-width = <4>; > + status = "okay"; > +}; > + > +&mmc2 { > + vmmc-supply = <®_dldo1>; > + vqmmc-supply = <®_aldo1>; > + bus-width = <8>; > + non-removable; > + cap-mmc-hw-reset; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + status = "okay"; > +}; > + > +&ohci0 { > + status = "okay"; > +}; > + > +&ohci1 { > + status = "okay"; > +}; > + > +&r_i2c { > + status = "okay"; > + > + axp313: pmic@36 { > + compatible = "x-powers,axp313a"; > + reg = <0x36>; > + #interrupt-cells = <1>; > + interrupt-controller; > + > + vin1-supply = <®_vcc5v>; > + vin2-supply = <®_vcc5v>; > + vin3-supply = <®_vcc5v>; > + > + regulators { > + /* Supplies VCC-PLL, so needs to be always on. */ > + reg_aldo1: aldo1 { > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "vcc1v8"; It would be great to expand all PMIC regulator names with (known) areas they power, so something like "vcc1v8-pll-pc". With that, I think you can remove comments. Best regards, Jernej > + }; > + > + /* Supplies VCC-IO, so needs to be always on. */ > + reg_dldo1: dldo1 { > + regulator-always-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc3v3"; > + }; > + > + reg_dcdc1: dcdc1 { > + regulator-always-on; > + regulator-min-microvolt = <810000>; > + regulator-max-microvolt = <990000>; > + regulator-name = "vdd-gpu-sys"; > + }; > + > + reg_dcdc2: dcdc2 { > + regulator-always-on; > + regulator-min-microvolt = <810000>; > + regulator-max-microvolt = <1100000>; > + regulator-name = "vdd-cpu"; > + }; > + > + reg_dcdc3: dcdc3 { > + regulator-always-on; > + regulator-min-microvolt = <1360000>; > + regulator-max-microvolt = <1360000>; > + regulator-name = "vdd-dram"; > + }; > + }; > + }; > +}; > + > +&pio { > + vcc-pc-supply = <®_aldo1>; > + vcc-pg-supply = <®_dldo1>; > + vcc-ph-supply = <®_dldo1>; > + vcc-pi-supply = <®_dldo1>; > +}; > + > +&uart0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_ph_pins>; > + status = "okay"; > +}; > + > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; > + uart-has-rtscts; > + status = "okay"; > +}; > + > +&usbotg { > + dr_mode = "host"; /* USB A type receptable */ > + status = "okay"; > +}; > + > +&usbphy { > + status = "okay"; > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel