Re: [PATCH 6/6] drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER

From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Liu Ying <victor.liu@nxp.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] drm/bridge: dpu-core: Don't print error on -EPROBE_DEFER
Date: Mon, 18 Dec 2023 13:03:20 +0100	[thread overview]
Message-ID: <4536196.LvFx2qVVIh@steina-w> (raw)
In-Reply-To: <20231218105718.2445136-7-alexander.stein@ew.tq-group.com>

Am Montag, 18. Dezember 2023, 11:57:18 CET schrieb Alexander Stein:
> -517 errors are just annoying. dev_err_probe can't be used here either
> as this would hide the error message already set in us->init.

Please ignore. I just noticed this file is added in a locally applied series.

Thanks
Alexander

> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/gpu/drm/imx/dpu/dpu-core.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imx/dpu/dpu-core.c
> b/drivers/gpu/drm/imx/dpu/dpu-core.c index d6116b3e4ed7..ea2558a14a6c
> 100644
> --- a/drivers/gpu/drm/imx/dpu/dpu-core.c
> +++ b/drivers/gpu/drm/imx/dpu/dpu-core.c
> @@ -592,9 +592,10 @@ static int dpu_submodules_init(struct dpu_soc *dpu,
> unsigned long dpu_base) ret = us->init(dpu, j, us->ids[j], us->types[j],
>  				       pec_ofs, dpu_base + us-
>ofss[j]);
>  			if (ret) {
> -				dev_err(dpu->dev,
> -					"failed to initialize %s%d: 
%d\n",
> -						us->name, us-
>ids[j], ret);
> +				if (ret != -EPROBE_DEFER)
> +					dev_err(dpu->dev,
> +						"failed to 
initialize %s%d: %d\n",
> +							us-
>name, us->ids[j], ret);
>  				return ret;
>  			}
>  		}

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel