From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC53C43381 for ; Wed, 13 Mar 2019 10:57:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AB7820449 for ; Wed, 13 Mar 2019 10:57:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ElRDgh34" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AB7820449 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5iw0+cLowyOKgMEtGKqfcCUHK3QbE11ltL48Wr+WFUc=; b=ElRDgh34/HWebI 3cQt6W1xf6dA4P5enTLMePH7QyBF6cneQIWK3WZSaZvfM1ZZn/sNI7Di6ZJYIMq7E/aWCtCUaM+mi fZ929uOsR5i3Hmbi4V9RYznIpq1Z+3Yii2knY4Z1LAIiHoVmnMHOF6A8lOIa04Hdvyy9M0wm7ijFq P46JCTuSwloGKN1rqeGxBk+T1xIOHIFh6kYVLJbF+tRbmjlh9puK9dYnoGCZgdqMvI1/zUVw0YRxq QuRJ0YyGtlxynv5RV0jDnz7gH5JFP6521VrouPZNQYyQJm6pIWOoU1HBdjBzS6k6/3DqVrJ2Y7AuR 8EETsi0U9YAFEhPum4uw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h41ZM-00078F-JS; Wed, 13 Mar 2019 10:57:08 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h41ZH-0006uf-Bo; Wed, 13 Mar 2019 10:57:05 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h41ZD-00080d-Au; Wed, 13 Mar 2019 11:56:59 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: David Summers Subject: Re: [PATCH v3 3/3] arm: dts: rk3288-tinker.dtsi: Add outline Bluetooth support Date: Wed, 13 Mar 2019 11:56:58 +0100 Message-ID: <4537885.W6WcYDDAQ4@diego> In-Reply-To: <20190309153923.22806-3-beagleboard@davidjohnsummers.uk> References: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> <20190309153923.22806-1-beagleboard@davidjohnsummers.uk> <20190309153923.22806-3-beagleboard@davidjohnsummers.uk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_035703_559897_58E73D94 X-CRM114-Status: GOOD ( 18.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, marcel@holtmann.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David, Am Samstag, 9. M=E4rz 2019, 16:39:23 CET schrieb David Summers: > This patch is an outline for bluetooth on the ASUS Tinker Board (S). > = > Bluetooth is provided my RTL8723BS on these machine, and this is wired > into UART0. > = > Here this is performed as a SerDev device. > = > Now as presented, this does not give functioning bluetooth. The > updates needed to the device driver: > = > https://www.spinics.net/lists/linux-bluetooth/msg78661.html > = > Haven't yet been accepted. So this device tree hook doesn't yet have > "realtek,rtl8723bs-bt" compatible flag. > = > It is however still submitted as a patch, as it sets the UART up > correctly. And so basic communciation can be had with the device. This > has been confirmed by Tony McKahan @ Armbian, in particular that the > CTS/RTS is needed. > = > When Vasily patch is accepted, this will be added as a minor patch on > top of this patch; as this patch gives the pins needed. > = > The one oddity, is the RESET pin, it is labeled this way on the > schematic. However the hci_h5.c driver calls this ENABLE. Here we have > stuck with the schematic name. > = > Signed-off-by: David Summers > --- > arch/arm/boot/dts/rk3288-tinker.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > = > diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi > b/arch/arm/boot/dts/rk3288-tinker.dtsi index 0ffab1b7c940..d29f5b34d7e6 > 100644 > --- a/arch/arm/boot/dts/rk3288-tinker.dtsi > +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi > @@ -486,6 +486,17 @@ > = > &uart0 { > status =3D "okay"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&uart0_xfer>, <&uart0_cts>, <&uart0_rts>; > + > + bluetooth { > + clocks =3D <&rk808 RK808_CLKOUT1>; > + reset-gpios =3D <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>; > + device-wake-gpios =3D <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; > + host-wake-gpios =3D <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; > + vcc-18-supply =3D <&vcc_18>; > + vcc-io-supply =3D <&vcc_io>; > + }; As this is supposed to work as serial attached device it should follow a dt-binding, so first of all definitly needs a compatible and a binding specifying all the properties declared above. See for example Documentation/devicetree/bindings/net/broadcom-bluetooth.txt for a similar device. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel