From: Felix Fietkau <nbd@nbd.name>
To: Colin King <colin.king@canonical.com>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mt76: make const array 'data' static, shrinks object size
Date: Mon, 31 Dec 2018 15:41:21 +0100 [thread overview]
Message-ID: <453b64e0-220e-69a8-c855-51903707a88b@nbd.name> (raw)
In-Reply-To: <20181230132640.6916-1-colin.king@canonical.com>
On 2018-12-30 14:26, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array 'data' on the stack but instead
> make it static. Makes the object code smaller by 78 bytes:
>
> Before:
> text data bss dec hex filename
> 5438 1080 0 6518 1976 mediatek/mt76/mt76x2/usb_mcu.o
>
> After:
> text data bss dec hex filename
> 5296 1144 0 6440 1928 mediatek/mt76/mt76x2/usb_mcu.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
- Felix
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-12-31 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 13:26 [PATCH] mt76: make const array 'data' static, shrinks object size Colin King
2018-12-31 14:41 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453b64e0-220e-69a8-c855-51903707a88b@nbd.name \
--to=nbd@nbd.name \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox