From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1DB1C48BC1 for ; Wed, 14 Feb 2024 18:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PeFuqcsXrzU9+zqxPWivOqI7zyxQtHFLfv74bHqT6vI=; b=1FldPEb107fA25 OzXZdVR8Xl4SpybvOUeYSLx1vGxiYQm6tgOnVLskk+z5LZJigNP0YQ/AgDohpTvuViUwiGtyPrnAv 8ZuIHOaXIVa3yEu9rNOXFNMPq/RJz9+BhdCoLK+9AD6NMHMw/+33AkYFsLhK0zh4cFwp2I67Mcud4 fLftdCWFpEMUgb7pEmJ8qpVDIF1uMtmqplpxaJka+qmvnG/FqBy2i5xwmA+h0bNRGwB73kJt978Eu JFWsHvjltq7zWoC+iyJsuFU/KLT6YwV/4Wlb6TOIoRIsoYY19J3sweNlzV4kEytZne0am7DMBjMJ+ 5KToONzC9Dhg4Q261yug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raJrn-0000000Dult-2bru; Wed, 14 Feb 2024 18:20:19 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raJrk-0000000DulX-33D9 for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2024 18:20:17 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5638c4a8c92so51122a12.2 for ; Wed, 14 Feb 2024 10:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707934815; x=1708539615; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PP34yk7oOynea6CHC1QRC9Iv8jbmZngNsL/j60HriD0=; b=L5sTSTIL5cdLR5ObE4RRASu8mLqGv9PrFaWyY9kG9eUTjnTDjVW9i/bE0RaPF8xH/c TRpjQXHsCgKA1t70m/v7WEoRS6a7Rc3ao6ilMhmIP2vvhcYVB4GMlkOprOqzb30eeB04 37fVIKN9KJ1Yj0W75DcjPvHBPSjlGww5DPWiU20iluJ7cpxTWh6P+E+L8o4qNDn+Swj+ FF0sCwhlWulLEZOkdrLgunTnCImElJHW5GO01Qp1Xjrl9+PyKbSi88hwEOrTzjFNmIiI tyUfxNmi+58VS+KDL8fwD8+E+6JHLDkeC9/poOxqamQo0C1SD5P4tYcBdOHHuOQ/W0FB AJNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707934815; x=1708539615; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PP34yk7oOynea6CHC1QRC9Iv8jbmZngNsL/j60HriD0=; b=R7SQiMGchSgDqKJhZdAQFMdQRbqyoyUaOIQyLwN16Y6g8i16XXn4N2sVVPdFkMydqD iwSPRNrj13qToRU+MRbM+Yy5xGYfnqAY3j/pY6SX3l0e9QaGLkPMGjo6C4b6zKQ99nIR GhuQa5u9DA6W5wp9qs1AEpe4DEOvh6alngOi3p0pmyLBSWVOZEjBJSEOl/Gm6eHtA25M GtXcH9HkIGP0X8VQ4BdwQvnJFTbf0vPRxnzxYChMHH4TzN9nruF+cCu2FZQ/6wDXhJ3u I6x9HFIVlWQRztAhXlr59MzmvPS3T9b/KrBQugjxkEOHsRfe2lhxWgvVqOybIqjx4GM8 NM3A== X-Gm-Message-State: AOJu0YytAzrfwAVzuFdrUYiI4rn+wGzYIc3oe8sgBnq/ESe9JyigK/Cr BCB523r3q/89oI2uR3qZWHp+pf2sqITS8gz8N8a62Kxwfo1lJx3F X-Google-Smtp-Source: AGHT+IHnl9vWIq4jk4P+8F4sKWK9iouX4C7uaxoER6CmvE8w4g4daaknDkYKDzjBwh7BvsWl3eDs0g== X-Received: by 2002:a05:6402:1491:b0:55f:8031:501c with SMTP id e17-20020a056402149100b0055f8031501cmr3013556edv.30.1707934814830; Wed, 14 Feb 2024 10:20:14 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVx62rDzQzEZiuxkrVw4ugxvFbYR4hlccvTZbHwZVz3CRI3rBVRL7EVVoTfug+sBTg0nVyW5zVYC4NuXtu5axN6lqvQvzAu7I3JsfxWKWCkhPGDS/ViG/3zxsws3dWI/W39vzETKNnibqVjPXj7l/GBKvOWoiNkJ8vxJFIdcc3lw5qAYxfMuVSsQp2SuD6Yj99TY8sDx5fif2INN+47mrfdVO1IWbs0sWDmK8u3ax8lBvfB Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id p2-20020a056402044200b0056200715130sm1534672edw.54.2024.02.14.10.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 10:20:14 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland , linux-pwm@vger.kernel.org, Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH v6 126/164] pwm: sun4i: Consistently name driver data sun4ichip Date: Wed, 14 Feb 2024 19:20:12 +0100 Message-ID: <4544997.LvFx2qVVIh@jernej-laptop> In-Reply-To: <705f54a13b59fff50eaa345d8b1e0c691345b996.1707900770.git.u.kleine-koenig@pengutronix.de> References: <705f54a13b59fff50eaa345d8b1e0c691345b996.1707900770.git.u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_102016_791489_357E175E X-CRM114-Status: UNSURE ( 7.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 14. februar 2024 ob 10:32:53 CET je Uwe Kleine-K=F6nig napisal(a= ): > The driver uses three different names for variables of type > sun4i_pwm_chip: > = > $ git grep 'struct sun4i_pwm_chip \*' v6.8-rc1 -- drivers/pwm/pwm-sun4i.c > v6.8-rc1:drivers/pwm/pwm-sun4i.c:static inline struct sun4i_pwm_chip *to= _sun4i_pwm_chip(struct pwm_chip *chip) > v6.8-rc1:drivers/pwm/pwm-sun4i.c:static inline u32 sun4i_pwm_readl(struc= t sun4i_pwm_chip *chip, > v6.8-rc1:drivers/pwm/pwm-sun4i.c:static inline void sun4i_pwm_writel(str= uct sun4i_pwm_chip *chip, > v6.8-rc1:drivers/pwm/pwm-sun4i.c: struct sun4i_pwm_chip *sun4i_pwm= =3D to_sun4i_pwm_chip(chip); > v6.8-rc1:drivers/pwm/pwm-sun4i.c:static int sun4i_pwm_calculate(struct s= un4i_pwm_chip *sun4i_pwm, > v6.8-rc1:drivers/pwm/pwm-sun4i.c: struct sun4i_pwm_chip *sun4i_pwm= =3D to_sun4i_pwm_chip(chip); > v6.8-rc1:drivers/pwm/pwm-sun4i.c: struct sun4i_pwm_chip *sun4ichip; > v6.8-rc1:drivers/pwm/pwm-sun4i.c: struct sun4i_pwm_chip *sun4ichip= =3D platform_get_drvdata(pdev); > = > "chip" is usually reserved for variables of type struct pwm_chip. So > pick sun4ichip as common name which better matches the type name than > sun4i_pwm. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel