From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D2CCC3065C for ; Thu, 4 Jul 2024 10:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nbtdIyJBiOp9AfiI4+dqy+Q6DAAX2lLpDkHHdC3GCuw=; b=4utNZqmnj+Z0fcfQgFehggdnVZ mr++vR1zslC6mmlmbFaKmu8SjXMj+5OFs+IXPueh1p/uE3o20PIV5k25d5fJNwDwC5MDhHVk56qnO li5Hr4dQUSRZHS8A9hDpqio2/W5tkgUpMW++ZtJfJdK+cMkQHmTr3szaGeGjZgHvPYIEdsFttnsNJ ZQu4f6XvN6vJvN5oSNZ3dGLeQdAGRWjqrobd3QExHz34V4/Ek5sB4t9l5xO0CxgzjYn/irHeiWswo f/Ga47uKqYf8hqWJ9H6sgTAIVrKstx9Zq4MkX3VQmuk0z5jqmp5FBICuyONmsuenZleMoFv55WJwh rvaSaMQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPJLF-0000000CpFN-34ne; Thu, 04 Jul 2024 10:05:29 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPJL2-0000000CpC5-1UhV; Thu, 04 Jul 2024 10:05:17 +0000 Received: from i53875ac2.versanet.de ([83.135.90.194] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sPJKx-0007cl-E2; Thu, 04 Jul 2024 12:05:11 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-rockchip@lists.infradead.org, Diederik de Haas Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board Date: Thu, 04 Jul 2024 12:05:10 +0200 Message-ID: <4552794.8F6SAcFxjW@diego> In-Reply-To: <2278169.QnsP76Vvrg@bagend> References: <20240703210524.776455-1-heiko@sntech.de> <20240703210524.776455-3-heiko@sntech.de> <2278169.QnsP76Vvrg@bagend> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_030516_556337_43A35B80 X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Diederik, Am Donnerstag, 4. Juli 2024, 11:38:51 CEST schrieb Diederik de Haas: > Thanks for submitting this. A quick scan indicates it should work with a > (recent) Debian kernel OOTB :-) > > On Wednesday, 3 July 2024 23:05:24 CEST Heiko Stuebner wrote: > > +&sdhci { > > + bus-width = <8>; > > + no-sdio; > > + no-sd; > > + non-removable; > > + max-frequency = <200000000>; > > + mmc-hs400-1_8v; > > + mmc-hs400-enhanced-strobe; > > + mmc-hs200-1_8v; > > + status = "okay"; > > +}; > > + > > +&sdmmc { > > + max-frequency = <200000000>; > > + no-sdio; > > + no-mmc; > > + bus-width = <4>; > > + cap-mmc-highspeed; > > + cap-sd-highspeed; > > + disable-wp; > > + sd-uhs-sdr104; > > + vmmc-supply = <&vcc_3v3_s3>; > > + vqmmc-supply = <&vccio_sd_s0>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_det>; > > + status = "okay"; > > +}; > > + > > +/* M.2 E-KEY */ > > +&sdio { > > + broken-cd; > > + bus-width = <4>; > > + cap-sdio-irq; > > + disable-wp; > > + keep-power-in-suspend; > > + max-frequency = <150000000>; > > + mmc-pwrseq = <&sdio_pwrseq>; > > + no-sd; > > + no-mmc; > > + non-removable; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&sdiom0_pins>; > > + sd-uhs-sdr104; > > + vmmc-supply = <&vcc3v3_ekey>; > > + status = "okay"; > > +}; > > + > > +&sfc { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&fspim2_pins>; > > + status = "okay"; > > Shouldn't those properties be sorted alphabetically? Or at least consistently? > Note that the same issue is present on other places too, but I believe the > above quoted part shows the issue enough. The main sorting is - compatible - reg [... alphabetically ...] - status But now that I look at it, you're right there are some non-alphabetical shenanigans going on there in the sdmmc and sdhci nodes ;-) Heiko