From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
Date: Thu, 19 Nov 2015 17:35:14 +0100 [thread overview]
Message-ID: <4559060.7YuVHsgd4d@wuerfel> (raw)
In-Reply-To: <20151119161843.GA8644@n2100.arm.linux.org.uk>
On Thursday 19 November 2015 16:18:43 Russell King - ARM Linux wrote:
> On Thu, Nov 19, 2015 at 12:25:45PM +0100, Arnd Bergmann wrote:
> > On Thursday 19 November 2015 03:40:25 Chen Gang wrote:
> > > diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h
> > > index 37d1fe2..67cfb7d 100644
> > > --- a/include/asm-generic/page.h
> > > +++ b/include/asm-generic/page.h
> > > @@ -24,9 +24,6 @@
> > >
> > > #ifndef __ASSEMBLY__
> > >
> > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL)
> > > -#define free_user_page(page, addr) free_page(addr)
> > > -
> > > #define clear_page(page) memset((page), 0, PAGE_SIZE)
> > > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE)
> > >
> > >
> >
> > Looks good. I can take the asm-generic portion when you split it up, and
> > I can also help you merge the remaining patches in case some of
> > the arch maintainers fail to pick them up. I think all five of them
> > are actively maintained though, so the patches should just go through
> > the respective architecture trees.
>
> Or we just ack the patch and have it go through one tree, which I think
> is the most sensible. I can't imagine that there would be any major
> conflicts here, surely no one is constantly changing their asm/page.h ?
Yes, good point, there is really very little potential for conflicts
here. I've applied it into my asm-generic tree for now, but will
revert it if we get regressions or NAKs.
For some reason, the patch was whitespace broken, but I managed to
extract it from the attachment.
Arnd
next prev parent reply other threads:[~2015-11-19 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 19:40 [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page Chen Gang
2015-11-19 0:11 ` Russell King - ARM Linux
2015-11-19 6:14 ` Vineet Gupta
2015-11-19 11:25 ` Arnd Bergmann
2015-11-19 16:18 ` Russell King - ARM Linux
2015-11-19 16:35 ` Arnd Bergmann [this message]
2015-11-19 18:59 ` Chen Gang
2015-11-20 12:15 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4559060.7YuVHsgd4d@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).