From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE
Date: Tue, 09 Feb 2016 16:26:38 +0100 [thread overview]
Message-ID: <4571887.rTPndCnv20@wuerfel> (raw)
In-Reply-To: <1455030539-10798-1-git-send-email-linux@roeck-us.net>
On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote:
> IS_ERR_VALUE() assumes that its parameter is an unsigned long.
> It can not be used to check if an unsigned int reflects an error.
> Doing so can result in the following build warning.
>
> drivers/tty/serial/digicolor-usart.c: In function ?digicolor_uart_probe?:
> include/linux/err.h:21:38: warning:
> comparison is always false due to limited range of data type
> drivers/tty/serial/digicolor-usart.c:485:6: note:
> in expansion of macro ?IS_ERR_VALUE?
>
> If that warning is seen, an error return from platform_get_irq() is missed.
>
>
The patch looks correct to me, but what compiler version and which kernel
tree is it that triggered the warning?
Andrzej Hajda just modified the definition of IS_ERR_VALUE(), and the
changes are still under discussion, but I don't see that warning with
any of the versions.
Arnd
next prev parent reply other threads:[~2016-02-09 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 15:08 [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE Guenter Roeck
2016-02-09 15:26 ` Arnd Bergmann [this message]
2016-02-10 2:37 ` Guenter Roeck
2016-02-10 15:21 ` Arnd Bergmann
2016-02-11 3:38 ` Guenter Roeck
2016-02-11 6:45 ` Andrzej Hajda
2016-02-11 15:32 ` Guenter Roeck
2016-02-12 6:38 ` Andrzej Hajda
2016-02-11 10:46 ` Russell King - ARM Linux
2016-02-11 15:13 ` Guenter Roeck
2016-02-11 6:50 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4571887.rTPndCnv20@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox