public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: CFT: move outer_cache_sync() out of line
Date: Tue, 13 Jan 2015 17:34:05 +0100	[thread overview]
Message-ID: <4576899.a2tdJxHBKo@wuerfel> (raw)
In-Reply-To: <20150112163648.GL12302@n2100.arm.linux.org.uk>

On Monday 12 January 2015 16:36:48 Russell King - ARM Linux wrote:

> Theoretically, this should help overall system performance, since the
> branch predictor should be able to predict this better, but it's entirely
> possible that trying to benchmark a single workload won't be measurably
> different.
> 
> In terms of kernel size figures, this change alone saves almost 17K of
> 10MB of kernel text on my iMX6 kernels - which is bordering on
> insignificant since that's not quite a 0.2% saving.
> 
> So... right now I can't justify this change, but I'm hoping some can come
> up with some figures which shows that it benefits their workload without
> causing a performance regression for others.

>From the theory, I think it can only help to do this. I would guess that
the time spent inside of the cache_sync function dwarfs both the extra
unconditional branch you introduce and the possible misprediction, so
17K in space savings sounds like more than enough justification to just
do it.

Acked-by: Arnd Bergmann <arnd@arndb.de>

      parent reply	other threads:[~2015-01-13 16:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 16:36 CFT: move outer_cache_sync() out of line Russell King - ARM Linux
2015-01-13  6:48 ` Jisheng Zhang
2015-01-13 15:45 ` Catalin Marinas
2015-01-13 16:27   ` Russell King - ARM Linux
2015-01-13 17:09     ` Russell King - ARM Linux
2015-01-13 18:39       ` Catalin Marinas
2015-01-13 16:34 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4576899.a2tdJxHBKo@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox