From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: rockchip: power-domain: remove PM clocks
Date: Wed, 28 Feb 2018 12:59:14 +0100 [thread overview]
Message-ID: <4580848.piTrlVmp9H@diego> (raw)
In-Reply-To: <20180228111113.13639-1-jeffy.chen@rock-chips.com>
Hi Jeffy,
Am Mittwoch, 28. Februar 2018, 12:11:13 CET schrieb Jeffy Chen:
> Currently we are adding all of the attached devices' clocks as pm clocks
> and enable them when powering on the power domain.
>
> This seems unnecessary, because those clocks are already controlled in
> the devices' drivers with better error handling.
>
> Tested on my chromebook minnie(rk3288) and chromebook kevin(rk3399).
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Looks ok to me and does not seem to interfere with the synchronous
reset that still stays intact.
@Ceasar: any objections?
Heiko
next prev parent reply other threads:[~2018-02-28 11:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 11:11 [PATCH] soc: rockchip: power-domain: remove PM clocks Jeffy Chen
2018-02-28 11:59 ` Heiko Stübner [this message]
2018-02-28 12:17 ` Geert Uytterhoeven
2018-02-28 12:29 ` Tomasz Figa
2018-02-28 12:32 ` Geert Uytterhoeven
2018-02-28 12:49 ` Tomasz Figa
2018-02-28 13:11 ` Geert Uytterhoeven
2018-02-28 14:07 ` Tomasz Figa
2018-03-01 3:40 ` JeffyChen
2018-03-01 8:33 ` Geert Uytterhoeven
2018-03-01 9:09 ` JeffyChen
2018-03-01 10:18 ` Ulf Hansson
2018-03-01 10:37 ` Geert Uytterhoeven
2018-03-01 11:22 ` Ulf Hansson
2018-03-01 11:54 ` Geert Uytterhoeven
2018-02-28 12:36 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4580848.piTrlVmp9H@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).