From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Łukasz Majewski" <lukma@nabladev.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Daniel Baluta <daniel.baluta@nxp.com>,
Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: trivial-devices: Add National lm77 temperature sensor
Date: Fri, 13 Nov 2026 13:43:33 +0100 [thread overview]
Message-ID: <45881f93-3f30-49e4-98cb-677814b85664@kernel.org> (raw)
In-Reply-To: <20261113132231.631638ad@wsk>
On 13/11/2026 13:22, Łukasz Majewski wrote:
> Hi Krzysztof,
>
>> On 13/11/2026 12:09, Łukasz Majewski wrote:
>>> Hi Krzysztof,
>>>
>>>> On Thu, Nov 12, 2026 at 05:37:02PM +0100, Lukasz Majewski wrote:
>>>>> Add "national,lm77" as compatible for the National (now TI) LM77
>>>>> digital I2C temperature sensor.
>>>>
>>>> Are you sure this is a trivial device, not like LM75? No
>>>> interrupts, no VS supply? Datasheet disagrees.
>>>
>>> In my case the T_CRIT_A and INT are not connected on the schematic.
>>> Moreover, the V+ is connected to board's 3V3.
>>
>> But they are there and binding should be complete.
>> What's more,
>> existing lm75 binding does not require these so there is no issue
>> adding to the existing binding file.
>
> Please be aware that internal operation of lm77 is a different than
> lm75 and hence it has its own Linux driver.
>
> It seems like I cannot re-use the lm75.yaml and will need to add new
> national,lm77.yaml as lm77 has two interrupt outputs for hysteresis
> (lm75 has only one interrupt).
Can be a new binding file, "national,lm77.yaml". Indeed it looks like it
has two lines, unlike 75 variant.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-13 12:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 16:37 [PATCH v2 1/3] dt-bindings: arm: fsl: Add an entry for Cloos CBASE board Lukasz Majewski
2026-11-12 16:37 ` [PATCH v2 2/3] dt-bindings: trivial-devices: Add National lm77 temperature sensor Lukasz Majewski
2026-11-13 10:11 ` Krzysztof Kozlowski
2026-11-13 11:09 ` Łukasz Majewski
2026-11-13 11:20 ` Krzysztof Kozlowski
2026-11-13 12:22 ` Łukasz Majewski
2026-11-13 12:43 ` Krzysztof Kozlowski [this message]
2026-11-12 16:37 ` [PATCH v2 3/3] arm64: dts: freescale: Add device tree definition for Cloos CBASE with i.MX8MM Lukasz Majewski
2026-11-12 17:36 ` Frank Li
2026-11-13 10:11 ` [PATCH v2 1/3] dt-bindings: arm: fsl: Add an entry for Cloos CBASE board Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45881f93-3f30-49e4-98cb-677814b85664@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jonathan.cameron@oss.qualcomm.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukma@nabladev.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox