* [RESEND][PATCH] arm: s3c: use string choices helper
@ 2025-08-06 23:20 Kuninori Morimoto
2025-08-07 5:55 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2025-08-06 23:20 UTC (permalink / raw)
To: Alim Akhtar, Krzysztof Kozlowski, Russell King, linux-arm-kernel; +Cc: patches
We can use string choices helper, let's use it.
It also tidyup printk(KERN_INFO, ...) to pr_info(...).
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
KernelVersion: v6.17
arch/arm/mach-s3c/pm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-s3c/pm.c b/arch/arm/mach-s3c/pm.c
index 5698cbceaf7a..e4c240699d14 100644
--- a/arch/arm/mach-s3c/pm.c
+++ b/arch/arm/mach-s3c/pm.c
@@ -46,8 +46,7 @@ int s3c_irqext_wake(struct irq_data *data, unsigned int state)
if (!(s3c_irqwake_eintallow & bit))
return -ENOENT;
- printk(KERN_INFO "wake %s for irq %d\n",
- state ? "enabled" : "disabled", data->irq);
+ pr_info("wake %s for irq %d\n", str_enabled_disabled(state), data->irq);
if (!state)
s3c_irqwake_eintmask |= bit;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND][PATCH] arm: s3c: use string choices helper
2025-08-06 23:20 [RESEND][PATCH] arm: s3c: use string choices helper Kuninori Morimoto
@ 2025-08-07 5:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-07 5:55 UTC (permalink / raw)
To: Kuninori Morimoto, Alim Akhtar, Russell King, linux-arm-kernel; +Cc: patches
On 07/08/2025 01:20, Kuninori Morimoto wrote:
> We can use string choices helper, let's use it.
> It also tidyup printk(KERN_INFO, ...) to pr_info(...).
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Same review as last time.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-07 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-06 23:20 [RESEND][PATCH] arm: s3c: use string choices helper Kuninori Morimoto
2025-08-07 5:55 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).