From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7341C4338F for ; Thu, 5 Aug 2021 13:42:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72FA96113B for ; Thu, 5 Aug 2021 13:42:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 72FA96113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X7CDmvYbcKtoncoEaBF7NCRCTiTu5cYx52vlJiTSpYQ=; b=bJKNF8pLScgr6voDzS3VSyOrzD gK/OLH3vks8glA98MHQwHEMkMcfGFJG6hDNkllFyZC2x5BYd7uY1Su6jCsgz53MQA1HPuIHtAyqAg 4JOPGSBQGfv+OB58UFUyRCYTD7rLuP1nXSx7B5cqbmGgiFUjV4dlBvurQRyB+2FgAbT0F0oTo6Qpw ryrQgGOlk4SwwQrXgtst78fpj8Ww1z/x0gVqNOCpQmBbtSBeCsn5PFa8Pg5o5SbuafMAXimRWo6vz PshSOWu9WdSwuQM29i7WZm3xf9tKC5aH451cUzBjTBhdGPQwCSNEgQPuSpOpidhhv3XTc1iIMtJjC bus+D5rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBdc5-009ixW-Bp; Thu, 05 Aug 2021 13:40:45 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBdc1-009iwN-AX for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 13:40:43 +0000 Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GgV9H5QV2z6F8WF; Thu, 5 Aug 2021 21:40:19 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 5 Aug 2021 15:40:37 +0200 Received: from [10.47.24.8] (10.47.24.8) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 5 Aug 2021 14:40:36 +0100 Subject: Re: [PATCH] iommu/arm-smmu-v3: Remove some unneeded init in arm_smmu_cmdq_issue_cmdlist() To: Robin Murphy , CC: , , , , References: <1624293394-202509-1-git-send-email-john.garry@huawei.com> From: John Garry Message-ID: <45a8af4f-4202-ecd8-0882-507acf9b2eb2@huawei.com> Date: Thu, 5 Aug 2021 14:40:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.47.24.8] X-ClientProxiedBy: lhreml706-chm.china.huawei.com (10.201.108.55) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_064041_776303_ED21D708 X-CRM114-Status: GOOD ( 24.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDUvMDgvMjAyMSAxMjoyNCwgUm9iaW4gTXVycGh5IHdyb3RlOgo+IE9uIDIwMjEtMDYtMjEg MTc6MzYsIEpvaG4gR2Fycnkgd3JvdGU6Cj4+IE1lbWJlcnMgb2Ygc3RydWN0ICJsbHEiIHdpbGwg YmUgemVyby1pbml0ZWQsIGFwYXJ0IGZyb20gbWVtYmVyIAo+PiBtYXhfbl9zaGlmdC4KPj4gQnV0 IHdlIHdyaXRlIGxscS52YWwgc3RyYWlnaHQgYWZ0ZXIgdGhlIGluaXQsIHNvIGl0IHdhcyBwb2lu dGxlc3MgdG8gemVybwo+PiBpbml0IHRob3NlIG90aGVyIG1lbWJlcnMuIEFzIHN1Y2gsIHNlcGFy YXRlbHkgaW5pdCBtZW1iZXIgbWF4X25fc2hpZnQKPj4gb25seS4KPj4KPj4gSW4gYWRkaXRpb24s IHN0cnVjdCAiaGVhZCIgaXMgaW5pdGlhbGlzZWQgdG8gImxscSIgb25seSBzbyB0aGF0IG1lbWJl cgo+PiBtYXhfbl9zaGlmdCBpcyBzZXQuIEJ1dCB0aGF0IG1lbWJlciBpcyBuZXZlciByZWZlcmVu Y2VkIGZvciAiaGVhZCIsIHNvCj4+IHJlbW92ZSBhbnkgaW5pdCB0aGVyZS4KPj4KPj4gUmVtb3Zp bmcgdGhlc2UgaW5pdGlhbGl6YXRpb25zIGlzIHNlZW4gYXMgYSBzbWFsbCBwZXJmb3JtYW5jZSAK Pj4gb3B0aW1pc2F0aW9uLAo+PiBhcyB0aGlzIGNvZGUgaXMgKHZlcnkpIGhvdCBwYXRoLgo+IAo+ IEkgbG9va2VkIGF0IHRoaXMgYW5kIGltbWVkaWF0ZWx5IHRob3VnaHQgInN1cmVseSB0aGUgY29t cGlsZXIgY2FuIHNlZSAKPiB0aGF0IGFsbCB0aGUgcHJvZC9jb25zL3ZhbCBmaWVsZHMgYXJlIHdy aXR0ZW4gYW55d2F5IGFuZCBlbGlkZSB0aGUgCj4gaW5pdGlhbGlzYXRpb24/Iiwgc28gSSBkdW1w ZWQgdGhlIGJlZm9yZSBhbmQgYWZ0ZXIgZGlzYXNzZW1ibHksIGFuZC4uLiBvaC4KPiAKPiBZb3Ug c2hvdWxkIHByb2JhYmx5IGNsYXJpZnkgdGhhdCBpdCdzIHplcm8taW5pdGlhbGlzaW5nIGFsbCB0 aGUgCj4gY2FjaGVsaW5lIHBhZGRpbmcgd2hpY2ggaXMgYm90aCBwb2ludGxlc3MgYW5kIHBhaW5m dWwuIFdpdGggdGhhdCwKPiAKPiBSZXZpZXdlZC1ieTogUm9iaW4gTXVycGh5IDxyb2Jpbi5tdXJw aHlAYXJtLmNvbT4KPiAKPiBIb3dldmVyLCBoYXZpbmcgbG9va2VkIHRoaXMgY2xvc2VseSBJJ20g bm93IHRhbmdlbnRpYWxseSB3b25kZXJpbmcgd2h5IAo+IG1heF9uX3NoaWZ0IGlzbid0IGluc2lk ZSB0aGUgcGFkZGVkIHVuaW9uPyBJdCdzIHJlYWQgYXQgdGhlIHNhbWUgdGltZSBhcyAKPiBib3Ro IHByb2QgYW5kIGNvbnMgYnkgcXVldWVfaGFzX3NwYWNlKCksIGFuZCBuZXZlciB1cGRhdGVkLCBz byB0aGVyZSAKPiBkb2Vzbid0IGFwcGVhciB0byBiZSBhbnkgYmVuZWZpdCB0byBpdCBiZWluZyBp biBhIHNlcGFyYXRlIGNhY2hlbGluZSBhbGwgCj4gYnkgaXRzZWxmLCBhbmQgbGxxIGlzIGFscmVh ZHkgdHdpY2UgYXMgYmlnIGFzIGl0IG5lZWRzIHRvIGJlLgoKSSB0aGluayB0aGF0IHRoZSBwcm9i bGVtIGlzIGlmIHRoZSBwcm9kK2NvbnMgNjRiIHZhbHVlIGFuZCB0aGUgc2hpZnQgYXJlIApvbiB0 aGUgc2FtZSBjYWNoZWxpbmUsIHRoZW4gd2UgaGF2ZSBhIGNoYW5jZSBvZiBhY2Nlc3NpbmcgYSBz dGFsZSAKY2FjaGVsaW5lIHR3aWNlOgoKc3RhdGljIGludCBhcm1fc21tdV9jbWRxX2lzc3VlX2Nt ZGxpc3Qoc3RydWN0IGFybV9zbW11X2RldmljZSAqc21tdSwKCQkJCSAgICAgICB1NjQgKmNtZHMs IGludCBuLCBib29sIHN5bmMpCnsKCXU2NCBjbWRfc3luY1tDTURRX0VOVF9EV09SRFNdOwoJdTMy IHByb2Q7Cgl1bnNpZ25lZCBsb25nIGZsYWdzOwoJYm9vbCBvd25lcjsKCXN0cnVjdCBhcm1fc21t dV9jbWRxICpjbWRxID0gJnNtbXUtPmNtZHE7CglzdHJ1Y3QgYXJtX3NtbXVfbGxfcXVldWUgbGxx ID0gewoJCS5tYXhfbl9zaGlmdCA9IGNtZHEtPnEubGxxLm1heF9uX3NoaWZ0LAkvLyBoZXJlCgl9 LCBoZWFkID0gbGxxOwoJaW50IHJldCA9IDA7CgoJLyogMS4gQWxsb2NhdGUgc29tZSBzcGFjZSBp biB0aGUgcXVldWUgKi8KCWxvY2FsX2lycV9zYXZlKGZsYWdzKTsKCWxscS52YWwgPSBSRUFEX09O Q0UoY21kcS0+cS5sbHEudmFsKTsJLy8gYW5kIGFnYWluIGhlcmUKCgpzaW5jZSBjbWRxLT5xLmxs cSBpcyBwZXItU01NVS4gSWYgbWF4X25fc2hpZnQgaXMgb24gYSBzZXBhcmF0ZSAKY2FjaGVsaW5l LCB0aGVuIGl0IHNob3VsZCBuZXZlciBiZSBzdGFsZS4KCkkgc3VwcG9zZSB0aGV5IGNvdWxkIGJl IGNvbWJpbmVkIGludG8gYSBzbWFsbGVyIHN1Yi1zdHJ1Y3QgYW5kIGxvYWRlZCBpbiAKYSBzaW5n bGUgb3BlcmF0aW9uLCBidXQgaXQgbG9va3MgbWVzc3ksIGFuZCBwcm9iIHdpdGhvdXQgbXVjaCBn YWluLgoKVGhhbmtzLApKb2huCgo+IFNvcnRpbmcgCj4gdGhhdCB3b3VsZCBhbHNvIGJlIGEgZ29v ZCBvcHBvcnR1bml0eSB0byBzdG9yZSB0aGUgdmFsdWUgb2YgaW50ZXJlc3QgaW4gCj4gaXRzIGFw cHJvcHJpYXRlIGZvcm0gc28gd2UncmUgbm90IG5lZWRsZXNzbHkgcmVjYWxjdWxhdGluZyAxIDw8 IHNoaWZ0IAo+IGV2ZXJ5IGZsaXBwaW4nIHRpbWUuLi4KPiAKPiBSb2Jpbi4KPiAKPj4gU2lnbmVk LW9mZi1ieTogSm9obiBHYXJyeSA8am9obi5nYXJyeUBodWF3ZWkuY29tPgo+Pgo+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYyAKPj4gYi9k cml2ZXJzL2lvbW11L2FybS9hcm0tc21tdS12My9hcm0tc21tdS12My5jCj4+IGluZGV4IDU0YjJm MjdiODFkNC4uOGE4YWQ0OWJiN2ZkIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L2FybS9h cm0tc21tdS12My9hcm0tc21tdS12My5jCj4+ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1z bW11LXYzL2FybS1zbW11LXYzLmMKPj4gQEAgLTcyNywxMSArNzI3LDExIEBAIHN0YXRpYyBpbnQg YXJtX3NtbXVfY21kcV9pc3N1ZV9jbWRsaXN0KHN0cnVjdCAKPj4gYXJtX3NtbXVfZGV2aWNlICpz bW11LAo+PiDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4+IMKgwqDCoMKgwqAgYm9v bCBvd25lcjsKPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgYXJtX3NtbXVfY21kcSAqY21kcSA9ICZzbW11 LT5jbWRxOwo+PiAtwqDCoMKgIHN0cnVjdCBhcm1fc21tdV9sbF9xdWV1ZSBsbHEgPSB7Cj4+IC3C oMKgwqDCoMKgwqDCoCAubWF4X25fc2hpZnQgPSBjbWRxLT5xLmxscS5tYXhfbl9zaGlmdCwKPj4g LcKgwqDCoCB9LCBoZWFkID0gbGxxOwo+PiArwqDCoMKgIHN0cnVjdCBhcm1fc21tdV9sbF9xdWV1 ZSBsbHEsIGhlYWQ7Cj4+IMKgwqDCoMKgwqAgaW50IHJldCA9IDA7Cj4+ICvCoMKgwqAgbGxxLm1h eF9uX3NoaWZ0ID0gY21kcS0+cS5sbHEubWF4X25fc2hpZnQ7Cj4+ICsKPj4gwqDCoMKgwqDCoCAv KiAxLiBBbGxvY2F0ZSBzb21lIHNwYWNlIGluIHRoZSBxdWV1ZSAqLwo+PiDCoMKgwqDCoMKgIGxv Y2FsX2lycV9zYXZlKGZsYWdzKTsKPj4gwqDCoMKgwqDCoCBsbHEudmFsID0gUkVBRF9PTkNFKGNt ZHEtPnEubGxxLnZhbCk7Cj4+Cj4gLgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK