From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22A81EE0206 for ; Wed, 11 Sep 2024 18:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oi1ycBl7Zo/pcrvjxctEWR3H8TSj6fTGuiJIc535U80=; b=VgI6L/TlxqJuG4HExgRzFfz4rq 9RfwxBf/37m63/9ulfmu+jR5wyekpwpgX3dPDN5bEX5M78vcsURVtfKPOx+K40UxwDINoLVEMO1Bi swrhDiq3JDO+YCkXBhZtNbhxH22aqz6KTILcdUKUSwzvbQvZ5d4RcgFcRE+MliRWQ5Ii87Rz8ml09 RUxByWrmLJMH8gx7Uu6GHknFVhS0V+z+Qy/FGeFvJc97jaYK4Ps7/gphn7Y2pEXJJv0IWih0lhItA ygxljYos2LE4cjOTQ2uBu1mWmk/H8AU5cFKyxykN9VEQ59qTVab0sVwGGoaZaCm9dxGv3/MlDp3Mu HrDkN+/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soRec-0000000Aa32-2KbD; Wed, 11 Sep 2024 18:01:22 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soRdW-0000000AZt1-0hFz for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 18:00:18 +0000 Received: by mail-pl1-x642.google.com with SMTP id d9443c01a7336-2054e22ce3fso1597315ad.2 for ; Wed, 11 Sep 2024 11:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1726077613; x=1726682413; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oi1ycBl7Zo/pcrvjxctEWR3H8TSj6fTGuiJIc535U80=; b=2wKU1lH3RQLynVyIbXF9WiUbMKfLv5DpltscvMDY6VQ2ZY+4gXaXCh6KvIm0M1bZLk MUCGD4H6w62oDwl8TK/V0fegbACDpWudesTWRetYy6NWl9XsButFZvVhfyTqDOAlhKVD ikLRlTzw33AO9fdjDFDgyEB69lKwX36OV4rdMTdqMe1bJnTpfo8uRp4mv/w4H6BkfQPM ZFZ+2GpgMhmnIapq4yjMn8Jj6eXDV5LHnhdTeEBqq89JtTPC2eZcudPQ9p6PEXk+ZFKV +ZkZ+9L0o2kPq0n+p6gdr3Cw43CLDXytAbRwluieppdIvE3anDJr968aW3Ks9Yjx7wOf AEyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726077613; x=1726682413; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oi1ycBl7Zo/pcrvjxctEWR3H8TSj6fTGuiJIc535U80=; b=OvNHI9IV2fEmYbu7dsAZ/Tqi2vZTV28/jm5ScXBA1tKvHTvTJajda0ohTA0CzFyFQJ qpNRdk2B3iYCaH5Hk3WEGJIQQTabJVjcRtAaG0awrigFTU+I1KxdIjmC9HH1C8466oFD LMfpqtZMrvv0FcJo7/UCJkwPq5LMsI4r8skUZF90ztsEghwkexf9v8dtD2qNPWeemLf7 yVwseNjFYnLmX4CoMZ/fnPNWv5kbOQiHYLPhwsX9qHLhVT54+d6/QQY9jOj8BT4FqktJ vIAvO8WjEQxp75PMazYmZy+eFWH282SV+CXDzAC4s2NxymRpNch/7ji/7O7T7hKMJbFa T12A== X-Forwarded-Encrypted: i=1; AJvYcCW6tERsnMA3+PgeJpSZ8z5M+rKgVAaLCm3xDZm/UBvvf6pP/CaTV2QvRh5i/7IdOj2Q4W9hwmQIEVTjEI/wh87Q@lists.infradead.org X-Gm-Message-State: AOJu0Yx2PY+E+eG5f966L0I3KXQUB8rjdHcxfb/YjQ5BY1LUd/TxxHEb 2ymYYemmnG5jSz4j+Y+wwaK+CcIOIO3rAIP8PRPVOAj5EDpi0riuadHeoT4Znw== X-Google-Smtp-Source: AGHT+IGHMbSQUJFzu4dp7JtqdcyOhvxEYRG1Urbc0wxUZecfk89IK2jJJvDZYYh7dccxukx7Xnx2Jg== X-Received: by 2002:a17:903:41c3:b0:207:1de9:1014 with SMTP id d9443c01a7336-2076e38f304mr3245735ad.34.1726077611683; Wed, 11 Sep 2024 11:00:11 -0700 (PDT) Received: from [172.16.118.100] ([103.15.228.94]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076afec4fdsm2268195ad.228.2024.09.11.11.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2024 11:00:11 -0700 (PDT) Message-ID: <45b1894b-0a15-4efc-95a0-596aa6728fd7@beagleboard.org> Date: Wed, 11 Sep 2024 23:30:01 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] dt-bindings: connector: Add MikorBUS connector Content-Language: en-US To: Rob Herring Cc: fabien.parent@linaro.org, d-gole@ti.com, lorforlinux@beagleboard.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, Andrew Davis , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Krzysztof Kozlowski , Conor Dooley , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240911-mikrobus-dt-v1-0-3ded4dc879e7@beagleboard.org> <20240911-mikrobus-dt-v1-2-3ded4dc879e7@beagleboard.org> <20240911172626.GB915638-robh@kernel.org> From: Ayush Singh In-Reply-To: <20240911172626.GB915638-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_110014_402784_EAE47041 X-CRM114-Status: GOOD ( 23.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/11/24 22:56, Rob Herring wrote: > On Wed, Sep 11, 2024 at 07:57:19PM +0530, Ayush Singh wrote: >> Add DT bindings for mikroBUS interface. MikroBUS [0] is an open standard >> developed by MikroElektronika for connecting add-on boards to >> microcontrollers or microprocessors. > Typo in the subject... > > Isn't this v6? Where's the revision history? Well, at this point, it almost has nothing in common with [0] (the previous patch series was about making mikroBUS a Linux bus) and is more of a continuation of [1]. So I thought it would be better to treat it as a new patch series. >> MikroBUS connector node will optionally act as nexus nodes for routing >> GPIOs and PWM. >> >> For GPIOs, the following pin numbering should be followed: >> >> 0: PWM >> 1: INT >> 2: RX >> 3: TX >> 4: SCL >> 5: SDA >> 6: MOSI >> 7: MISO >> 8: SCK >> 9: CS >> 10: RST >> 11: AN >> >> For PWM, the PWM pin should be on channel 0. >> >> I am not quite sure how to deal with the nexus node properties >> (#gpio-cells, gpio-map, gpio-map-mask, gpio-map-pass-thru) since they >> seem to conflict with upstream gpio schema (gpio-controller is a >> dependency of #gpio-cells). >> >> [0]: https://www.mikroe.com/ >> >> Signed-off-by: Ayush Singh >> --- >> .../bindings/connector/mikrobus-connector.yaml | 40 ++++++++++++++++++++++ >> MAINTAINERS | 5 +++ >> 2 files changed, 45 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/connector/mikrobus-connector.yaml b/Documentation/devicetree/bindings/connector/mikrobus-connector.yaml >> new file mode 100644 >> index 000000000000..603e4627076c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/connector/mikrobus-connector.yaml >> @@ -0,0 +1,40 @@ >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause >> +# >> +# Copyright (c) Ayush Singh >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/connector/mikrobus-connector.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: mikroBUS add-on board socket >> + >> +maintainers: >> + - Ayush Singh >> + >> +properties: >> + compatible: >> + const: mikrobus-connector >> + >> +required: >> + - compatible >> + >> +additionalProperties: true > Cannot be true. You're schema must be complete. I don't understand what > happened to everything else in the binding. So the current dtschema makes `gpio-controller` dependency of `#gpio-cells` which should not hold true for nexus node [2]. I also wanted to understand if the nexus node schema should go in upstream dtschema or be in kernel tree. I will try to figure out how nexus node properties should look by taking interrupt nexus node bindings as a starting point. [0]: https://lore.kernel.org/linux-arm-kernel/20240627-mikrobus-scratch-spi-v5-0-9e6c148bf5f0@beagleboard.org/ [1]: https://lore.kernel.org/linux-arm-kernel/20240702164403.29067-1-afd@ti.com/ [2]: https://devicetree-specification.readthedocs.io/en/v0.3/devicetree-basics.html#nexus-nodes-and-specifier-mapping Ayush Singh