From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23BF5EB64D8 for ; Wed, 14 Jun 2023 06:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SR248SLNMY4dryjVJPgZEzmOaqLsRojvEZJqZnjWXxo=; b=Jrp9Zt6Pmz7dsz +UE/1u7C6gmYS7a13mDJCEOsbzt9iVIcdwkSUVXPjLN03X2L7F/ONTiTySftqoUC/Uwjrv2wuB3EP SDmvyXQOsKNJLWd8dQxXYVP6zDk2gYKRCL+eHYb8Pf3UBwtGhOb3kT0Z1yTFJcDvZQAUCNY3OK0QD nRZd8ZsQoxBcr2TT6/GVnbVCnwrd8tbGnTDq/DIzWe8MSMjFeuNLEo6Dk8UUpHgTCnoeTHnZqJduZ YDxLe87G+lb4IiFyqlUD7CtZJSu4r9GuV+wotbGos9dh5SILHfltd+gmKfUjBSlifyfMzpV0OmyX/ met3bNQjwi8WMl5fIgZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9KHh-00AVgW-25; Wed, 14 Jun 2023 06:47:13 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9KHd-00AVef-2z for linux-arm-kernel@lists.infradead.org; Wed, 14 Jun 2023 06:47:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686725230; x=1718261230; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=4jyRivimz320mZeL/r1VIopaqg2bjkDVrvnaYumJGik=; b=kjlbzp+x2semyyiube1spGh++HXhb8oSePfs4+8cAdcaHpfHAb+EPh8B ubCD45PtRrZ4GsTjUlzWbNnlgNFdwJ0tHdCZ1v9h3EBHUwvAmltnBX4I8 1LZUaSu8RZOpvUNMmCPrpGhPf5Y7Rgg6vMjZd0I7o5yuyyR4F8HtEwnwK gxteliqYV+bkcveuSeelP2vVVtRYIC6GHnQj6Fgx4VRB1akfrHTTRMPax ve2xbW4jGzEuIpVG6KHREBl4OGH7778L9+q1dvoLvNeGvE/IKL3evrkFm e3mknaZXksSeCQQEhDurNv43Y8S+VVB5DyHJM9zoY5Wu44T8fG59KQxvD A==; X-IronPort-AV: E=Sophos;i="6.00,241,1681196400"; d="scan'208";a="218397080" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Jun 2023 23:47:05 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 13 Jun 2023 23:47:05 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 13 Jun 2023 23:47:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AF4m8RfK2eA4PykC3HLaUFAh8hGgw9YiLewU5aboyxSsyECBQ4h6Q+zjlbsyInPZ1+wOdwvgcRrejTxSpKia+CmzjOgSNBt5TOM3Fn/RqVJRSahBW14rARRc/n2kS1KiFsC2Mhz8FNU+LLqeJ0iyaXhqftZcFI3JOv/2zkPvhDUqCDAIW1Co1YePyOxbbH1XdG/Wl26EvAoZuBWwCBF37lqQyJYDeGnIUqDWtMSETHxUxj7mmu1p5uWMatwOhThKGtSIpwdb4eU3Hexwvhy5OuS5+27H+7/Q8yvCcBI6JfUYO1v5hACrfAPS9IrdUxrPh+atkVe6QKhGWnjbT7ZbDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4jyRivimz320mZeL/r1VIopaqg2bjkDVrvnaYumJGik=; b=O9YWprLON14FBo63NybHEJHbtdnOfcjRxZYzlKgY3S8OfVTwDRF4ZjdLB10PWgXIQTfyvtPj5mX5eA4diOjrmShjUvVHrxatxN05kxT7wPjpqsgxcQvmVMIIowSKMp+QJDWv1E0kkXgbKy6WrUk3Zp3lS51gVFDNqulkangw8lfpjQ+3ABsMWGHx8aD4rV3VxC7RwZ3ddiigbyGxK7Wt3G8KeLDZTPEwoDvdz9jLzzzjx11HpPWcO6SOqrlK0Hp/OOXm5c/Zedrl3IwTq6jMC9qZwGeGOnT+iFFW5rhyMWohzMVBqF3P1hzNQ5/eewsg3Mb2dSIJli/1YbjGgo8PdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4jyRivimz320mZeL/r1VIopaqg2bjkDVrvnaYumJGik=; b=Fz92vSudQeVuBxsqKOncnOv14rzV1Oab51eiCNGlv7YmGe8E4at0+8PQAAn1hvP1hbX3W0gLw9BU/ADeBIqbwvhsBooiQIZ9CkuMXgkf7kTOP8vC0WHlrrESPevPztIg+tX6Um8JwnyIpGE3Q94NUNOdcwqCbfujNoBd6WQVMS0= Received: from SJ2PR11MB7648.namprd11.prod.outlook.com (2603:10b6:a03:4c3::17) by CH3PR11MB8239.namprd11.prod.outlook.com (2603:10b6:610:156::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.28; Wed, 14 Jun 2023 06:47:03 +0000 Received: from SJ2PR11MB7648.namprd11.prod.outlook.com ([fe80::27bf:a69f:806f:67be]) by SJ2PR11MB7648.namprd11.prod.outlook.com ([fe80::27bf:a69f:806f:67be%5]) with mapi id 15.20.6433.024; Wed, 14 Jun 2023 06:47:03 +0000 From: To: , , , , , , , , , , , , , , CC: , , , , , , Subject: Re: [PATCH 4/9] drm: atmel-hlcdc: Define SAM9X7 XLCDC specific registers Thread-Topic: [PATCH 4/9] drm: atmel-hlcdc: Define SAM9X7 XLCDC specific registers Thread-Index: AQHZnowG5soO+lRSFEOuIqybl7hz7A== Date: Wed, 14 Jun 2023 06:47:02 +0000 Message-ID: <45b4fc00-fd46-9594-d621-33ad1db4c4de@microchip.com> References: <20230613070426.467389-1-manikandan.m@microchip.com> <20230613070426.467389-5-manikandan.m@microchip.com> In-Reply-To: <20230613070426.467389-5-manikandan.m@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ2PR11MB7648:EE_|CH3PR11MB8239:EE_ x-ms-office365-filtering-correlation-id: 17af4a4e-4695-461a-42fa-08db6ca32927 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fp1Hy1XAAZdKycz80BD0MO8Q2I8udOSvladIrlJzKBxcW0BVcZ4VlJ4SZuRjR0RyPngHdK/c1LSmAxxTvasSQvdSVRcd1GUlu5P7SNMeodsa2GWCY/9CvZ6UGTb69UvEZFmnFys2pbTeS3hTaqXIClEsds4ta9MyB/6U6jYtgEFnaIG14kms3bgEaOge8MZOXquOtHWKO8WWWu4ahWQ7PBVeyaQIUDcVwqbgw31dXkUsVEI8bW6AhM9ejOYCGLKwc3oLmh2F3liOV44MIjV7cdWKhVyPoTwO5fvdQ39Nv+MHY21eG25h/gdtIMp/5QGelFGzjVpwAyaJbdBjKCjCHuY4iqnZkcspAd6/OnkBlz7IpAaxWyDVS7NmD4ZIZkL3A7dqK+//+t9m4xO2elGiMMFpLl0ek5Bja41RgL0PwKi8MVE/8UD5G0DElT1kmoRs4NSY/4dJjxFrPIdWz8gNsWoro6bRT7mufcmUHuXvFosYJoI/g9mn+7Nhwvf35+rD9SxdopUcPLztsIy6Fdjm8vDNTe1VSQKxoMjEZ1i8nr/1ygEKigVWFygptwMKeWGO9SXbWeBrXekJW4rxd+iBVZzCVlvUK7hYYf3wSIME0cwZadgqsigyl8JVQuAXOpTIOQRtNd70175nHwd7rJ9K4pK7jUhE6l3bKQjChR1q6kHeSfoud4UcaRPW0w2yeUKEoVuCzyEHpxgC+MHq/NBHJw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7648.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(366004)(346002)(136003)(39860400002)(451199021)(38070700005)(31696002)(6506007)(6512007)(26005)(53546011)(2616005)(38100700002)(41300700001)(83380400001)(31686004)(186003)(6486002)(107886003)(921005)(478600001)(8936002)(110136005)(54906003)(71200400001)(66556008)(66446008)(122000001)(91956017)(66946007)(76116006)(316002)(64756008)(8676002)(36756003)(86362001)(4326008)(2906002)(7416002)(5660300002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NjVvcDBjWnYzcWpaUUNJLytUMkgyVFF4Vk1RUHhrY0VrVWREcC80NXlQUlkz?= =?utf-8?B?bERxclBEU0ZzQjhXaWVFQzQyVXVTd05kMVZVa0NDa1Rqc3JoUkJQdFQrdHlj?= =?utf-8?B?TWNKNDJzV1Jtdkszci9BL2djV3gyN0V1dDI5WjV4bkUwaFV1UkRLa0ZiR0I5?= =?utf-8?B?N1E2K1R4dVBCQ2lOT1NvajhKRUlZYk9LdGlWRGpkbE9HTXpEd2ROYkdCeFE0?= =?utf-8?B?Zk92ZHpUQTA1NWV0Q09ta2N0L2lZNVhxd2J3NjhtVHRBdXlROFF0SU9yV08w?= =?utf-8?B?dENQU2JtWFdWeGxSVnkzWW1lVlZDQ2V2N3AyY1Y3Y0RTK3JrczJqRDlJZG40?= =?utf-8?B?bHFEL0oza3lWTVZSMFZsU3JvQ3M3YmNZMjVrdEJONU8rN0VWaWMrbXFRV1Ux?= =?utf-8?B?OTFiZFNXbWJwbW4ySnhMNnZwRWZqcW83UUk2SlR0Y1dNKzFpTkJ6SVFNVDRZ?= =?utf-8?B?UzUxcjRocGY5Rm4vMnd4MHJhWU1EOUlqZUFWd1BMTFVqVlNSTnVKelpwZFEy?= =?utf-8?B?SDc0RzZJU3NlOEFpWktyY09WUU1QMmhub0pESUZSeDJjVDhsRnZZcW13TFlR?= =?utf-8?B?Y2lQNXUraXhXK0Nzang1WTRvczJEd3RCRkNpTHRnUGtlT3RXMS9xRStZVnRL?= =?utf-8?B?Q2JTNU1abVoxeWMyK0Z6MERrR0F2SGkrdnRMcUNzaHdyYnVTYW9sTDcrSVpY?= =?utf-8?B?R3V6c29DRVRtYUQ2ZUY2TUQ5b0cwVzJEcHArSUtSMENnQUFObmRWTTRGOGxB?= =?utf-8?B?RzBLS25pTGtwYzQzaUJiQXkxRDlXeDJFUEFQaVlUR3ZoTGdoUW1BanBSdDFu?= =?utf-8?B?WjFqdGVEMHhyN3d2OXNQSURrVUFrSU9NWGw5TExzQTdjSk9Kc0ZNaHNGb2Nu?= =?utf-8?B?cEQrMVdnNlNKQ1AydXJOMFY1d2N5M2xTcjR4Ujl4ZHVFWDJPbm9SSXU2MjNT?= =?utf-8?B?b2tJUisvRG9LdEhENEFETmJ2YTdOQmxsRkpGY3FmRUJSTXg5SzRENm9WSmVZ?= =?utf-8?B?YnFMSGUyQTFOelkyTFE4UkE2TTJFZGRDTm1OdXhBMGFrbTN1Yy9ENnhUekt0?= =?utf-8?B?S0Mvc01zT2JKRHZiMkV4M09SU1ZIWG1aeWppZHhUa0ExYkhkWXdMN0orYVhF?= =?utf-8?B?SmlCNVpxSGdIZFNFV0tGUTZEYkxmNko0MEM1bjJ6amFrZlhxaElYQjIySUxw?= =?utf-8?B?Mzh0NE9YN2hIUlhTNGNJWnZoZjVrN2FtRTJCMTZINE1Lc1hkazdYZWVMN29C?= =?utf-8?B?U2ltMkZZcnVxaHN4QmhES3ovWmpIbnJhSjVsWnAzVzdUSXBWOXZzNmZZQmta?= =?utf-8?B?alBkbmJQamlSWEwvbnFzMCtMMXJyWUU5ZGZrM3lWUzVnT1hMVlpzQ3ZwbjRr?= =?utf-8?B?b0VzcExXbXJFTTBIc0V3QjlGdVhiVlg5ZWtOM2k4UXNLQ0Q5ZkZaem4vYkNJ?= =?utf-8?B?VUZBQWJJaGl3M0tSRGxsSlBnNnFPRktqTHBpTjZyallCNFlFc3FEamtSK2M4?= =?utf-8?B?Tm1oWmd6NTMya0k3bHBzeTZxL1ZIbVlGNUlvcGIrcWNmOGlLa3MwSjA5VHo3?= =?utf-8?B?L09WYTEvRkRGU1U5TDdKSWRybTRITkwxZ0pMNXhVQldiZW93V2VwQWRJSEJM?= =?utf-8?B?em9CeW1uSDlUTllWVFdBY3J3Z216QWVwWWI5ZXliT29RUENTWWRLTzhDZUFI?= =?utf-8?B?YzAxS3R6ZW1NdGpldVN3S1d5R1AyM1hHbEt4b00yR0ZZN0dIQkZrUktreHRD?= =?utf-8?B?aGl6UjVHT29yaGRxNVJ2ekd1K3RPSytOSm9TcEwwbFpBTWFzV0QrZFdhRmdv?= =?utf-8?B?endvdzgzSTloMStzbzE4cnFCVTgrSHhpT1RHY3dUWVRuL2VJbEdqbXJIU3ly?= =?utf-8?B?UjhkOXdXOVFXOUI1MHhMMmd6dWE2MllOdkdGOERUV29BQUtTM2FrVFJJR04w?= =?utf-8?B?QjBJc1ZiNEw4UDhUbzR0UHoyd25lbTBHdDNMQXFCS0ltV0Q4TVlZQWhZU1dT?= =?utf-8?B?T0lBZ2dyOEpZVjZJUUJXbjIvaTlkdEE0dy9XbzJSZzVoUDdCQjZRTGxOY2JY?= =?utf-8?B?dndMRUFxWnQxemtyeDdPMXM2TEtvcDM4V0V1Rkl4Y01UN0xibStoK1JMOUxs?= =?utf-8?Q?vLEBjsgk4JfUQfQGNxBtE2EAI?= Content-ID: <22AB20DFB66E4C4385EA3E8CF80E5A83@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7648.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17af4a4e-4695-461a-42fa-08db6ca32927 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2023 06:47:02.8495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BMexe4fBe3o/HlGMjSj6GPLnLRzBPpPcs+CcdK77n8VHCTYGtezQ5F0bTO139Bc5XN7duy4ei0Z8TmQPlvhBEWmE8V1dYBx+B06VJfQuS8s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8239 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_234710_095868_AF22EA10 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Manikandan, On 13.06.2023 10:04, Manikandan Muralidharan wrote: > From: Durai Manickam KR > > The register address of the XLCDC IP used in SAM9X7 are different from > the previous HLCDC.Defining those address space with valid macros. > > Signed-off-by: Durai Manickam KR > [manikandan.m@microchip.com: Remove unused macro definitions] > Signed-off-by: Manikandan Muralidharan > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 108 +++++++++++++++++++ > include/linux/mfd/atmel-hlcdc.h | 10 ++ > 2 files changed, 118 insertions(+) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > index 5b5c774e0edf..aed1742b3665 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > @@ -15,6 +15,7 @@ > > #include > > +/* LCD controller common registers */ > #define ATMEL_HLCDC_LAYER_CHER 0x0 > #define ATMEL_HLCDC_LAYER_CHDR 0x4 > #define ATMEL_HLCDC_LAYER_CHSR 0x8 > @@ -128,6 +129,113 @@ > > #define ATMEL_HLCDC_MAX_LAYERS 6 > > +/* XLCDC controller specific registers */ > +#define ATMEL_XLCDC_LAYER_ENR 0x10 > +#define ATMEL_XLCDC_LAYER_EN BIT(0) > + > +#define ATMEL_XLCDC_LAYER_IER 0x0 > +#define ATMEL_XLCDC_LAYER_IDR 0x4 > +#define ATMEL_XLCDC_LAYER_IMR 0x8 > +#define ATMEL_XLCDC_LAYER_ISR 0xc > +#define ATMEL_XLCDC_LAYER_DONE_IRQ(p) BIT(0 + (8 * (p))) > +#define ATMEL_XLCDC_LAYER_ERROR_IRQ(p) BIT(1 + (8 * (p))) > +#define ATMEL_XLCDC_LAYER_OVR_IRQ(p) BIT(2 + (8 * (p))) > + > +#define ATMEL_XLCDC_LAYER_PLANE_ADDR(p) (((p) * 0x4) + 0x18) > + > +#define ATMEL_XLCDC_LAYER_DMA_CFG 0 > +#define ATMEL_XLCDC_LAYER_DMA_BLEN_MASK GENMASK(6, 4) > +#define ATMEL_XLCDC_LAYER_DMA_BLEN_SINGLE (0 << 4) > +#define ATMEL_XLCDC_LAYER_DMA_BLEN_INCR32 (4 << 4) > +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_MASK GENMASK(10, 8) > +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_SINGLE (0 << 8) > +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_INCR4 (1 << 8) > +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_INCR8 (2 << 8) > +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_INCR16 (3 << 8) > +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_INCR32 (4 << 8) > + > +#define ATMEL_XLCDC_GAM BIT(2) > + > +#define ATMEL_XLCDC_LAYER_POS(x, y) ((x) | ((y) << 16)) > +#define ATMEL_XLCDC_LAYER_SIZE(w, h) (((w) - 1) | (((h) - 1) << 16)) > + > +#define ATMEL_XLCDC_LAYER_DMA BIT(0) > +#define ATMEL_XLCDC_LAYER_REP BIT(1) > +#define ATMEL_XLCDC_LAYER_CRKEY BIT(2) > +#define ATMEL_XLCDC_LAYER_DSTKEY BIT(3) > +#define ATMEL_XLCDC_LAYER_DISCEN BIT(4) > +#define ATMEL_XLCDC_LAYER_VIDPRI BIT(5) > +#define ATMEL_XLCDC_LAYER_SFACTC_MASK GENMASK(8, 6) > +#define ATMEL_XLCDC_LAYER_SFACTC_ONE (0 << 6) > +#define ATMEL_XLCDC_LAYER_SFACTC_ZERO (1 << 6) > +#define ATMEL_XLCDC_LAYER_SFACTC_A0 (2 << 6) > +#define ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AD (3 << 6) > +#define ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AS (4 << 6) > +#define ATMEL_XLCDC_LAYER_SFACTC_M_A0_MULT_AD (5 << 6) > +#define ATMEL_XLCDC_LAYER_SFACTA_MASK GENMASK(10, 9) > +#define ATMEL_XLCDC_LAYER_SFACTA_ZERO (0 << 9) > +#define ATMEL_XLCDC_LAYER_SFACTA_ONE (1 << 9) > +#define ATMEL_XLCDC_LAYER_SFACTA_A0 (2 << 9) > +#define ATMEL_XLCDC_LAYER_SFACTA_A1 (3 << 9) > +#define ATMEL_XLCDC_LAYER_DFACTC_MASK GENMASK(13, 11) > +#define ATMEL_XLCDC_LAYER_DFACTC_ZERO (0 << 11) > +#define ATMEL_XLCDC_LAYER_DFACTC_ONE (1 << 11) > +#define ATMEL_XLCDC_LAYER_DFACTC_A0 (2 << 11) > +#define ATMEL_XLCDC_LAYER_DFACTC_A1 (3 << 11) > +#define ATMEL_XLCDC_LAYER_DFACTC_A0_MULT_AD (4 << 11) > +#define ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AD (5 << 11) > +#define ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AS (6 << 11) > +#define ATMEL_XLCDC_LAYER_DFACTC_M_A0 (7 << 11) > +#define ATMEL_XLCDC_LAYER_DFACTA_MASK GENMASK(15, 14) > +#define ATMEL_XLCDC_LAYER_DFACTA_ZERO (0 << 14) > +#define ATMEL_XLCDC_LAYER_DFACTA_ONE (1 << 14) > +#define ATMEL_XLCDC_LAYER_DFACTA_M_A0_MULT_AS (2 << 14) > +#define ATMEL_XLCDC_LAYER_DFACTA_A1 (3 << 14) > +#define ATMEL_XLCDC_LAYER_A0_SHIFT 16 > +#define ATMEL_XLCDC_LAYER_A0_MASK \ > + GENMASK(23, ATMEL_XLCDC_LAYER_A0_SHIFT) > +#define ATMEL_XLCDC_LAYER_A0(x) \ > + ((x) << ATMEL_XLCDC_LAYER_A0_SHIFT) > +#define ATMEL_XLCDC_LAYER_A1_SHIFT 24 > +#define ATMEL_XLCDC_LAYER_A1_MASK \ > + GENMASK(31, ATMEL_XLCDC_LAYER_A1_SHIFT) > +#define ATMEL_XLCDC_LAYER_A1(x) \ > + ((x) << ATMEL_XLCDC_LAYER_A1_SHIFT) > + > +#define ATMEL_XLCDC_LAYER_DISC_POS(x, y) ((x) | ((y) << 16)) > +#define ATMEL_XLCDC_LAYER_DISC_SIZE(w, h) (((w) - 1) | (((h) - 1) << 16)) > + > +#define ATMEL_XLCDC_LAYER_VSCALER_LUMA_ENABLE BIT(0) > +#define ATMEL_XLCDC_LAYER_VSCALER_CHROMA_ENABLE BIT(1) > +#define ATMEL_XLCDC_LAYER_HSCALER_LUMA_ENABLE BIT(4) > +#define ATMEL_XLCDC_LAYER_HSCALER_CHROMA_ENABLE BIT(5) > + > +#define ATMEL_XLCDC_LAYER_VXSYCFG_ZERO (0 << 0) > +#define ATMEL_XLCDC_LAYER_VXSYCFG_ONE (1 << 0) > +#define ATMEL_XLCDC_LAYER_VXSYCFG_TWO (2 << 0) > +#define ATMEL_XLCDC_LAYER_VXSYCFG_THREE (3 << 0) > +#define ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE BIT(4) > +#define ATMEL_XLCDC_LAYER_VXSYBICU_ENABLE BIT(5) > +#define ATMEL_XLCDC_LAYER_VXSCCFG_ZERO (0 << 16) > +#define ATMEL_XLCDC_LAYER_VXSCCFG_ONE (1 << 16) > +#define ATMEL_XLCDC_LAYER_VXSCCFG_TWO (2 << 16) > +#define ATMEL_XLCDC_LAYER_VXSCCFG_THREE (3 << 16) > +#define ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE BIT(20) > +#define ATMEL_XLCDC_LAYER_VXSCBICU_ENABLE BIT(21) > + > +#define ATMEL_XLCDC_LAYER_HXSYCFG_ZERO (0 << 0) > +#define ATMEL_XLCDC_LAYER_HXSYCFG_ONE (1 << 0) > +#define ATMEL_XLCDC_LAYER_HXSYCFG_TWO (2 << 0) > +#define ATMEL_XLCDC_LAYER_HXSYCFG_THREE (3 << 0) > +#define ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE BIT(4) > +#define ATMEL_XLCDC_LAYER_HXSYBICU_ENABLE BIT(5) > +#define ATMEL_XLCDC_LAYER_HXSCCFG_ZERO (0 << 16) > +#define ATMEL_XLCDC_LAYER_HXSCCFG_ONE (1 << 16) > +#define ATMEL_XLCDC_LAYER_HXSCCFG_TWO (2 << 16) > +#define ATMEL_XLCDC_LAYER_HXSCCFG_THREE (3 << 16) > +#define ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE BIT(20) > +#define ATMEL_XLCDC_LAYER_HXSCBICU_ENABLE BIT(21) > + There are a bunch of defines included in this file not used anywhere in the driver. Please check and keep only necessary. Thank you, Claudiu > /** > * Atmel HLCDC Layer registers layout structure > * > diff --git a/include/linux/mfd/atmel-hlcdc.h b/include/linux/mfd/atmel-hlcdc.h > index a186119a49b5..80d675a03b39 100644 > --- a/include/linux/mfd/atmel-hlcdc.h > +++ b/include/linux/mfd/atmel-hlcdc.h > @@ -22,6 +22,8 @@ > #define ATMEL_HLCDC_DITHER BIT(6) > #define ATMEL_HLCDC_DISPDLY BIT(7) > #define ATMEL_HLCDC_MODE_MASK GENMASK(9, 8) > +#define ATMEL_XLCDC_MODE_MASK GENMASK(10, 8) > +#define ATMEL_XLCDC_DPI BIT(11) > #define ATMEL_HLCDC_PP BIT(10) > #define ATMEL_HLCDC_VSPSU BIT(12) > #define ATMEL_HLCDC_VSPHO BIT(13) > @@ -34,6 +36,12 @@ > #define ATMEL_HLCDC_IDR 0x30 > #define ATMEL_HLCDC_IMR 0x34 > #define ATMEL_HLCDC_ISR 0x38 > +#define ATMEL_XLCDC_ATTRE 0x3c > + > +#define ATMEL_XLCDC_BASE_UPDATE BIT(0) > +#define ATMEL_XLCDC_OVR1_UPDATE BIT(1) > +#define ATMEL_XLCDC_OVR3_UPDATE BIT(2) > +#define ATMEL_XLCDC_HEO_UPDATE BIT(3) > > #define ATMEL_HLCDC_CLKPOL BIT(0) > #define ATMEL_HLCDC_CLKSEL BIT(2) > @@ -48,6 +56,8 @@ > #define ATMEL_HLCDC_DISP BIT(2) > #define ATMEL_HLCDC_PWM BIT(3) > #define ATMEL_HLCDC_SIP BIT(4) > +#define ATMEL_XLCDC_SD BIT(5) > +#define ATMEL_XLCDC_CM BIT(6) > > #define ATMEL_HLCDC_SOF BIT(0) > #define ATMEL_HLCDC_SYNCDIS BIT(1) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel