From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6FA1C52D7C for ; Tue, 13 Aug 2024 13:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yf77RZmJBkdO5ATfOLcBYjHWMlR9pScAsVtBBg/4+eY=; b=g+XOKJum8d3Nt1VdFx+2L8cTXb 7/yonbZcXn/NeQIdMe/Ls8tnsU5QP61qSsaBZXjoCn+r5AeEktdoPN5PR9TL9jDjbf7JFcah+DdBI OXSOvptYtAIS0TC6GPXstXmfun6ct94pEBN/sswjzFwOQye0SwoC4E5b3fGO0ke6LZaHUqnwsc5gE 6dc/tBoJ0EGkdz2UnD1l/57hl2MWgBImIsi04rNsdcL9TR3/RrNfM/kOcQDISprcBCmqSpMt7LcAl TNrQvbSqpTRUWP6uKtv4g3RmIxqTd5o4gWDbfXB6y1mHIAeYxxDbJaNkyVyl24PdGvT+/rhErpBwb za/KXgGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdrMn-00000003pZr-2M6x; Tue, 13 Aug 2024 13:15:13 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdrLd-00000003pMD-3hRZ for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2024 13:14:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1723554841; x=1755090841; h=message-id:subject:from:reply-to:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=yf77RZmJBkdO5ATfOLcBYjHWMlR9pScAsVtBBg/4+eY=; b=M4ApcpKOVrkDGfF4tkCILpxZcDYRy774TwCGDsQ+igfOT3JZe4aWqBic 3SYQc9TEbHFshNXcs8Iiq/twwmq+l2NH3Tqo21pEzRL4eiu+Ux5pHemp1 dPZHWIWmciuCr95X+366vpdFMjfgCSO/JNAP9P+Or+OK0N3c08Epnq7on 7qSzitUKyNt+pWJYtDFWJvjwOJjULdkq8PUvyO2iq/ZTFR/uOVYU1azAz NtjwMY1RsoIMEH7YcDt9dy22UsPrjxgGiSwboxL+mZv0syqHaPAD4btFw HC831wXn/21hNAsziUsF8KKx01s0Gvn6rvi7wZubfATzK88DsayG/fszw w==; X-CSE-ConnectionGUID: SxBRmycOQEmEVCFOwZ+QeA== X-CSE-MsgGUID: o4MPJmH7RWuqqdLfwzOTqw== X-IronPort-AV: E=Sophos;i="6.09,285,1716242400"; d="scan'208";a="38386887" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 13 Aug 2024 15:13:59 +0200 X-CheckPoint: {66BB5C17-14-751552D8-F91D2344} X-MAIL-CPID: 60DCDD33188D7A76BC97FB9DA423ABDC_4 X-Control-Analysis: str=0001.0A782F20.66BB5C17.00B5,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 184601627D0; Tue, 13 Aug 2024 15:13:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1723554834; h=from:reply-to:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=yf77RZmJBkdO5ATfOLcBYjHWMlR9pScAsVtBBg/4+eY=; b=J9mBgv2DckWa665XI+yzUXQYMrTNE0YSwjUCU7Y92gkduPxSPVzTvO+Cuy/Q8k3QjDS2nH 3OSU8TbEng0Ysig1QCuqQxcCGdJ2zD/W/taTb8EErRTfUCWcHuayrl9DkNJNrM+IwD/eVX orhNidgQf36FhSmFVEsQSsOZU6HtV3NBX8XUVni47xbCsENNasmzAryFL8QXU/4nwDnSm6 UhTD9vCe0RKpJlRy9JwpMmzMtLvuskP+CYR9SYTLiaHQmppeuS/yqTUFVHz4xx460hvSq+ qtIU8AIftGvyhUvA7m/pqEk7U8+q+wlR2Z4ng5mBlZ1Zug4YMLdJjF7f5wbK2w== Message-ID: <45cf3d23034dcc8968d1b0fd34e624799d2fb42e.camel@ew.tq-group.com> Subject: Re: [PATCH 5/5] ARM: dts: imx6qdl: Rename USB hub node name From: "Niebel, Markus" To: Alexander Stein , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Krzysztof Kozlowski Cc: Pengutronix Kernel Team , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@ew.tq-group.com Date: Tue, 13 Aug 2024 15:13:53 +0200 In-Reply-To: <2621134.Lt9SDvczpP@steina-w> References: <20240812143431.98323-1-Markus.Niebel@ew.tq-group.com> <1901821.CQOukoFCf9@steina-w> <82ee2be2-366e-40b2-ac95-e755443032be@kernel.org> <2621134.Lt9SDvczpP@steina-w> Organization: TQ-Systems GmbH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240813_061402_300547_C31EC3F6 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Markus.Niebel@ew.tq-group.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2024-08-13 at 13:02 +0200, Alexander Stein wrote: > Am Dienstag, 13. August 2024, 11:44:28 CEST schrieb Krzysztof Kozlowski: > > On 13/08/2024 11:27, Alexander Stein wrote: > > > Am Dienstag, 13. August 2024, 11:20:08 CEST schrieb Krzysztof Kozlows= ki: > > > > On 12/08/2024 16:34, Markus Niebel wrote: > > > > > From: Alexander Stein > > > > >=20 > > > > > According to microchip,usb2514.yaml the node name shall be usb-hu= b. > > > >=20 > > > > That's not true. The schema does not say anything like this. Old na= me is > > > > correct. NAK. > > >=20 > > > So, is the schema incorrect? There is the dtbs_check warning: > > > arch/arm/boot/dts/nxp/imx/imx6q-mba6b.dtb: hub@1: $nodename:0: 'hub@1= ' does not match '^usb(@.*)?' > > > from schema $id: http://devicetree.org/schemas/usb/microchip,= usb2514.yaml# > >=20 > > If you have a warning, shorten it and paste it so this will be obvious. > > If you look at several bindings, the hub is widely used name. I think > > the schema is not correct here - I do not see any properties from > > usb.yaml being used here (for usb2514). What's more, if you compare > > usb2514 with any other on-board HUB representations (because that's the > > only point why we have it in bindings, right?), none of them reference > > usb(-hcd)?.yaml. > >=20 > > These are not USB controllers, IMO. >=20 > I raised that concern in [1] already, but nobody commented. >=20 Besides that, current version of device tree specification [1], section '2.2.2 Generic Names Recommendation' exlicitely suggests 'usb-hub' but not 'hub' See https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.= 4 > Best regards, > Alexander >=20 > [1] https://lore.kernel.org/all/3633627.mvXUDI8C0e@steina-w/ Best regards, Markus --=C2=A0 TQ-Systems GmbH | M=C3=BChlstra=C3=9Fe 2, Gut Delling | 82229 Seefeld, Germ= any Amtsgericht M=C3=BCnchen, HRB 105018 Gesch=C3=A4ftsf=C3=BChrer: Detlef Schneider, R=C3=BCdiger Stahl, Stefan Sch= neider http://www.tq-group.com/