From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 566C3C433EF for ; Tue, 21 Jun 2022 12:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=35OmgAQCZBSPLSfgTzgLgCDJeCkkVDvIpp98ZH96dHw=; b=oTxJbuNkbZFuov lvGUjUzlIhLk/hre06UWhBgstJOwJ26zRFk3tVSGV9qybwMUUhxvJCfTDiKSN791oNTdlNyqR/MJo hkJc+Cprgne+oEc+szSwawZI7WxnK4/FGSjocFTgg1WdnwghGeaG9MOEJwtWfa3LEP6SxHJ/CF1sR UR5jTPBNW/Ffm6nYXxMIEdp1gUfF3M9GGsFPP+9Gafxjwgnf0jcXJdG2OS7TszMKePy+2vHUXcQBu qtumOXzk5Lxi/EICiUbU2fdshWzrF9uhomxpYJ83LYAttO2+Fop5QYImzALN6ngbZfoo3wM7Gu9Ds S+mlYv7TQKmM5wZ0uz6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3dGS-005PqD-7a; Tue, 21 Jun 2022 12:45:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3dFX-005PL6-Ll for linux-arm-kernel@lists.infradead.org; Tue, 21 Jun 2022 12:44:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09B6E165C; Tue, 21 Jun 2022 05:44:51 -0700 (PDT) Received: from [10.57.85.30] (unknown [10.57.85.30]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0EAD03F534; Tue, 21 Jun 2022 05:44:48 -0700 (PDT) Message-ID: <45ef3221-8f27-0ae7-8cd9-48575812d797@arm.com> Date: Tue, 21 Jun 2022 13:44:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] drm/sun4i: Add DMA mask and segment size Content-Language: en-GB To: Jernej Skrabec , mripard@kernel.org, wens@csie.org Cc: airlied@linux.ie, daniel@ffwll.ch, samuel@sholland.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220620181333.650301-1-jernej.skrabec@gmail.com> From: Robin Murphy In-Reply-To: <20220620181333.650301-1-jernej.skrabec@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_054455_838986_22606228 X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-06-20 19:13, Jernej Skrabec wrote: > Kernel occasionally complains that there is mismatch in segment size > when trying to render HW decoded videos and rendering them directly with > sun4i DRM driver. Following message can be observed on H6 SoC: > > [ 184.298308] ------------[ cut here ]------------ > [ 184.298326] DMA-API: sun4i-drm display-engine: mapping sg segment longer than device claims to support [len=6144000] [max=65536] > [ 184.298364] WARNING: CPU: 1 PID: 382 at kernel/dma/debug.c:1162 debug_dma_map_sg+0x2b0/0x350 > [ 184.322997] CPU: 1 PID: 382 Comm: ffmpeg Not tainted 5.19.0-rc1+ #1331 > [ 184.329533] Hardware name: Tanix TX6 (DT) > [ 184.333544] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 184.340512] pc : debug_dma_map_sg+0x2b0/0x350 > [ 184.344882] lr : debug_dma_map_sg+0x2b0/0x350 > [ 184.349250] sp : ffff800009f33a50 > [ 184.352567] x29: ffff800009f33a50 x28: 0000000000010000 x27: ffff000001b86c00 > [ 184.359725] x26: ffffffffffffffff x25: ffff000005d8cc80 x24: 0000000000000000 > [ 184.366879] x23: ffff80000939ab18 x22: 0000000000000001 x21: 0000000000000001 > [ 184.374031] x20: 0000000000000000 x19: ffff0000018a7410 x18: ffffffffffffffff > [ 184.381186] x17: 0000000000000000 x16: 0000000000000000 x15: ffffffffffffffff > [ 184.388338] x14: 0000000000000001 x13: ffff800009534e86 x12: 6f70707573206f74 > [ 184.395493] x11: 20736d69616c6320 x10: 000000000000000a x9 : 0000000000010000 > [ 184.402647] x8 : ffff8000093b6d40 x7 : ffff800009f33850 x6 : 000000000000000c > [ 184.409800] x5 : ffff0000bf997940 x4 : 0000000000000000 x3 : 0000000000000027 > [ 184.416953] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff000003960e80 > [ 184.424106] Call trace: > [ 184.426556] debug_dma_map_sg+0x2b0/0x350 > [ 184.430580] __dma_map_sg_attrs+0xa0/0x110 > [ 184.434687] dma_map_sgtable+0x28/0x4c > [ 184.438447] vb2_dc_dmabuf_ops_map+0x60/0xcc > [ 184.442729] __map_dma_buf+0x2c/0xd4 > [ 184.446321] dma_buf_map_attachment+0xa0/0x130 > [ 184.450777] drm_gem_prime_import_dev+0x7c/0x18c > [ 184.455410] drm_gem_prime_fd_to_handle+0x1b8/0x214 > [ 184.460300] drm_prime_fd_to_handle_ioctl+0x2c/0x40 > [ 184.465190] drm_ioctl_kernel+0xc4/0x174 > [ 184.469123] drm_ioctl+0x204/0x420 > [ 184.472534] __arm64_sys_ioctl+0xac/0xf0 > [ 184.476474] invoke_syscall+0x48/0x114 > [ 184.480240] el0_svc_common.constprop.0+0x44/0xec > [ 184.484956] do_el0_svc+0x2c/0xc0 > [ 184.488283] el0_svc+0x2c/0x84 > [ 184.491354] el0t_64_sync_handler+0x11c/0x150 > [ 184.495723] el0t_64_sync+0x18c/0x190 > [ 184.499397] ---[ end trace 0000000000000000 ]--- > > Fix that by setting DMA mask and segment size. > > Signed-off-by: Jernej Skrabec > --- > Changes from v1: > - added comment > - updated commit message with kernel report > > drivers/gpu/drm/sun4i/sun4i_drv.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c > index 275f7e4a03ae..f135a6b3cadb 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_drv.c > +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c > @@ -7,6 +7,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -367,6 +368,13 @@ static int sun4i_drv_probe(struct platform_device *pdev) > > INIT_KFIFO(list.fifo); > > + /* > + * DE2 and DE3 cores actually supports 40-bit addresses, but > + * driver does not. > + */ > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > + dma_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); Nit: this one is a number, not a bitmask, so UINT_MAX would be more appropriate semantically. Thanks, Robin. > + > for (i = 0;; i++) { > struct device_node *pipeline = of_parse_phandle(np, > "allwinner,pipelines", _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel