From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7881CAC5BB for ; Wed, 8 Oct 2025 18:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fZaXt+gShwcST4niGAvItceQr0XW4MXQVlljb1xZ9gY=; b=tBua4s+V38ZaQk2iuMbySDnL2s hN6rJHoQYg5zV95A4QKe9DDle/xm3r8Aq63pQPSqV7sMe0WN4/skaFs8xtlRqRSGHoFhtL1ELRLg/ TZTKpGcYsprFzVwzNJnxo2Gir1+vVmIVpUZxSVUHhtZB/E1QW/7DPOuGV9Xd2mSrOC9LswWMnAX1R AEVfCVEtzqT6cdB3+rX9t9x9GSoeLf1ihMJ3UWP3koncSzh6mw9PQoSB+7Q2PshhKkwDjuZYhEu/s 4U5mULa0KyaY8C33x2T2dsdxY2Z4IwIvXF/bM9L6MAs1HjE6IAqhlJv/Jpv59AcgBsjUgePv1783m Vv5tfzPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v6YfC-00000004SZ5-1bgw; Wed, 08 Oct 2025 18:13:22 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v6YfA-00000004SY6-1H0U for linux-arm-kernel@lists.infradead.org; Wed, 08 Oct 2025 18:13:21 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-46e2c3b6d4cso1029465e9.3 for ; Wed, 08 Oct 2025 11:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759947198; x=1760551998; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=fZaXt+gShwcST4niGAvItceQr0XW4MXQVlljb1xZ9gY=; b=fbRK9YLOCxXTUzGxScTyibKYACuTmik7splNwrRKBHI4zvucmGJEJY+fiGEuOJ2LrV 0o/eRAq4BWdNWbekohzZ/W1hHNGFXTvX3q7GceB7bhp3gJlBHMC3kpj8Fa4EMg6gPGgc TS9vQcHGXvzm5+0qqvjC4WJ6gqjHtpxZJ3v97b/ewfOPpSZiOq4/dFS0aJ9IguoGRi2F NYNIy3iaM9O3N3DcmhvDx0eoWppghZIp6D+Cw0rFnL6vTLcUSPLjusVWu6r3IIcvNDif F/ioP5ANYHyYTlaNs8bGia3uQ4MfJigV246Ocq1ztQ7NXaaSPsN77xuIL3SSLcrknyui CxUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759947198; x=1760551998; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fZaXt+gShwcST4niGAvItceQr0XW4MXQVlljb1xZ9gY=; b=iBHsB+Eyfumi4HDGsVbCmklJTJp0ZEfz2ClIw4yBG+paqTlR/j42UKs+NM3l++CS5N xeajIzaMm3AI2rsBjmtzYvJFDghOrtQObBbpP09PeTK+U5XGVeVlFdeIRGd1n77sMj73 54oWM0JdwV52J3OrcZ4gPv4VnRmgnk4lI4r/LsoKCO2QELU5YDFjW67NWOWWfRa2NKYr JkxGLmds5bibRtisFGjiBVgjkeVhHDUvdCFCw0jmkf4cjblT/lR16mbW0rZvbDl2IT8u pg7HQsWra/LY6F1QiUs5HNZ2QMOFmNZUltrE1rJ7+lQGNk+gtwP8rm+87DVkF1r3eLKD XiYg== X-Forwarded-Encrypted: i=1; AJvYcCUrKC3HM57yXjQuKoyDtVhmcz5FQNl9Ivzxsj4+ikgNo4uoR++cawwKFkCDR16mmEaXknCo/4ZLCVN5Ns55FtXi@lists.infradead.org X-Gm-Message-State: AOJu0YyJQgjuElajGphw4GwuEakoCI3rFvX7pNRKy6ZK+/jW9BhPqfvr EXCAfosbAMb3toO88MJuCo/jgGeso322RwLx32EnjoQWpFTlIjcoSB5X2JdtRsbc3EE= X-Gm-Gg: ASbGncuVVXCBzkG/L+QS/1UkMLF1cJlbsTpDdyAaTeVOCkZhSazgxK6Z7FF+SHy7DHm WNaJpO3Pci1jMKlFUdvs52v97gnl8/jYm1ZC4v8vjxrHw9Cj60hm2mPKNhL8JrlcQDwaeE2e5u+ xkaTxqtI3NiSngSGv4w9kJ3G2pcXDHzmox5a9vhdrmgu1AbmIWEIxJTSbTr061jDIiushAaERTA 1OCDm4tNVJdfTlU4IYs4JLWgooao5VqlXKwwB0fhBS4l/LUAcH+qYRycFJLN2LDjmpFMnaJEzZd EEIZFHxWhiyn8MaLUjaox2qfabFBvOMiagvPii4Czmvu4BxGqNq+zy3AKyy5YnvFIAm4M1zmQpk OkRNschL0XsSP8r2NyKOzX1WQgCTLIE4jI9nr/d9RTPVamxSjE3XJG7ITWPtFmfKx1FK+b8dS3D kWHqTutgsqk/+y2tiWrvc= X-Google-Smtp-Source: AGHT+IH66uhKvXnvTehKe3lInuC7qmM/YcfilA/g+9CQ8oNy3NiDtUo8BeUgAB3WyYNGUPEby1HO9Q== X-Received: by 2002:a05:600c:8b16:b0:46e:4004:a296 with SMTP id 5b1f17b1804b1-46fa9a965a9mr35155715e9.9.1759947197837; Wed, 08 Oct 2025 11:13:17 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:b264:afbc:dee:3d? ([2a01:e0a:3d9:2080:b264:afbc:dee:3d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f0853sm31405791f8f.50.2025.10.08.11.13.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Oct 2025 11:13:17 -0700 (PDT) Message-ID: <45f68b22-4514-4ddf-95e7-e00f45561307@linaro.org> Date: Wed, 8 Oct 2025 20:13:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 03/25] media: meson-g2d: Drop unneeded v4l2_m2m_get_vq() NULL check To: Laurent Pinchart , linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Nicolas Dufresne , Kevin Hilman , Jerome Brunet , Martin Blumenstingl References: <20251008175052.19925-1-laurent.pinchart@ideasonboard.com> <20251008175052.19925-4-laurent.pinchart@ideasonboard.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20251008175052.19925-4-laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251008_111320_510761_A94CA86E X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/8/25 19:50, Laurent Pinchart wrote: > The v4l2_m2m_get_vq() function never returns NULL. The check was > probably intended to catch invalid format types, but that's not needed > as the V4L2 core picks the appropriate VIDIOC_G_FMT ioctl handler based > on the format type, so the type can't be incorrect. Drop the unneeded > return value check and, as the return value is not used for other > purposes and the function has no side effect, the function call as well. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/platform/amlogic/meson-ge2d/ge2d.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/media/platform/amlogic/meson-ge2d/ge2d.c b/drivers/media/platform/amlogic/meson-ge2d/ge2d.c > index 0c004bb8ba05..a9323b383547 100644 > --- a/drivers/media/platform/amlogic/meson-ge2d/ge2d.c > +++ b/drivers/media/platform/amlogic/meson-ge2d/ge2d.c > @@ -627,13 +627,8 @@ static int vidioc_s_fmt_cap(struct file *file, void *priv, struct v4l2_format *f > static int vidioc_g_fmt(struct file *file, void *priv, struct v4l2_format *f) > { > struct ge2d_ctx *ctx = priv; > - struct vb2_queue *vq; > struct ge2d_frame *frm; > > - vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type); > - if (!vq) > - return -EINVAL; > - > frm = get_frame(ctx, f->type); > > f->fmt.pix = frm->pix_fmt; Reviewed-by: Neil Armstrong