From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1BFDC76188 for ; Fri, 19 Jul 2019 06:54:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FE4421849 for ; Fri, 19 Jul 2019 06:54:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dr2DP+gY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="ilyVoTZk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FE4421849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7bL0uDWh9goN5IzTDThYV2Cc6Prrs0mAJHKybzz/h3A=; b=dr2DP+gYc+ksBP rllyDrPq39DExsDQUigs4gi4ksGcHm83UF0HLuG4W48lfoPBCRjBD37m6pPXv8mMM8o2VqEloxNel 7E0pjRktzbSv4H48NBmmX7Gp7Y5w+98B/fkhTHX1EioK/l7+lA7TE0IzANAOjwyPPsPBYQn3mvUht qJ0Jy0spr4CNXmEju/LxYyplKDlOoXhqMhuSSROrFeK8ZuHkLYsaO0GwaPTBDWuiI9yy3lw9FGZHX I7iXCsEDqKK3mUFlLnVCEUsf2qn0k0t0ywITHi8HNfolh1W7lUZF/zNlaBifpfTbmna02bnUUbcgi qxOfxrPPaLletZ3dcBYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoMmm-0001Cu-TE; Fri, 19 Jul 2019 06:54:32 +0000 Received: from mail-eopbgr720047.outbound.protection.outlook.com ([40.107.72.47] helo=NAM05-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoMmj-0001BU-D1; Fri, 19 Jul 2019 06:54:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I9x2+GJjO7j+rKYBEb4xSzvuax9c1GWjPisrzAAGkmgrnVYgP04rHkHjw98rpjY6ZeLS7pcIkLsIGbJuWSaCt1qXPG8XOMiRv7EOZ84MK+kDJ0WKicgtnbk61RoVyCsBDXAu2X0lxdTwn9OzdQTp73JcTRA6IE8xye7NAwxnNT1dzzpjanTMqyVQOMd0eOgjhQ4ITgy6hxxU9bhsXrcZbFzKhFZD3cluMZI7cwtBC0mVwdvkUrIoXwIlIvA6k6RrPZ/75xBzrLnxFsFqwCt8I4VdJp5frDtBW+TvtMhghDhtL2iX8/wfvoG5em2orZ4DQ50UqrF0+E8ca80ZLWMcNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rhk+nIT65fF//Ls04nAYxki4vfS4MA9rvnAiIwIonoc=; b=U1OzvGLLDgnIJDqTEVQhzlAWwu0XFX+G8fydNxaZwTrA3rgoxjkLezqgwTm+Bs554cKfTanT/dR+HRNxcSPsunXO3CPon44/CD2nAva2lUWS2BlqGGej7dMYxBU0+D3hBtCL6enpudzXUbYUDsY/aL8ewO/fwxGC5+7fx7jGX6pVPtyOsdvnK3mUy8jkaaBX9kHvyzLXaOY4pYVz4oEKiKitsWRWbc5aFj4T4T16WdSazrlsT48ubgh/Zcjy+G5bemDz8obhkr+gVZgMFFmtpXNhTYcTUcgqj35kTFY7e1dUZzIIfgA+m9wndFpdaelMPjkpoRVCRiduOuAmXlGYUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=amd.com;dmarc=pass action=none header.from=amd.com;dkim=pass header.d=amd.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rhk+nIT65fF//Ls04nAYxki4vfS4MA9rvnAiIwIonoc=; b=ilyVoTZk5JK3eNTBfQKnsaiwNFkp5iUA/zIg5D/k2OLi4KvnmZA1okLfCvahm8Um8N4dfGR8D2M+1gzLIOMU/AczP55M7lXh9r/XWRGa3WAwBF3na35Qo1RkwSbh9bNx4Y9OZUbEO2IMVs8Bb38Mf2w4cXSI103yQBzprQfCSJs= Received: from DM5PR12MB1546.namprd12.prod.outlook.com (10.172.36.23) by DM5PR12MB1579.namprd12.prod.outlook.com (10.172.38.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Fri, 19 Jul 2019 06:54:26 +0000 Received: from DM5PR12MB1546.namprd12.prod.outlook.com ([fe80::cda7:cfc1:ce62:bcb7]) by DM5PR12MB1546.namprd12.prod.outlook.com ([fe80::cda7:cfc1:ce62:bcb7%10]) with mapi id 15.20.2094.011; Fri, 19 Jul 2019 06:54:26 +0000 From: "Koenig, Christian" To: Chris Wilson , Intel Graphics Development , Sam Ravnborg , "dri-devel@lists.freedesktop.org" Subject: Re: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Thread-Topic: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Thread-Index: AQHVPYQGC1CUWl5tBEabUnuzJI4nDabQlbYAgADs0IA= Date: Fri, 19 Jul 2019 06:54:25 +0000 Message-ID: <460bf1e1-a38b-5f79-26e5-93764067f4e1@amd.com> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-3-sam@ravnborg.org> <156346840026.24728.936589728458336617@skylake-alporthouse-com> In-Reply-To: <156346840026.24728.936589728458336617@skylake-alporthouse-com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 x-originating-ip: [2a02:908:1252:fb60:be8a:bd56:1f94:86e7] x-clientproxiedby: PR2P264CA0019.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::31) To DM5PR12MB1546.namprd12.prod.outlook.com (2603:10b6:4:8::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2130c504-0d8f-467b-7ca7-08d70c15efcd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DM5PR12MB1579; x-ms-traffictypediagnostic: DM5PR12MB1579: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 01039C93E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(376002)(346002)(366004)(189003)(199004)(66946007)(6486002)(14454004)(6512007)(53936002)(5660300002)(6116002)(229853002)(478600001)(65956001)(2501003)(58126008)(86362001)(6246003)(68736007)(6436002)(256004)(36756003)(99286004)(2906002)(81166006)(46003)(186003)(71200400001)(64126003)(8936002)(25786009)(31686004)(446003)(11346002)(65826007)(7416002)(71190400001)(81156014)(8676002)(2616005)(486006)(6506007)(7736002)(110136005)(386003)(54906003)(65806001)(4326008)(66476007)(66446008)(66556008)(31696002)(64756008)(76176011)(52116002)(476003)(316002)(102836004)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR12MB1579; H:DM5PR12MB1546.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zI2EXEMpXPJXrlBcrNy3622k0Jdp8pmMUuW1ZZoWJLIVolPPAXqA61OOZAhqoVoTIjuo9S+ocCKBl2ZbOMTU772vizWgEorgzWkPuDSxiqXCAlwhBYlj6hfTFEKyLdtOVMwKmSy7gnXbva5kk+vCTcSfSnt7cc6BsVIXt0S3rKn9x9Mwl+M1fn9OPAJdZUzoQjS7ufn69XyxzmWsMC6qZqbTg39utwWFyecRLH/j+kD9QwC+WXkEpzvVQdF4ZaYOg/qFXvY+0r903R0K9snwWqG2RokwZKXNQeqYCSvJmQRKEzuYhf2jKtV+JEcNCyZU6xz6XODKTDG58RQPXFv/oLI+Y2HdvkAH4jO+HVhucpw2T8p9HQMvq71zM+JoM44f9VO4wi5fwSqfjjCnjh3rofv73OxOmXxKePSMuLWhW98= Content-ID: <0F13428D29D0644B8089D84916AB9841@namprd12.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2130c504-0d8f-467b-7ca7-08d70c15efcd X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2019 06:54:25.7325 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ckoenig@amd.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1579 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_235429_474349_DB8F03B0 X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Liviu Dudau , Lionel Landwerlin , Eric Anholt , "Zhou, David\(ChunMing\)" , Maxime Ripard , CK Hu , Thierry Reding , Thomas Zimmermann , Rob Herring , Jani Nikula , Maarten Lankhorst , "linux-mediatek@lists.infradead.org" , Stefan Agner , Matthias Brugger , Daniel Vetter , Sean Paul , "linux-arm-kernel@lists.infradead.org" , Boris Brezillon , Rob Clark , =?utf-8?B?Tm9yYWxmIFRyw7hubmVz?= , Philipp Zabel , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 18.07.19 um 18:46 schrieb Chris Wilson: > Quoting Sam Ravnborg (2019-07-18 17:14:58) >> drm_print.h used DRM_NAME - thus adding a dependency from >> include/drm/drm_print.h => uapi/drm/drm.h >> >> Hardcode the name "drm" to break this dependency. >> The idea is that there shall be a minimal dependency >> between include/drm/* and uapi/* >> >> Signed-off-by: Sam Ravnborg >> Suggested-by: Daniel Vetter >> Reviewed-by: Daniel Vetter >> Cc: Maarten Lankhorst >> Cc: Maxime Ripard >> Cc: Sean Paul >> Cc: David Airlie >> Cc: Rob Clark >> Cc: Sean Paul >> Cc: Chris Wilson >> Cc: Daniel Vetter >> --- >> include/drm/drm_print.h | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h >> index a5d6f2f3e430..760d1bd0eaf1 100644 >> --- a/include/drm/drm_print.h >> +++ b/include/drm/drm_print.h >> @@ -32,8 +32,6 @@ >> #include >> #include >> >> -#include >> - >> /** >> * DOC: print >> * >> @@ -287,7 +285,7 @@ void drm_err(const char *format, ...); >> /* Macros to make printk easier */ >> >> #define _DRM_PRINTK(once, level, fmt, ...) \ >> - printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__) >> + printk##once(KERN_##level "[drm] " fmt, ##__VA_ARGS__) > I guess I'm th only one who > > #undef DRM_NAME > #define DRM_NAME i915 > > just so that I didn't have inane logs? > > One might suggest that instead of hardcoding it, follow the pr_fmt() > pattern and only add "[drm]" for the drm core. > > Even then it so useless (which drm driver is this message for???) that I > want to remove them all :( Yeah, agree. I mean it is nice if the core drm functions use a prefix for debug output. But I actually don't see the point for individual drivers. Christian. > -Chris _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel