From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD780606A31C for ; Thu, 12 Nov 2026 12:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ROMBFzro; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=bCSMFy5h DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:In-Reply-To:From:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=Xw7r6iF+zO8fXkdzLRufgVhinglmDPnuGGdycV+HHa4=; b=ROMBFzrotLQukN E15YaSqkW9+o0A5DA1gCtcqBL5476xU58luoEdScH3rJVbzwm21nsS0rv8uA2LbG8P2iYKLL8WDS8 iaK09GPgjvxYL7xbLys5VeQBfXcU7Xdqg8pKbrSHIRfzYjnt5QHcpV2FhQ4N5pJO8TypOU3NkfG5x vXWVgEhbh0I4cVzXWbs1fvW8Twj54Etxxaj6IG1bzysaIz1LphcvvtPr45Z5uE2+0/N3hyaEnl2yd gcjXssxuHeV8Xe3UP6ia1avSNE5TXY5bgySqe5U8SdKet9IGVlWTlnsQGqpXZX66gcbC+vcnD0SSp xPLnCAJolbk2y+t5p3LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRTWH-00000009o4V-38tb; Thu, 12 Nov 2026 12:03:09 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRTWD-00000009o3D-0UBQ for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2026 12:03:07 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20261112120258euoutp01964489faf544bdddd3f3211e2255de7c~nSpSE0Td51139111391euoutp01a; Thu, 12 Nov 2026 12:02:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20261112120258euoutp01964489faf544bdddd3f3211e2255de7c~nSpSE0Td51139111391euoutp01a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1794484978; bh=Xw7r6iF+zO8fXkdzLRufgVhinglmDPnuGGdycV+HHa4=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=bCSMFy5h9WR5MXhQfr/yYMe50oNl4ZJ3B9PhLvn3AfoVJ3Uyo+MSQBjlm9BDOqF/s YI8qgTWpK/VpOR25WqLm1BIOQY430YCMn2hX6owWJ0ZuGG39vX4A1Pt/J8PKIj6edQ 41nNcZwJxZucP719/0INyVtl5uX7gSp1npjbR8yk= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20261112120258eucas1p1c5cb56175a355c1eae521563b7e5958f~nSpR05hFs2595725957eucas1p1w; Thu, 12 Nov 2026 12:02:58 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20261112120256eusmtip247d84ecda0f477bf594f640a7999ebf7~nSpQMIK460511505115eusmtip2L; Thu, 12 Nov 2026 12:02:56 +0000 (GMT) Message-ID: <46236db8-c386-4db6-a8cd-e08073a5db0a@samsung.com> Date: Thu, 12 Nov 2026 13:02:55 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/15] lib/lz4: switch the compressor to the vendored sources To: Sergey Senozhatsky Cc: Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Minchan Kim , Jens Axboe , Andrew Morton , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org, Yann Collet , Nick Terrell , Gao Xiang , Chao Yu , Jaegeuk Kim , Eric Biggers , Herbert Xu , David Laight , Sungguk , Jaehoon Chung , Marek Szyprowski , linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org Content-Language: en-US From: Michal Wilczynski In-Reply-To: Content-Transfer-Encoding: 7bit X-CMS-MailID: 20261112120258eucas1p1c5cb56175a355c1eae521563b7e5958f X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20261106144305eucas1p17b3b27d403dc7d13b85cdd9a4bea83b9 X-EPHeader: CA X-CMS-RootMailID: 20261106144305eucas1p17b3b27d403dc7d13b85cdd9a4bea83b9 References: <20261106-lz4-vendor-upstream-v2-0-ee04c3f0d7dc@samsung.com> <20261106-lz4-vendor-upstream-v2-10-ee04c3f0d7dc@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261112_040305_755478_3D1C8E90 X-CRM114-Status: GOOD ( 13.48 ) X-Spam-Score: -4.4 (----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/10/26 06:36, Sergey Senozhatsky wrote: > On (26/11/06 15:42), Michal Wilczynski wrote: > [..] >> diff --git a/drivers/block/zram/backend_lz4.c b/drivers/block/zram/backend_lz4.c >> index 1e4ad31d39a63f45b3bddd3d8a467d8d7d095beb..50265e3ce256490994cb6dae32a45da376e408e0 100644 >> --- a/drivers/block/zram/backend_lz4.c >> +++ b/drivers/block/zram/backend_lz4.c >> @@ -42,7 +42,7 @@ static int lz4_setup_params(struct zcomp_params *params) >> if (!params->dict || !params->dict_sz) >> return 0; >> >> - dict_stream = kzalloc_obj(*dict_stream); >> + dict_stream = kzalloc(LZ4_MEM_COMPRESS, GFP_KERNEL); >> if (!dict_stream) >> return -ENOMEM; >> >> @@ -88,7 +88,7 @@ static int lz4_create(struct zcomp_params *params, struct zcomp_ctx *ctx) >> if (!zctx->dstrm) >> goto error; >> >> - zctx->cstrm = kzalloc_obj(*zctx->cstrm); >> + zctx->cstrm = kzalloc(LZ4_MEM_COMPRESS, GFP_KERNEL); >> if (!zctx->cstrm) >> goto error; >> } >> @@ -112,7 +112,7 @@ static int lz4_compress(struct zcomp_params *params, struct zcomp_ctx *ctx, >> zctx->mem); >> } else { >> /* Cstrm needs to be reset */ >> - memcpy(zctx->cstrm, params->drv_data, sizeof(*zctx->cstrm)); >> + memcpy(zctx->cstrm, params->drv_data, LZ4_MEM_COMPRESS); >> ret = LZ4_compress_fast_continue(zctx->cstrm, req->src, >> req->dst, req->src_len, >> req->dst_len, params->level); > > The zram code here is outdated, it has been reworked quite a bit > (patches are in linux-next and Andrew's trees). > Right, I'll rebase on linux-next. Best regards, -- Michal Wilczynski