From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 06 May 2015 09:31:42 +0200 Subject: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. In-Reply-To: References: <1430817426-5241-1-git-send-email-stripathi@apm.com> Message-ID: <4635229.bceBxngCoe@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote: > >> @@ -533,6 +567,16 @@ > >> interrupts = <0x0 0x4f 0x4>; > >> }; > >> > >> + sdhc0: sdhc at 1c000000 { > >> + device_type = "sdhc"; > > > > device_type generally should not be used (there are a few exceptions). > > Okay !! > While we're at it, please change sdhc at 1c000000 to mmc at 1c000000. Even though Linux does not care, we try to use the standard device names for consistency. Arnd