From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
Michael Klein <michael@fossekall.de>
Cc: Michael Klein <michael@fossekall.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs
Date: Thu, 13 Mar 2025 07:07:24 +0100 [thread overview]
Message-ID: <4637912.LvFx2qVVIh@jernej-laptop> (raw)
In-Reply-To: <20250312193629.85417-2-michael@fossekall.de>
Hi,
Dne sreda, 12. marec 2025 ob 20:36:28 Srednjeevropski standardni čas je Michael Klein napisal(a):
> The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY.
> Add the corresponding nodes to the device tree.
>
> Signed-off-by: Michael Klein <michael@fossekall.de>
This is patch 2/2. Which one is patch 1/2? I got only one.
Best regards,
Jernej
> ---
> .../boot/dts/allwinner/sun7i-a20-bananapi.dts | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> index 46ecf9db2324..4976453ed192 100644
> --- a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> @@ -48,6 +48,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/leds/common.h>
>
> / {
> model = "LeMaker Banana Pi";
> @@ -169,6 +170,32 @@ &ir0 {
> &gmac_mdio {
> phy1: ethernet-phy@1 {
> reg = <1>;
> +
> + leds {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + color = <LED_COLOR_ID_GREEN>;
> + default-state = "keep";
> + linux,default-trigger = "netdev";
> + };
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_AMBER>;
> + default-state = "keep";
> + linux,default-trigger = "netdev";
> + };
> +
> + led@2 {
> + reg = <2>;
> + color = <LED_COLOR_ID_BLUE>;
> + default-state = "keep";
> + linux,default-trigger = "netdev";
> + };
> + };
> };
> };
>
>
next prev parent reply other threads:[~2025-03-13 6:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250312193629.85417-1-michael@fossekall.de>
2025-03-12 19:36 ` [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs Michael Klein
2025-03-13 6:07 ` Jernej Škrabec [this message]
2025-03-13 8:34 ` Michael Klein
2025-03-13 10:40 ` Andre Przywara
2025-03-13 13:17 ` Andrew Lunn
2025-03-13 16:20 ` Michael Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4637912.LvFx2qVVIh@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=michael@fossekall.de \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox