public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: remove duplicate const qualifier
Date: Mon, 25 Apr 2016 13:38:18 +0200	[thread overview]
Message-ID: <4641918.pNBP5iAK01@wuerfel> (raw)
In-Reply-To: <20160425103911.GO32731@imgtec.com>

On Monday 25 April 2016 11:39:11 Eric Engestrom wrote:
> On Mon, Apr 25, 2016 at 11:57:15AM +0200, Alexandre Belloni wrote:
> > Hi,
> > 
> > this requires a commit message.
> 
> OK? This seems rather pointless in this case (and even more so for the
> typo fix I sent yesterday), but I guess you have some general rule to
> enforce. Would this do then?
> "The second `const` is unnecessary, and is simply ignored by most compilers."

Maybe say you you found it (llvm, sparse, coccinelle?), and why this
is causing a problem for anyone. If it's just unnecessary but not
harmful, I'd probably ignore the patch.

> > Also, you should think about separating those changes in multiple patches
> > to ease inclusion in the kernel.
> 
> I'll resend patch #4 as multiple patches. What the way proper to convey
> that *multiple* new patches replace *one* old one? Is it enough to just
> send those as a reply to this one?

That's fine. Having multiple patches here is slightly better than just
one, but I'd also be fine with just taking the large patch because it
is an identical trivial change in multiple files.

	Arnd

  reply	other threads:[~2016-04-25 11:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1461577678-29517-1-git-send-email-eric.engestrom@imgtec.com>
2016-04-25  9:47 ` [PATCH 2/4] drivers: firmware: psci: remove duplicate const qualifier Eric Engestrom
2016-04-25 10:33   ` Jisheng Zhang
2016-04-25  9:47 ` [PATCH 3/4] dmaengine: pxa_dma: " Eric Engestrom
2016-04-25 19:18   ` Robert Jarzmik
2016-04-26 16:30   ` Vinod Koul
2016-04-25  9:47 ` [PATCH 4/4] ARM: " Eric Engestrom
2016-04-25  9:52   ` Viresh Kumar
2016-04-25  9:57   ` Alexandre Belloni
2016-04-25 10:39     ` Eric Engestrom
2016-04-25 11:38       ` Arnd Bergmann [this message]
2016-04-25 12:58         ` Eric Engestrom
2016-04-25 14:12           ` Nicolas Pitre
2016-04-25 14:37             ` Eric Engestrom
2016-04-26 10:12               ` Krzysztof Hałasa
2016-04-27 20:01               ` Nicolas Pitre
2016-04-25 10:59     ` Sylvain Lemieux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4641918.pNBP5iAK01@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox