Re: [PATCH v2 1/9] kasan: sw_tags: Use arithmetic shift for shadow computation

Andrey Konovalov
2025-02-17T19:02:07Z

On Mon, Feb 17, 2025 at 7:38 PM Maciej Wieczor-Retman
<maciej.wieczor-retman@intel.com> wrote:
>
> >I'm a bit lost with these calculations at this point. Please send the
> >full patch, including the new values for KASAN_SHADOW_OFFSET (do I
> >understand correctly that you want to change them?). It'll be easier
> >to look at the code.
>
> Sorry, this thread became a little bit confusing. No, I think the
> KASAN_SHADOW_OFFSET values are fine. I just wanted to embrace the idea of
> overflow for the purpose of the check in kasan_non_canonical_hook().
>
> But I'll put down my train of thought about the overflow + calculations in the
> patch message.
>
> >
> >Feel free to send this patch separately from the rest of the series,
> >so that we can finalize it first.
>
> I have the x86 tag-based series basically ready (just need to re-read it) so I
> think I can send it as whole with this patch and 3 others from this series.

Sounds good!