From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39940C433EF for ; Thu, 30 Sep 2021 15:42:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A446613A7 for ; Thu, 30 Sep 2021 15:42:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A446613A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C1n454SDvzzeMisVDlpCHOyZ9+v+6ACWMYOq4OEC9Xs=; b=UStJqgepFn1oou /yk0n1MC/0aEHqizulF84C05xd+HEvrZsNaWtgw9mqN1z1xCi+GJqDu5UEou8P0lLVfNwBGfnZlPC pnA7NFtn/l4hz+iSTFu4s6JChMbnmXQXyUzbTiZC9pgxEHUukdGJcS01IScRhKPtIwyVritp4pfr4 wZ1TwGKvTvZc7/QjXwH+v1iYXEKqEJ4oFx064GTKz44yEUGeGDzKZBPUhr5NkGt8SUWMvPzXdNqpC d8hmngqZUm4wq6LPSxiqKxq8eCeyrwy+BWeoK9Kv6C9KnQu4wjTyqKbd5W7u3EWH0G4hIiWHh9lSZ taXyQkvEX6O/MyRewP/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVyAu-00EyL4-0z; Thu, 30 Sep 2021 15:40:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVyAr-00EyKP-4x; Thu, 30 Sep 2021 15:40:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id EC22B617E6; Thu, 30 Sep 2021 15:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633016440; bh=tBrFpWHv+RFng1Nnh9PCJomQIzoau7SxgaKh8lwDiek=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=XaWPFpb+jLfQfp4BpqZJ5BjSjnCG9EpqXYIWNNgj0ezi/9xstwibJfhEUDv78I87/ uN5yh+CQaDyHzQ/uJzCU+4YRUzSf3p8P6PxITybsSF3sCQT05tCOwazzdpbZ53e1LU i28ZMPriWuBQ5WpHMhB+x96iR4d5sKjxPuzGEfKrOWiCCTNX+lA5IV7Ue2JnoQY1c9 wkj47ngrVWQ0dhPKmQPWlhKCjDTFJ1JsnB7A/l98X5kCnSk4ZM1CllQe0RscM6iPsK BJgcm9gFfx+oaXRUJJZdb1vEhhw5YeUD160k1h7odQV0kByuu0eB2CseqAyd0rcsGF EJdzxRMbbpgWg== Message-ID: <464685469b9e96a23a3cf180c82d0b7134ca36bd.camel@kernel.org> Subject: Re: [PATCH] drm/vc4: crtc: Make sure the HDMI controller is powered when disabling From: nicolas saenz julienne To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, Florian Fainelli , linux-arm-kernel@lists.infradead.org Date: Thu, 30 Sep 2021 17:40:36 +0200 In-Reply-To: <20210923185013.826679-1-maxime@cerno.tech> References: <20210923185013.826679-1-maxime@cerno.tech> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_084041_238109_9A9F526D X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2021-09-23 at 20:50 +0200, Maxime Ripard wrote: > Since commit 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot > time"), during the initial setup of the driver we call into the VC4 HDMI > controller hooks to make sure the controller is properly disabled. > > However, we were never making sure that the device was properly powered > while doing so. This never resulted in any (reported) issue in practice, > but since the introduction of commit 4209f03fcb8e ("drm/vc4: hdmi: Warn > if we access the controller while disabled") we get a loud complaint > when we do that kind of access. > > Let's make sure we have the HDMI controller properly powered while > disabling it. > > Fixes: 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot time") > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Regards, Nicolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel