Re: [PATCH v1 3/7] dt-bindings: arm: sunxi: Add NetCube Systems Nagami Keypad Carrier Board

[Krzysztof Kozlowski <krzk@kernel.org>]

On 06/07/2025 11:41, Lukas Schmid wrote:
> On Sonntag, 6. Juli 2025 11:36:34 CEST Krzysztof Kozlowski wrote:
>> On 06/07/2025 11:07, Lukas Schmid wrote:
>>> On Sonntag, 6. Juli 2025 09:49:58 CEST Krzysztof Kozlowski wrote:
>>>> On 05/07/2025 23:38, Lukas Schmid wrote:
>>>>> The NetCube Systems Nagami Keypad Carrier is a custom board intended to
>>>>> fit a standard Ritto Intercom enclosure and provides a Keypad,
>>>>> NFC-Reader
>>>>> and Status-LED all controllable over Ethernet with PoE support.
>>>>>
>>>>> Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li>
>>>>> ---
>>>>>
>>>>>  Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
>>>>>  1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
>>>>> b/Documentation/devicetree/bindings/arm/sunxi.yaml index
>>>>> 7919b5bf5..a2f16d064 100644
>>>>> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
>>>>> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
>>>>>
>>>>> @@ -610,6 +610,12 @@ properties:
>>>>>            - const: netcube,nagami
>>>>>            - const: allwinner,sun8i-t113s
>>>>>
>>>>> +      - description: NetCube Systems Nagami Keypad Carrier Board
>>>>> +        items:
>>>>> +          - const: netcube,nagami-keypad-carrier
>>>>
>>>> That's just enum with previous entry. Don't make it over-complicated.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Just making sure here. The actual bindings are fine, but I should merge
>>> them into one patch, correct?
>>
>> No, you got two comments what should be changed in the binding.
>>
>> Best regards,
>> Krzysztof
> 
> So if I understand correctly you want me to remove the "allwinner,sun8i-t113s" 
> from the carrier boards and keep it for the SoM?
No, I spoke nothing about that compatible. My comment is EXACTLY under
the line being incorrect. That entry should have been made enum with
previous board compatible. Look at other vendors, because this file
repeats that pattern for some reason, eh...

Best regards,
Krzysztof