From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED6FC43381 for ; Tue, 12 Mar 2019 12:45:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9B0C206BA for ; Tue, 12 Mar 2019 12:45:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E5W69meg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9B0C206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N9RYc08omZkAqL/6cUib/SGOj+S+nm+Qu/pSb1mKAI4=; b=E5W69meg9Lu+NKzGibSTsHVyH hMRfCdXtkHDneHa8hQysYvjWYoyNCh63jvMy18EMlTW5/ZxQroDUgoJOuvZ+Hq8ZUhtQawkGYm250 hI2PFdGISobx5fhpM5mV5EXqoqpVf9QGPJ6+fPKHW2L9tS141Ru1e4Y66PgXauyqNvQT/GhVMkHWV RB8ofc2UWfi2+fMAHG+sKw7CwA4U+/dd9M7X4T65UqDalbgWDLcsQnQtypXWrFJpS0vkzhZQYUi2u /ZywyS8+VfWXz066FWOvWkV1K53ra9+rC+Ym/+F4UWAHi8JczOmGxVQkv8VTafGhFU+hXY4ed2NbF SeIwVyTnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3gn2-0003H6-3x; Tue, 12 Mar 2019 12:45:52 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3gmy-0003Fq-6H for linux-arm-kernel@lists.infradead.org; Tue, 12 Mar 2019 12:45:49 +0000 Received: by mail-ed1-f67.google.com with SMTP id e4so2178792edi.3 for ; Tue, 12 Mar 2019 05:45:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SQpSkb2z+kLeEzvXRt/FvYe7fWI5HmkDQf9Mmh9Uxzo=; b=IYptco0vlcp0mUtNeDtAtX/8vyI7P+J8mPYH3MfGj77jnlQYb2aDFH8bPrKaO15V/v Y7v6FAEe3crXDxCn2zXRMCKgSWIO9AHLK8GpByQVBn8kENpOFEmFqpuRg/gFHVbJTsZN fzKDlKtu1ZUL3q+HQftfj6A9LHq2GX+Z0txb6aJSkFQrmFuucbSZcFqP9zlIwY+p9nfq Ep12He1KpmWTGvfZYA7qN8b6MDiTE/tUPQ7mUaWa00Xa2UlrRFKSMp/4/tn2M5yEQlH8 7nCcHLB16HnxtlHnm0JxvltELEPULfHty5SobtMmc5ABnlN1viyZCPOwQeg1HYznxHYy OJNA== X-Gm-Message-State: APjAAAWHOqqS/DPKBx3leh63C7P9NmW8iFvMqym9c9xm7Y7TLfZxaCOh MSu6Q1oLupExAokpoqM401WcrA== X-Google-Smtp-Source: APXvYqzyiL2+2DmIDMeL0MortoUB8IwbMYbn0HEEkQsXmv52rLpQDQt0CI7HcACbAMb1ZIm+e3dt1A== X-Received: by 2002:a17:906:2a9b:: with SMTP id l27mr25849667eje.89.1552394745755; Tue, 12 Mar 2019 05:45:45 -0700 (PDT) Received: from shalem.localdomain (546A5441.cm-12-3b.dynamic.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id l15sm3648070ejn.77.2019.03.12.05.45.44 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 05:45:45 -0700 (PDT) Subject: Re: [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B To: Chunfeng Yun References: <1552025622-15582-1-git-send-email-chunfeng.yun@mediatek.com> <1552025622-15582-2-git-send-email-chunfeng.yun@mediatek.com> <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> <1552282383.10179.21.camel@mhfsdcap03> <1552360688.10179.55.camel@mhfsdcap03> From: Hans de Goede Message-ID: <464f1021-4c5e-9137-489d-65fd578575d3@redhat.com> Date: Tue, 12 Mar 2019 13:45:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1552360688.10179.55.camel@mhfsdcap03> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_054548_240827_F10C8E55 X-CRM114-Status: GOOD ( 22.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 12-03-19 04:18, Chunfeng Yun wrote: > Hi, > On Mon, 2019-03-11 at 09:06 +0100, Hans de Goede wrote: >> Hi, >> >> On 11-03-19 06:33, Chunfeng Yun wrote: >>> Hi, >>> >>> On Fri, 2019-03-08 at 13:07 +0100, Hans de Goede wrote: >>>> Hi, >>>> >>>> On 08-03-19 07:13, Chunfeng Yun wrote: >>>>> Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for >>>>> usb-b-connector >>>>> >>>>> Signed-off-by: Chunfeng Yun >>>>> --- >>>>> .../devicetree/bindings/connector/usb-connector.txt | 10 ++++++++++ >>>>> 1 file changed, 10 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt >>>>> index a9a2f2fc44f2..7a07b0f4f973 100644 >>>>> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt >>>>> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt >>>>> @@ -17,6 +17,16 @@ Optional properties: >>>>> - self-powered: Set this property if the usb device that has its own power >>>>> source. >>>>> >>>>> +Optional properties for usb-b-connector: >>>>> +- id-gpios: gpio for USB ID pin. >>>> >>>> What about boards where the ID pin is *not* connected to a GPIO, >>>> but e.g. to a special pin on the PMIC which can also detect >>>> an ACA adapter ? Currently this case is handled by extcon >>>> drivers, but we have no way to set e.g. vbus-supply for the >>>> connector. Maybe in this case the usb-connector node should >>>> be a child of the PMIC node ? >>> Yes, it would be, PMIC is in charger of detecting the status of ID pin >> >> Ok, then I think this should be documented too. >> >>>> And in many cases there also is a mux to switch the datalines >>>> between the host and device(gadget) controllers, how should >>>> that be described in this model? See the new usb-role-switch >>>> code under drivers/usb/roles >>>> >>>> In some cases the mux is controlled through a gpio, so we >>>> may want to add a "mux-gpios" here in which case we also >>>> need to define what 0/1 means. >>> I'm not sure, the mux seems not belong to this connector, >>> and may need another driver to register usb-role-switch, >>> similar to: >>> >>> [v2,2/2] usb: typec: add typec switch via GPIO control >>> https://patchwork.kernel.org/patch/10834327/ >> >> Right the mux/role-switch will need a driver, but the "owner" >> of the usb_connector, e.g. the PMIC or the owner of the >> id GPIO pin needs to know which device is the role-switch so >> that it can set the role correctly based on the id-pin. >> >> Your binding already contains Vbus info, allowing the owner >> of the usb_connector to enable/disable Vbus based on the id-pin, >> but the owner will also be responsible for setting the role-switch. > In this patch series, I make usb_connector driver enable/disable Vbus, > but not the parent(USB controller) of usb_connector which registers a > usb-role-switch, which way do you think it is better? IMHO there should not be a driver for the usb_connector child-node, only for the parent-device of that child-node. There are going to be too many specific setups surrounding PMICs to be able to do a single generic driver for the connector. Regards, Hans _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel