From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0DA9C433F5 for ; Thu, 10 Feb 2022 12:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rp5gYuviz2Sh2EFH68d+avCCsl4DtOpzrOJcGCbowYE=; b=ALUBeVc18OxbmF 4IHdWIe4tGvS+edwLsswGp7Umie8C80KevE6poFWIBAtmcYjfMGTtKm6bAiwW1idQlnJgui9Ym43g qp8CN75qkXdegTdHWvVGyAYDSPIQOnPKdSUppXYJGqIVnAkDmA+RK5jIeQXWqP717oioIAmw9e7xp gxEhUFOI83c7yhLvHreOnmYrDv/Z5gn1FFunofPzGtmjeSwESuzzYloPkh1KrdSkBvFE2EafIEAhj rEeOUC1p4rdjKzHopFVO/+4FMhc3YBU6duWE+cK8sgty4I2cwPKywhsETUyUkGSLmPwu+fEDJXgJm FVKdT6YO67edQUNo+xMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI8Hq-003jDJ-Np; Thu, 10 Feb 2022 12:10:58 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI8Hl-003jBj-VG for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 12:10:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1644495054; x=1676031054; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nAdroOfhDKWAx0dxTTeJoRwSvUVUVyT6jUggDfYhJuM=; b=Q3G0lenx2VSpUU/XPbyxec8JQ62E1t7wZIc+Lwj+QuQH/+IrYbScltXM L+zvEGwC+Xc5XSdZs4e9/KY6KaDr2uWe8BMl2/fMT3YjOdYjUL9gfZliy mwCsC/D4WYKmv4UDXlPlZWySo4Fwi1nSS8LPo3aPJU5c4wxuUz1ujnIW7 BZuEHmqqcTEeB6S1m2Qzar0I+3ydhyeM5V2ts64m+RSo30SBo23VMUT07 mzf5i58gCnCjI64zxCEDIc3F78tf0OPj0mqQTj/ammYCBUCe3/sRU0qWD lrXcdbGtSvuajNUSbRoKHOa1RoSuJpl8WYA0pVltKSjN6neds7mtQh+Xk w==; X-IronPort-AV: E=Sophos;i="5.88,358,1635199200"; d="scan'208";a="22014737" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 10 Feb 2022 13:10:50 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Thu, 10 Feb 2022 13:10:50 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Thu, 10 Feb 2022 13:10:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1644495050; x=1676031050; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nAdroOfhDKWAx0dxTTeJoRwSvUVUVyT6jUggDfYhJuM=; b=ILSAwGsdqdqoo9apuRoic1Fa+EiOu1pW0Y88IPjuIfvIetlGwTzY7spX jqUXk4K8gJfPcLqeDEgEg4zGc/2YnngXLX9d3KLkatvC8uTJH3KwKhw9Z gWd1EGZFqoPTjH6LvY2HKAe2I274gLFKSK9LQWW89rrBtbOkDOYhDQg0o EgEMD7Fj8xPjaWVkjtwAJbgNY0hEay2/d+b7VRNtD2Wg1M3MZ33JUryFz hmAAup67n/agcityTy1cN/Mx9J465JY5X30OTsNvGLEPk5KaAGM5F00ef 3+J1dAfVP+utBeDXGWwU8oEHz7TzGDWBah5Xv71V8BgI54JWkZoS+NrW7 A==; X-IronPort-AV: E=Sophos;i="5.88,358,1635199200"; d="scan'208";a="22014736" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 10 Feb 2022 13:10:50 +0100 Received: from steina-w.localnet (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id D66E6280065; Thu, 10 Feb 2022 13:10:49 +0100 (CET) From: Alexander Stein To: Krzysztof Kozlowski Cc: Rob Herring , Shawn Guo , Sascha Hauer , Fabio Estevam , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: (EXT) Re: [PATCH 5/5] ARM: dts: imx6ull: add TQ-Systems MBa6ULLxL device trees Date: Thu, 10 Feb 2022 13:10:47 +0100 Message-ID: <4652639.44csPzL39Z@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <0c84c2af-045d-54bc-ef46-296390e58c14@canonical.com> References: <20220208134223.908757-1-alexander.stein@ew.tq-group.com> <20220208134223.908757-6-alexander.stein@ew.tq-group.com> <0c84c2af-045d-54bc-ef46-296390e58c14@canonical.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_041054_430668_1BC9A9DF X-CRM114-Status: GOOD ( 22.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Am Dienstag, 8. Februar 2022, 17:09:33 CET schrieb Krzysztof Kozlowski: > On 08/02/2022 14:42, Alexander Stein wrote: > > Add device trees for the MBa6ULx mainboard with TQMa6ULLxL SoMs. > > > > Signed-off-by: Alexander Stein > > --- > > > > arch/arm/boot/dts/Makefile | 1 + > > .../boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts | 15 ++++ > > arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi | 76 +++++++++++++++++++ > > 3 files changed, 92 insertions(+) > > create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts > > create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 3a6eccb6371a..9bf89273ae71 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -710,6 +710,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \ > > > > imx6ull-phytec-segin-ff-rdk-emmc.dtb \ > > imx6ull-phytec-segin-lc-rdk-nand.dtb \ > > imx6ull-tqma6ull2-mba6ulx.dtb \ > > > > + imx6ull-tqma6ull2l-mba6ulx.dtb \ > > > > imx6ulz-14x14-evk.dtb \ > > imx6ulz-bsh-smm-m2.dtb > > > > dtb-$(CONFIG_SOC_IMX7D) += \ > > > > diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts > > b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts new file mode 100644 > > index 000000000000..33437aae9822 > > --- /dev/null > > +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts > > @@ -0,0 +1,15 @@ > > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT) > > +/* > > + * Copyright 2018-2022 TQ-Systems GmbH > > + * Author: Markus Niebel > > + */ > > + > > +/dts-v1/; > > + > > +#include "imx6ull-tqma6ull2l.dtsi" > > +#include "mba6ulx.dtsi" > > + > > +/ { > > + model = "TQ Systems TQMa6ULL2L SoM on MBa6ULx board"; > > + compatible = "tq,imx6ull-tqma6ull2l-mba6ulx", "tq,imx6ull- tqma6ull2l", > > "fsl,imx6ull"; +}; > > diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi > > b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi new file mode 100644 > > index 000000000000..8e4d5cd18614 > > --- /dev/null > > +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi > > @@ -0,0 +1,76 @@ > > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT) > > +/* > > + * Copyright 2018-2022 TQ-Systems GmbH > > + * Author: Markus Niebel > > + */ > > + > > +#include "imx6ull.dtsi" > > +#include "imx6ul-tqma6ul-common.dtsi" > > +#include "imx6ul-tqma6ulxl-common.dtsi" > > + > > +/ { > > + model = "TQ Systems TQMa6ULL2L SoM"; > > + compatible = "tq,imx6ull-tqma6ull2l", "fsl,imx6ull"; > > +}; > > + > > This entire file is exactly the same as tqma6ull2l.dtsi. What's the > point of creating additional flavor which is exactly the same? The > models look compatible, don't they? Thanks for your fast feedback. You mean imx6ull-tqma6ull2.dtsi (wthout trailing 'l')? In this case it's not exactly the same, because the LGA version includes 'imx6ul-tqma6ulxl-common.dtsi' while the non-LGA one includes 'imx6ul-tqma6ulx-common.dtsi'. I this make things a bit more clear. Regards, Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel